From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pedro Andres Aranda Gutierrez Newsgroups: gmane.emacs.devel Subject: Re: Question on https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d0b1e3647fb4e6d889f9f999388c53daf0e67f0d Date: Thu, 21 Sep 2023 11:59:22 +0200 Message-ID: References: <04a0c0f2-a3b6-47f3-b4da-fed2dadd0ee2@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000006d11ce0605db8df1" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34177"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: =?UTF-8?Q?Gerd_M=C3=B6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 21 12:00:29 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjGU0-0008gY-KO for ged-emacs-devel@m.gmane-mx.org; Thu, 21 Sep 2023 12:00:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjGTS-0001qv-Fj; Thu, 21 Sep 2023 05:59:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjGTR-0001pn-AA for emacs-devel@gnu.org; Thu, 21 Sep 2023 05:59:53 -0400 Original-Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjGTP-0001OX-Iz for emacs-devel@gnu.org; Thu, 21 Sep 2023 05:59:53 -0400 Original-Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-532eb2a1bf8so778480a12.0 for ; Thu, 21 Sep 2023 02:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695290389; x=1695895189; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jJJQW25HX25y4nkfhvse+3q3MlA/Zk79J+99YRz8LRs=; b=Euc1ZiXnTvKew1Oxs+0JyZZ0md10jpFKQ+QuODtEyX56XTH4kFOXsa7x4rlb0OyUHr OU69qA7RhOlgsQH+lmIeRMj97NPn+ht39m75X5TGs7c8dLlu2RrMJrGj4rcZ4RLdsZ7e y8L71/r1GAUpULF+NeDvU0v8guZ8teMtd0EUbxieoxOnvlJ6qXhpoqj3F1BtYGxY1b7f PAjwxaKwcurplL8VOrV54mxSfz+3h00d2PKKYrW4l8NJVkDTRWpZYuVorl90tvbnROLV coVd/p4WJoZ65cIqRghoosbMwRSBYJE7CCe8hAWAv+P0JZklhKpcACdAp8npbBcfBh59 Rtgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695290389; x=1695895189; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jJJQW25HX25y4nkfhvse+3q3MlA/Zk79J+99YRz8LRs=; b=db4jHBWLWnKZGyB9QUWHkInr0C7BP7wbkeQIZdmbfaCh3Z6TjvHaqBSKE+GbZlthi4 Jem89dtfcef8vuzkqi7zvgFAhEg/Z/6l46trm+8egTj+tCNGLgo1GiE3C7NNPhm82KB4 +iYHERaL6slKTNvRVNrI/rTPILXq+ngQELJwR+4haO3l85/FHLcWubyL+vNF/hq/n6Yu n4rnBrr7J9Fg3xCsKmgzAt4o+Q3dtlcQtdfzk0m/2EDSEksF0Eu7DpdOUCT1HOdsJ2OG z5eb3Bo+q+W4N/Upis7JE5OsZ0JwoNiWfVogBjNbufdgYwsG2fxdq7vs1XKKeEzHb9bG 7LvA== X-Gm-Message-State: AOJu0Yw7l9OwnoMD+2vTthzPhwnVaIhPY5mwF/yGMO1yuMBBSuOyiijM KCkV8y6kKn1dkytTipoJRWPy34HVUqnyiJQbW07y8Veg X-Google-Smtp-Source: AGHT+IGFy3wA9Hqyjmx90TMny2/tqu40ufk5ry8OC23hD8jjKGCq0pe/zxSU5S5hQH3/0VIROVDMbp+5lTVm09xLr1o= X-Received: by 2002:aa7:d398:0:b0:530:7abf:3a84 with SMTP id x24-20020aa7d398000000b005307abf3a84mr4456129edq.25.1695290388974; Thu, 21 Sep 2023 02:59:48 -0700 (PDT) In-Reply-To: <04a0c0f2-a3b6-47f3-b4da-fed2dadd0ee2@gmail.com> Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=paaguti@gmail.com; helo=mail-ed1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310879 Archived-At: --0000000000006d11ce0605db8df1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thank you for the clarification! The FIXME was sort of misleading here. A double negation always is ;-) Best, /PA On Thu, 21 Sept 2023 at 10:47, Gerd M=C3=B6llmann wrote: > On 23-09-21 8:29 , Pedro Andres Aranda Gutierrez wrote: > > Hi > > > > reading removed FIXME in the second hunk: > > > > # FIXME: Don't install the dump file into the app bundle when > > # self-contained install is disabled. > > > > I understand that we should install if self-contained is enabled. > > > > However, I see > > > > +ifeq (${ns_self_contained},no) > > > > Shouldn't that read as > > > > +ifeq (${ns_self_contained},yes) > > > > I'm confused... > > I assume that is nextstep/Makefile.in. We want to cp the .pdmp file > only if we don't do a self-contained build (...=3Dno). > > --=20 Fragen sind nicht da, um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler Headaches with a Juju log: unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run a leader-deposed hook here, but we can't yet --0000000000006d11ce0605db8df1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thank you for the clarification!
The FIXME was sor= t of misleading here. A double negation always is ;-)

<= div>Best, /PA=C2=A0

On Thu, 21 Sept 2023 at 10:47, Gerd M=C3=B6llmann = <gerd.moellmann@gmail.com> wrote:
On = 23-09-21 8:29 , Pedro Andres Aranda Gutierrez wrote:
> Hi
>
> reading removed FIXME in the second hunk:
>
> # FIXME: Don't install the dump file into the app bundle when
> # self-contained install is disabled.
>
> I understand that we should install if self-contained is enabled.
>
> However, I see
>
> +ifeq (${ns_self_contained},no)
>
> Shouldn't that read as
>
> +ifeq (${ns_self_contained},yes)
>
> I'm confused...

I assume that is nextstep/Makefile.in.=C2=A0 We want to cp the .pdmp file <= br> only if we don't do a self-contained build (...=3Dno).



--
Fragen sind nicht da, um bea= ntwortet zu werden,
Fragen sind da um gestellt zu werden
= Georg Kreisler

Headaches with a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should ru= n a leader-deposed hook here, but we can't yet

--0000000000006d11ce0605db8df1--