From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pedro Andres Aranda Gutierrez Newsgroups: gmane.emacs.devel Subject: Re: MINI-PATCH: add how to turn auto-completion in test buffers off Date: Fri, 5 Apr 2024 17:02:36 +0200 Message-ID: References: <86y19t55hs.fsf@gnu.org> <86a5m856co.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000a0793b06155ac0aa" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38703"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 05 17:03:55 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rsl6g-0009uK-Vb for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Apr 2024 17:03:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rsl5x-0007BO-FR; Fri, 05 Apr 2024 11:03:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rsl5v-0007As-TE for emacs-devel@gnu.org; Fri, 05 Apr 2024 11:03:07 -0400 Original-Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rsl5t-0006QF-Qb; Fri, 05 Apr 2024 11:03:07 -0400 Original-Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a51a80b190bso46350366b.3; Fri, 05 Apr 2024 08:03:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712329383; x=1712934183; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=EFougwo/KL3NDk9ILemAQHvonRl0EgR64ZDLMGobpyE=; b=PP7D1iV5AViqrw1AUFrwymitWyByqbzKOupr0wWQbdaR9YC4q/kx+iRipq9WUneMCP 6cMJoxkYKr31aSRaq5WcE2YmWmt4wTyIuVHdysVwUx10NLYu1exF0mh39cbEmHUE0Rjb 5v0aW8cC7mqSmwyHQLNO8FhlpLcxcpz+6E1AXww160oErmH2tVmYAQ98A9QTrPjzwBx1 Tnq31uXBEjwNyrUXOj8q4lsHRrtSNoue0Q+ODaJSu9yD5rwdJMnKrUvkfL3nyYz+sd8X bWXbbIbcRSHaNiEkB5js3LIqULI7/hVhe2L/kWOd7Qi1AEbTrwDQfZOhPaEajfCBDmcd sApQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712329383; x=1712934183; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EFougwo/KL3NDk9ILemAQHvonRl0EgR64ZDLMGobpyE=; b=L7NjkJ4dcLZvOYxCwqd7gnRFijf/AyOK61qKchobDElY1GeQG0gUiM0vxW8G6rmypU RBECT9rcLdQc9nO3wRNkuwAyYbKQGp0J+9fmowsmjt16oS/HSOXs6efha6MJ6cuTTUJM PuG9w7FWqvnlzANb26SDmYMNI3w6chVVvubhbFI9BvgVd6yo12vx+1oeV0MQOXa4yJT3 LJX1eA8XFToDgLfDiNXffB8zrEdq+fcbjeN/2TM+voJ/bgLjvhvp5xK/NEVQBqqHDb4I Vjakz+aTFjktFXGx7wDvW6hnNpIbOlbyjDjjbQX6r65mwwAVb6tLwYkdnG/V+ycxq/tz A3eA== X-Gm-Message-State: AOJu0YwuL7/6xvn/qr70LVsP0LwAXVHBM+q2qd4075JWEIehFoDXi/W3 51S92Fr6rp97JqQhk1L9LmEtAmfVkGNCv33xOyXAI+1vImRUURYq4coDDI40rB4nCMaIsXEug1f /cYahhcX/M/l6v66uDCPJLV8kQ/rtvHU6 X-Google-Smtp-Source: AGHT+IEACNoJ4E+OoWgrSAhPU8aa0tMqdYjdiseDFzMSJMI481+4A7Nadl+kdmv+QKkc/j6uqnGZ7heRhzyocPye8/M= X-Received: by 2002:a50:a45d:0:b0:56e:2b80:d87e with SMTP id v29-20020a50a45d000000b0056e2b80d87emr1683918edb.2.1712329383244; Fri, 05 Apr 2024 08:03:03 -0700 (PDT) In-Reply-To: <86a5m856co.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::62f; envelope-from=paaguti@gmail.com; helo=mail-ej1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317552 Archived-At: --000000000000a0793b06155ac0aa Content-Type: text/plain; charset="UTF-8" Hi, answers inline. On Fri, 5 Apr 2024 at 14:42, Eli Zaretskii wrote: > > From: Pedro Andres Aranda Gutierrez > > Date: Fri, 5 Apr 2024 12:25:18 +0200 > > Cc: emacs-devel@gnu.org > > > > so you mean something like the attached patch? > > Almost, see below. > > > diff --git a/doc/emacs/text.texi b/doc/emacs/text.texi > > index cb347d59948..f039c42d46c 100644 > > --- a/doc/emacs/text.texi > > +++ b/doc/emacs/text.texi > > @@ -954,6 +954,11 @@ Text Mode > > Entering Text mode runs the mode hook @code{text-mode-hook} > > (@pxref{Major Modes}). > > > > +@vindex text-mode-ispell-word-completion > > + Entering Text mode also activates auto-complete hints. If you find > > +that this is disturbing for you, set this variable to @code{nil} in > > +your Emacs initialization code. > > This is using the wrong tone for describing the issue: it regards > completion hints in Text Mode as a nuisance in most cases. If it were > such a nuisance, we ought to make it off by default. > I will always remember a friend of mine, who always asked me to disable auto-completion and hints in his word processor, because they distracted him too much from his work and line of thought. And, once again, some concentration deficits need these features to be disabled, so I don't see this as negative, but reaching out to these communities. > Instead, the text should describe the completion hints feature from > the POV of its being useful, and then say that the variable > text-mode-ispell-word-completion controls it. > OK, anyhow, I will try to find another wording. Also, @vindex generates no text in the formatted manual, so you need > to mention the variable in the text as well, otherwise "this variable" > will allude to something the text doesn't mention. > > Finally, please leave two spaces between sentences, per our > conventions. > > > --- a/lisp/textmodes/text-mode.el > > +++ b/lisp/textmodes/text-mode.el > > @@ -145,7 +145,10 @@ text-mode > > You can thus get the full benefit of adaptive filling > > (see the variable `adaptive-fill-mode'). > > \\{text-mode-map} > > -Turning on Text mode runs the normal hook `text-mode-hook'." > > +Turning on Text mode runs the normal hook `text-mode-hook'. > > +By default, `text-mode-hook' will enable completion at point with > > +candidates supplied by `ispell'. You can turn this off by > > +setting `text-mode-ispell-word-completion' to `nil'." > > This part is okay (modulo the 2 spaces between sentences issue). > > Thanks. > /PA -- Fragen sind nicht da, um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler Headaches with a Juju log: unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run a leader-deposed hook here, but we can't yet --000000000000a0793b06155ac0aa Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

answers inline.
On Fri, 5= Apr 2024 at 14:42, Eli Zaretskii <eliz@= gnu.org> wrote:
> From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
> Date: Fri, 5 Apr 2024 12:25:18 +0200
> Cc: emacs-dev= el@gnu.org
>
> so you mean something like the attached patch?

Almost, see below.

> diff --git a/doc/emacs/text.texi b/doc/emacs/text.texi
> index cb347d59948..f039c42d46c 100644
> --- a/doc/emacs/text.texi
> +++ b/doc/emacs/text.texi
> @@ -954,6 +954,11 @@ Text Mode
>=C2=A0 =C2=A0 Entering Text mode runs the mode hook @code{text-mode-hoo= k}
>=C2=A0 (@pxref{Major Modes}).
>=C2=A0
> +@vindex text-mode-ispell-word-completion
> +=C2=A0 Entering Text mode also activates auto-complete hints. If you = find
> +that this is disturbing for you, set this variable to @code{nil} in > +your Emacs initialization code.

This is using the wrong tone for describing the issue: it regards
completion hints in Text Mode as a nuisance in most cases.=C2=A0 If it were=
such a nuisance, we ought to make it off by default.
<= br>
I will always remember a friend of mine, who always asked me = to disable=C2=A0
auto-completion and hints in his word proces= sor, because=C2=A0they distracted
him too much from his work and = line of thought. And, once again, some
concentration deficits nee= d these features to be disabled, so I don't see
this as negat= ive, but reaching out to these communities.
=C2=A0
Instead, the text should descr= ibe the completion hints feature from
the POV of its being useful, and then say that the variable
text-mode-ispell-word-completion controls it.

OK, anyhow, I will try to find another wording.

=
Also, @vindex generates n= o text in the formatted manual, so you need
to mention the variable in the text as well, otherwise "this variable&= quot;
will allude to something the text doesn't mention.

Finally, please leave two spaces between sentences, per our
conventions.

> --- a/lisp/textmodes/text-mode.el
> +++ b/lisp/textmodes/text-mode.el
> @@ -145,7 +145,10 @@ text-mode
>=C2=A0 You can thus get the full benefit of adaptive filling
>=C2=A0 =C2=A0(see the variable `adaptive-fill-mode').
>=C2=A0 \\{text-mode-map}
> -Turning on Text mode runs the normal hook `text-mode-hook'."=
> +Turning on Text mode runs the normal hook `text-mode-hook'.
> +By default, `text-mode-hook' will enable completion at point with=
> +candidates supplied by `ispell'. You can turn this off by
> +setting `text-mode-ispell-word-completion' to `nil'."
This part is okay (modulo the 2 spaces between sentences issue).

Thanks.

/PA
--
Fragen sind nicht da, um bean= twortet zu werden,
Fragen sind da um gestellt zu werden
G= eorg Kreisler

Headaches with a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run= a leader-deposed hook here, but we can't yet

=
--000000000000a0793b06155ac0aa--