From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: chad Newsgroups: gmane.emacs.bugs Subject: bug#60580: 29.0.60; crash in xdisp.c with modus theme and display-fill-column-indicator Date: Mon, 9 Jan 2023 16:41:11 -0500 Message-ID: References: <83h6x4wy8c.fsf@gnu.org> <83fscowxy3.fsf@gnu.org> <87wn60pb0e.fsf@protesilaos.com> <835ydkw2zy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000d5ee2005f1dba04f" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8871"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Protesilaos Stavrou , 60580@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 09 22:42:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pEzuP-00028C-Aw for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 Jan 2023 22:42:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pEzu9-0005dF-53; Mon, 09 Jan 2023 16:42:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEzu7-0005ck-4P for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2023 16:42:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pEzu6-0001nt-SV for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2023 16:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pEzu6-0002XQ-FC for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2023 16:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: chad Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Jan 2023 21:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60580 X-GNU-PR-Package: emacs Original-Received: via spool by 60580-submit@debbugs.gnu.org id=B60580.16733004909715 (code B ref 60580); Mon, 09 Jan 2023 21:42:02 +0000 Original-Received: (at 60580) by debbugs.gnu.org; 9 Jan 2023 21:41:30 +0000 Original-Received: from localhost ([127.0.0.1]:38337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEztZ-0002Wc-JH for submit@debbugs.gnu.org; Mon, 09 Jan 2023 16:41:30 -0500 Original-Received: from mail-yb1-f179.google.com ([209.85.219.179]:45608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEztX-0002WR-K1 for 60580@debbugs.gnu.org; Mon, 09 Jan 2023 16:41:28 -0500 Original-Received: by mail-yb1-f179.google.com with SMTP id l139so9858570ybl.12 for <60580@debbugs.gnu.org>; Mon, 09 Jan 2023 13:41:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=C2a5dsBBFsHYEax25c8MXVPnVk8lanCEIZcpbekl0Uc=; b=OmQQggbRZtrBT2kYLSLIPIrv/YUHyywT6Tc/RNpVVzLRoMq6pxzYmQAQHAZW2AE5EJ q2hGnKFdKz2urPA7WF3FzvPa2zZPljMJboMuCcVwgLODWaP2uO5RDxLtav0+4zm4mpEC 3bkzBu2GdG125XISBEMEMFv9OvZB/xayfZyGXueFa4SBCHiQ1JisKeMILLma8g5+eh9Z zwHbJnpDxtFDDTQtt1BS4y6Zv99noR5mcW58+1EhxofBFyLsJ19ICRLOgC0mpwUd9/Dq HsRdXCt1wAtXdRdq6974CgbudxU88oUyM7fXmRoU306Yrm0vBtOJdawGCVF/K/dzJ3Is aL0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=C2a5dsBBFsHYEax25c8MXVPnVk8lanCEIZcpbekl0Uc=; b=f9xOa9W/Vo+rKfoS3UDdZ7h88xqoclmH8VnTkcctUZMdM/DOiiAde/Z2rqAYrd1bMK lNKwsXUiQUvyWUzvIbHyKGLq7NiBfah89hFv9QxW4T0BYwFDUIZWOP5ar6Qu37PO7+AQ 5IRsVC8AqemzSLBLswPPBiOwCFrUtUtDWnAp1dHaR/MfV6HyfoTFB6mH2Kf3lU0hpyTo iQagwMTsTyAFK4wriMXqPeHSkuRzSZQhfjF6gDIdpWPT1yLKpOKSV7tlcnubCimjGO2o DhAezS6NHbx3wlzwNI3hqcJL/PR88VshWwsEhSVie3GtvZLpC4SorWGAutA/rkGyxZlf FolQ== X-Gm-Message-State: AFqh2koC18rHGmayOpCY3klh9wryQZBLpwMjEBKowR5TB1o1kI3+9AFH CkN6/Z9SJiLBn1c341ddfrQhy71+H01Gsyfp/sg= X-Google-Smtp-Source: AMrXdXuN/kyxVLaTPpNDg4V73yb8tOBkAempjxPEeXAURiImXvvTF+AorUOfVVUtoY3xXx0DaWAG8L3rL7FHBBcJ0Qk= X-Received: by 2002:a25:1008:0:b0:759:65ed:fe8a with SMTP id 8-20020a251008000000b0075965edfe8amr7199669ybq.310.1673300482057; Mon, 09 Jan 2023 13:41:22 -0800 (PST) In-Reply-To: <835ydkw2zy.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253048 Archived-At: --000000000000d5ee2005f1dba04f Content-Type: text/plain; charset="UTF-8" Apologies; I was away for a while. The problem is fixed in the current emacs-29 branch, indeed. The ascent/height numbers were an error introduced by me when I was transcribing things from the emacs I was debugging, the emacs I was using to create the bug report, and the email program that I needed to use for annoying reasons. Please accept my heartfelt apologies for the misleading mistake. Thanks, ~Chad On Fri, Jan 6, 2023 at 2:12 AM Eli Zaretskii wrote: > > From: Protesilaos Stavrou > > Cc: 60580@debbugs.gnu.org > > Date: Fri, 06 Jan 2023 06:01:05 +0200 > > > > > ;;;;; display-fill-column-indicator-mode > > > `(fill-column-indicator ((,class :height 1 :background > ,bg-region :foreground ,bg-region))) > > > > > > I have no idea what is ":height 1" about, but I think it's wrong and > > > should be replaced with some reasonable value. > > > > The ":height 1" has been there for many versions and never caused a > > problem of this sort. > > I'm guessing that this is because almost no one builds Emacs with the > assertions enabled (--enable-testing=yes at configure time). I do, > but the problem doesn't happen on my system, so I haven't seen it, > either. > > > The reason it is like this is to make the indicator a contiguous > > line that is not affected by variations in font heights and/or a high > > 'line-spacing' value. Otherwise the indicator can appear as a dashed > > line. > > Why do you assume that ":height 1" will avoid this problem? I think > you are just using some undocumented side effect of the > implementation, as there's no reason to believe using such small > height of the face can solve the problem with occasional 1-pixel gaps > in the fill-column indicator. > > But let's first see if my latest changes prevent the assertion > violations even without changing the themed faces. > --000000000000d5ee2005f1dba04f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Apologies; I was away for a while. The problem is fixed in= the current emacs-29 branch, indeed.

The ascent/height = numbers were an error introduced=C2=A0by me when I was transcribing things = from the emacs I was debugging, the emacs I was using to create the bug rep= ort, and the email program that I needed to use for annoying reasons. Pleas= e accept my heartfelt apologies for the misleading mistake.

<= /div>
Thanks,
~Chad

On Fri, Jan 6, 2023 at 2:12 AM Eli Z= aretskii <eliz@gnu.org> wrote:
> From: Protesi= laos Stavrou <= info@protesilaos.com>
> Cc: 60580@d= ebbugs.gnu.org
> Date: Fri, 06 Jan 2023 06:01:05 +0200
>
> >=C2=A0 =C2=A0;;;;; display-fill-column-indicator-mode
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0`(fill-column-indicator ((,class :heigh= t 1 :background ,bg-region :foreground ,bg-region)))
> >
> > I have no idea what is ":height 1" about, but I think i= t's wrong and
> > should be replaced with some reasonable value.
>
> The ":height 1" has been there for many versions and never c= aused a
> problem of this sort.

I'm guessing that this is because almost no one builds Emacs with the assertions enabled (--enable-testing=3Dyes at configure time).=C2=A0 I do,<= br> but the problem doesn't happen on my system, so I haven't seen it,<= br> either.

> The reason it is like this is to make the indicator a contiguous
> line that is not affected by variations in font heights and/or a high<= br> > 'line-spacing' value.=C2=A0 Otherwise the indicator can appear= as a dashed
> line.

Why do you assume that ":height 1" will avoid this problem?=C2=A0= I think
you are just using some undocumented side effect of the
implementation, as there's no reason to believe using such small
height of the face can solve the problem with occasional 1-pixel gaps
in the fill-column indicator.

But let's first see if my latest changes prevent the assertion
violations even without changing the themed faces.
--000000000000d5ee2005f1dba04f--