From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Stephen J. Barr" Subject: bug#22472: bug#22472: 25.0.50; org-mode: latex fragments can't be un-rendered after a revert Date: Fri, 5 Feb 2016 14:28:31 -0800 Message-ID: References: <874mdz9th5.fsf@secretsauce.net> <87oabyuwbf.fsf@free.fr> <87powd2usq.fsf@secretsauce.net> <87mvrh2qbf.fsf@secretsauce.net> <87zivgoou6.fsf@nicolasgoaziou.fr> <87io243m32.fsf@secretsauce.net> <87mvrgoo72.fsf@nicolasgoaziou.fr> <87h9ho2v69.fsf@secretsauce.net> <87wpqiq04k.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1136b7d8f3dabe052b0d5e7d Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRov7-00052d-Gc for emacs-orgmode@gnu.org; Fri, 05 Feb 2016 17:32:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRov4-0001qt-91 for emacs-orgmode@gnu.org; Fri, 05 Feb 2016 17:32:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:54554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRov4-0001qp-5T for emacs-orgmode@gnu.org; Fri, 05 Feb 2016 17:32:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aRov4-00089H-1J for emacs-orgmode@gnu.org; Fri, 05 Feb 2016 17:32:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87wpqiq04k.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: Bastien Guerry , 22472@debbugs.gnu.org, Dima Kogan --001a1136b7d8f3dabe052b0d5e7d Content-Type: text/plain; charset=UTF-8 I was in the progress of writing my own email about this same issue. I was not aware that C-c C-c is no longer used for disabling overlays. If this is the case, what is the correct workflow for toggling these previews on and off? Thanks, -Stephen Stephen J. Barr PhD Candidate, Operations Management Dept: Information Systems and Operations Management (ISOM) Michael G. Foster School of Business University of Washington Phone: 425 516 5012 Email: stevejb@uw.edu Twitter: @stevejb Website: http://stephen.planetbarr.com On Fri, Feb 5, 2016 at 2:10 PM, Nicolas Goaziou wrote: > Hello, > > Dima Kogan writes: > > > Ah. Thanks for explaining. The patch helps somewhat, but one can still > > get into an inconsistent state: > > > > 1. Write \(1 + 2\) > > 2. Toggle overlay with C-c C-x C-l > > 3. M-x revert-buffer > > > > After the revert, the overlay remains, which is arguably OK, since the > > text has not changed. However after the revert org doesn't realize that > > the overlay is still up: org-latex-fragment-image-overlays is nil. > > Indeed. > > `org-latex-fragment-image-overlays' is a local variable and > `revert-buffer' calls `normal-mode', which, in turn, calls > `fundamental-mode'. The latter calls `kill-all-local-variables'. > Information is lost. > > I don't think that `org-latex-fragment-image-overlays' is useful, > anyway. So I removed it, along with that bug, hopefully. > > > I think the overlays should all disappear on a revert. > > I'm not convinced that an unmodified overlay should disappear. > > Thank you for the report. > > > Regards, > > -- > Nicolas Goaziou > > > > --001a1136b7d8f3dabe052b0d5e7d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I was in the progress of writing my own email about this s= ame issue. I was not aware that C-c C-c is no longer used for disabling ove= rlays. If this is the case, what is the correct workflow for toggling these= previews on and off?

Thanks,

-= Stephen



Stephen J. Barr
PhD Candidate, = Operations Management
De= pt: Information Systems and Operations Management (ISOM)
Michael G. Foster School of B= usiness
University of Washington
Phone: =C2=A0425 516 5012=
Twitter: @= stevejb



On Fri, Feb 5, 2016 at 2:10 PM, Nicolas Goaz= iou <mail@nicolasgoaziou.fr> wrote:
Hello,

Dima Kogan <dima@secretsauce.net= > writes:

> Ah. Thanks for explaining. The patch helps som= ewhat, but one can still
> get into an inconsistent state:
>
>=C2=A0 =C2=A01. Write \(1 + 2\)
>=C2=A0 =C2=A02. Toggle overlay with C-c C-x C-l
>=C2=A0 =C2=A03. M-x revert-buffer
>
> After the revert, the overlay remains, which is arguably OK, since the=
> text has not changed. However after the revert org doesn't realize= that
> the overlay is still up: org-latex-fragment-image-overlays is nil.

Indeed.

`org-latex-fragment-image-overlays' is a local variable and
`revert-buffer' calls `normal-mode', which, in turn, calls
`fundamental-mode'. The latter calls `kill-all-local-variables'. Information is lost.

I don't think that `org-latex-fragment-image-overlays' is useful, anyway. So I removed it, along with that bug, hopefully.

> I think the overlays should all disappear on a revert.

I'm not convinced that an unmodified overlay should disappear.
Thank you for the report.


Regards,

--
Nicolas Goaziou




--001a1136b7d8f3dabe052b0d5e7d--