From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Liang Wang Newsgroups: gmane.emacs.devel Subject: fix bad link for explicit tags in *Tags List* buffer Date: Wed, 28 Sep 2011 20:23:53 +0800 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=0016e6dab0fd259c3b04adff773f X-Trace: dough.gmane.org 1317212650 1703 80.91.229.12 (28 Sep 2011 12:24:10 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 28 Sep 2011 12:24:10 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 28 14:24:05 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R8tBF-0002xP-A3 for ged-emacs-devel@m.gmane.org; Wed, 28 Sep 2011 14:24:05 +0200 Original-Received: from localhost ([::1]:59450 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R8tBE-0005Bv-AL for ged-emacs-devel@m.gmane.org; Wed, 28 Sep 2011 08:24:04 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:52857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R8tB6-0005Ae-V0 for emacs-devel@gnu.org; Wed, 28 Sep 2011 08:24:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R8tB5-0004BD-61 for emacs-devel@gnu.org; Wed, 28 Sep 2011 08:23:56 -0400 Original-Received: from mail-ww0-f41.google.com ([74.125.82.41]:35119) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R8tB4-0004B8-T1 for emacs-devel@gnu.org; Wed, 28 Sep 2011 08:23:55 -0400 Original-Received: by wwf10 with SMTP id 10so1533612wwf.0 for ; Wed, 28 Sep 2011 05:23:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; bh=SH0rAM/hvxURrCbtC5C0HVLKNMtzrww/XKQET0hjjIQ=; b=t0L0Uh9XZ/STgS6aRoowBVS/dug8TB4ypXiQaVorc9M0CGpCLQnzE7nd8n8HvFU1xJ DFbdx/t+ujX/Vj4qQG9CA58R9Uo2IwlqQ4g7KMWfPmYPrtEm5chv5sPIhmBR2owxOg4K lYq2w7qyzf8+2mXTXqPzpjIyoXUtz7RIOpHV0= Original-Received: by 10.216.89.139 with SMTP id c11mr10593123wef.37.1317212634061; Wed, 28 Sep 2011 05:23:54 -0700 (PDT) Original-Received: by 10.216.5.65 with HTTP; Wed, 28 Sep 2011 05:23:53 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 74.125.82.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:144440 Archived-At: --0016e6dab0fd259c3b04adff773f Content-Type: text/plain; charset=UTF-8 Hi, I use Emacs source tree as example. Here is the way I create TAGS file. $ etags src/*.[hc] And then run M-x list-tags RET src/buffer.c RET to show buffer *Tags List*. The first tag in it is current_buffer. But when I press RET on it, an error message shows up. It's like etags-goto-tag-location: Rerun etags: `^current_buffer' not found in /home/liang/src/emacs/trunk/src/buffer.c That's because etags-goto-tag-location wants implicit tag which starts from the beginning of the line, but current_buffer is an explicit tag. To fix it, implicit tag must be used as link, but we can choose either explicit tag or implicit tag to show in *Tags List* buffer. The following patch shows implicit tag. OK for trunk? Thanks, Liang. diff --git a/lisp/ChangeLog b/lisp/ChangeLog index a8be1ba..032dbfd 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,7 @@ +2011-09-28 Liang Wang + + * progmodes/etags.el (etags-list-tags): Always use explicit tags. + 2011-09-21 Michael Albinus * net/tramp.el (tramp-handle-shell-command): Set process sentinel diff --git a/lisp/progmodes/etags.el b/lisp/progmodes/etags.el index d321e9c..f38af05 100644 --- a/lisp/progmodes/etags.el +++ b/lisp/progmodes/etags.el @@ -1409,7 +1409,7 @@ hits the start of file." tag tag-info pt) (forward-line 1) (while (not (or (eobp) (looking-at "\f"))) - (setq tag-info (save-excursion (funcall snarf-tag-function t)) + (setq tag-info (save-excursion (funcall snarf-tag-function nil)) tag (car tag-info) pt (with-current-buffer standard-output (point))) (princ tag) --0016e6dab0fd259c3b04adff773f Content-Type: application/octet-stream; name="etags-list-tags.patch" Content-Disposition: attachment; filename="etags-list-tags.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gt4adhpf0 ZGlmZiAtLWdpdCBhL2xpc3AvQ2hhbmdlTG9nIGIvbGlzcC9DaGFuZ2VMb2cKaW5kZXggYThiZTFi YS4uMDMyZGJmZCAxMDA2NDQKLS0tIGEvbGlzcC9DaGFuZ2VMb2cKKysrIGIvbGlzcC9DaGFuZ2VM b2cKQEAgLTEsMyArMSw3IEBACisyMDExLTA5LTI4ICBMaWFuZyBXYW5nICA8bmV0Y2FzcGVyQGdt YWlsLmNvbT4KKworCSogcHJvZ21vZGVzL2V0YWdzLmVsIChldGFncy1saXN0LXRhZ3MpOiBBbHdh eXMgdXNlIGV4cGxpY2l0IHRhZ3MuCisKIDIwMTEtMDktMjEgIE1pY2hhZWwgQWxiaW51cyAgPG1p Y2hhZWwuYWxiaW51c0BnbXguZGU+CiAKIAkqIG5ldC90cmFtcC5lbCAodHJhbXAtaGFuZGxlLXNo ZWxsLWNvbW1hbmQpOiBTZXQgcHJvY2VzcyBzZW50aW5lbApkaWZmIC0tZ2l0IGEvbGlzcC9wcm9n bW9kZXMvZXRhZ3MuZWwgYi9saXNwL3Byb2dtb2Rlcy9ldGFncy5lbAppbmRleCBkMzIxZTljLi5m MzhhZjA1IDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9ldGFncy5lbAorKysgYi9saXNwL3By b2dtb2Rlcy9ldGFncy5lbApAQCAtMTQwOSw3ICsxNDA5LDcgQEAgaGl0cyB0aGUgc3RhcnQgb2Yg ZmlsZS4iCiAJICB0YWcgdGFnLWluZm8gcHQpCiAgICAgKGZvcndhcmQtbGluZSAxKQogICAgICh3 aGlsZSAobm90IChvciAoZW9icCkgKGxvb2tpbmctYXQgIlxmIikpKQotICAgICAgKHNldHEgdGFn LWluZm8gKHNhdmUtZXhjdXJzaW9uIChmdW5jYWxsIHNuYXJmLXRhZy1mdW5jdGlvbiB0KSkKKyAg ICAgIChzZXRxIHRhZy1pbmZvIChzYXZlLWV4Y3Vyc2lvbiAoZnVuY2FsbCBzbmFyZi10YWctZnVu Y3Rpb24gbmlsKSkKIAkgICAgdGFnIChjYXIgdGFnLWluZm8pCiAJICAgIHB0ICh3aXRoLWN1cnJl bnQtYnVmZmVyIHN0YW5kYXJkLW91dHB1dCAocG9pbnQpKSkKICAgICAgIChwcmluYyB0YWcpCg== --0016e6dab0fd259c3b04adff773f--