Re: make eshell-path-env buffer-local

["Jürgen Hötzel" <juergen@archlinux.org>]

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

Hi Michael,

On Tue, Jan 8, 2013 at 3:25 PM, Michael Albinus <michael.albinus@gmx.de> wrote:
> Jürgen Hötzel <juergen@archlinux.org> writes:
>
>> Hi,
>
> Hi Juergen,
>
>> this is required when running multiple Eshell buffers on different
>> Hosts: To prevent garbling the different PATHs.
.....
> Wouldn't it be more consistent to declare `eshell-path-env' buffer-local
> in esh-util.el?

Actually there is no need to track/update eshell-path-env on the
localhost (see patch enclosed).

Jürgen

[-- Attachment #2: 0001-make-eshell-path-env-buffer-local-on-remote-hosts.patch --]
[-- Type: application/octet-stream, Size: 1266 bytes --]

From 91ec798810403937ef3994134b84a72a7dd919bf Mon Sep 17 00:00:00 2001
From: Juergen Hoetzel <juergen@archlinux.org>
Date: Tue, 8 Jan 2013 15:45:46 +0100
Subject: [PATCH] make eshell-path-env buffer-local on remote hosts

Don't update eshell-path-env on local host.
---
 lisp/tramp.el | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/lisp/tramp.el b/lisp/tramp.el
index f8db03e..31c6ea7 100644
--- a/lisp/tramp.el
+++ b/lisp/tramp.el
@@ -3896,14 +3896,13 @@ Only works for Bourne-like shells."
 ;; when `default-directory' points to another host.
 (defun tramp-eshell-directory-change ()
   "Set `eshell-path-env' to $PATH of the host related to `default-directory'."
-  (setq eshell-path-env
-	(if (file-remote-p default-directory)
-	    (with-parsed-tramp-file-name default-directory nil
-	      (mapconcat
-	       'identity
-	       (tramp-get-connection-property v "remote-path" nil)
-	       ":"))
-	  (getenv "PATH"))))
+  (when (file-remote-p default-directory)
+    (set (make-local-variable 'eshell-path-env)
+	 (with-parsed-tramp-file-name default-directory nil
+	   (mapconcat
+	    'identity
+	    (tramp-get-connection-property v "remote-path" nil)
+	    ":")))))
 
 (eval-after-load "esh-util"
   '(progn
-- 
1.8.1