From: Emilio Lopes <eclig@gmx.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 18461@debbugs.gnu.org
Subject: bug#18461: `vc-svn-registered' signals an error if a directory has be (re)moved.
Date: Mon, 15 Sep 2014 15:27:36 +0200 [thread overview]
Message-ID: <CANiPZaBkDSf6UuH4+pmjdYDZPwQUsGNLGxLjpPRzPzbnd=r-=A@mail.gmail.com> (raw)
In-Reply-To: <CANiPZaB8mi=mXrsy7aX1jBjJqnErZMTL8fzTCcP9LwVb702FsA@mail.gmail.com>
Here is an updated patch:
--- lisp/ChangeLog 2014-09-15 00:20:21 +0000
+++ lisp/ChangeLog 2014-09-15 13:22:54 +0000
@@ -1,3 +1,10 @@
+2014-09-15 Emilio C. Lopes <eclig@gmx.net>
+
+ * vc/vc-svn.el (vc-svn-registered): `cd' to the project root, not
+ to the file's directory, in case the directory has been (re)moved,
+ and do this inside a `with-demoted-errors' form.
+ (vc-svn-state): Ditto, modulo `with-demoted-errors'.
+
2014-09-15 Glenn Morris <rgm@gnu.org>
* image.el (image-multi-frame-p): Fix thinko - do not force
--- lisp/vc/vc-svn.el 2014-01-01 07:43:34 +0000
+++ lisp/vc/vc-svn.el 2014-09-15 13:22:54 +0000
@@ -135,30 +135,30 @@
(defun vc-svn-registered (file)
"Check if FILE is SVN registered."
- (when (vc-svn-root file)
- (with-temp-buffer
- (cd (file-name-directory file))
- (let* (process-file-side-effects
- (status
- (condition-case nil
- ;; Ignore all errors.
- (vc-svn-command t t file "status" "-v")
- ;; Some problem happened. E.g. We can't find an `svn'
- ;; executable. We used to only catch `file-error' but when
- ;; the process is run on a remote host via Tramp, the error
- ;; is only reported via the exit status which is turned into
- ;; an `error' by vc-do-command.
- (error nil))))
- (when (eq 0 status)
- (let ((parsed (vc-svn-parse-status file)))
- (and parsed (not (memq parsed '(ignored unregistered))))))))))
+ (let ((dir (vc-svn-root file)))
+ (when dir
+ (with-temp-buffer
+ (let* ((process-file-side-effects nil)
+ (status
+ (with-demoted-errors "Error: %S"
+ ;; In case some problem might happen. E.g. We can't
+ ;; find an `svn' executable. We used to only catch
+ ;; `file-error' but when the process is run on a
+ ;; remote host via Tramp, the error is only reported
+ ;; via the exit status which is turned into an
+ ;; `error' by vc-do-command.
+ (cd dir)
+ (vc-svn-command t t file "status" "-v"))))
+ (when (eq 0 status)
+ (let ((parsed (vc-svn-parse-status file)))
+ (and parsed (not (memq parsed '(ignored unregistered)))))))))))
(defun vc-svn-state (file &optional localp)
"SVN-specific version of `vc-state'."
(let (process-file-side-effects)
(setq localp (or localp (vc-stay-local-p file 'SVN)))
(with-temp-buffer
- (cd (file-name-directory file))
+ (cd (vc-svn-root file))
(vc-svn-command t 0 file "status" (if localp "-v" "-u"))
(vc-svn-parse-status file))))
next prev parent reply other threads:[~2014-09-15 13:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 16:09 bug#18461: `vc-svn-registered' signals an error if a directory has be (re)moved Emilio Lopes
2014-09-12 17:28 ` Stefan Monnier
2014-09-12 20:36 ` Emilio Lopes
2014-09-15 13:27 ` Emilio Lopes [this message]
2016-02-23 12:08 ` Lars Ingebrigtsen
2016-02-24 0:22 ` Dmitry Gutov
2016-02-24 1:43 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiPZaBkDSf6UuH4+pmjdYDZPwQUsGNLGxLjpPRzPzbnd=r-=A@mail.gmail.com' \
--to=eclig@gmx.net \
--cc=18461@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.