From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Improve docstring for delete-active-region (was Re: [WIP PATCH] Adding more keybindings to rectangle-mark-mode-map) Date: Thu, 17 Jun 2021 20:09:49 -0700 Message-ID: References: <83czu98vws.fsf@gnu.org> <83lf8x6rtv.fsf@gnu.org> <87r1ioi74z.fsf@linux-m68k.org> <875yzt90k5.fsf@linux-m68k.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000b7b28305c501a862" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22719"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Stefan Monnier To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 18 05:11:06 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lu4uQ-0005i8-MF for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Jun 2021 05:11:06 +0200 Original-Received: from localhost ([::1]:46404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lu4uP-0005c5-3z for ged-emacs-devel@m.gmane-mx.org; Thu, 17 Jun 2021 23:11:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lu4tQ-0004sv-0G for emacs-devel@gnu.org; Thu, 17 Jun 2021 23:10:04 -0400 Original-Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]:38483) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lu4tO-0003YJ-73; Thu, 17 Jun 2021 23:10:03 -0400 Original-Received: by mail-pg1-x533.google.com with SMTP id t17so6613920pga.5; Thu, 17 Jun 2021 20:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zljDjOTUZ4sZlvGvvuE8jUHZsOpvExQqjQ9gXTxitfQ=; b=puikF5qWtzzB6a/h7QRc3EjATWzxWdg81JTQOlPeat3KzTKeOhvsR+TRgc+R+X5BL0 mVE35lOwbclqsaJxR9w1hZry1hiIihADv3gCp+IEEGBNiBRo5AVWR8yfHBa+04hHE3kG tu2SwF/EuM5YnS+0B7khyyu6KDjmK8EJmU69chx7AWv+J1AYY37Tg7bUN0oGbdZ7Tb6X SE6V4Erkn/6qS+OIgqubAjSNIvwIYRMVTAjtz82sjKf4hQihvrDWQYycVrzEED2+AOHo VoZEDiSCTLHZnH7OJB+wkZSvzL0hxNthR+/pEbS+/3VJ7Ek4J2IsgCl1RmcsJR7GIViH ZTGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zljDjOTUZ4sZlvGvvuE8jUHZsOpvExQqjQ9gXTxitfQ=; b=bJCyN+XF0hZ5yh0PuK0LVMLbHHt6YRAw7DAxz3Y1XzMIL2+KqTVwjSbynfdLsrQyz8 s3T9jZ6SWsP6dp6qPCS9Zdjh0w0QM4c0o1wty/qK1PlccBAtQl99KJI2ZGtYFPS2LkNY tzs4DcPg/S/8s7DQFRK+hQko8kfwXJlPXXdnS05Kd2nUTP63zDN+fUjeNDadnXTp40oM teWVyLCok/URHYozIGYhY2FV7eVFbs9iKjxzGG1AoA6rsJmJdXL0LifbX1IW8IBHKh68 Ze75YnaW4ZecUTpME1Pj1TBKSNTmyBNi2+jhj9h0Z5K0/U3sU/PkR7v6fRRgp3W7fzLN odQg== X-Gm-Message-State: AOAM531dEgSr+F0HkbSZohvXI80wXCmKPHzsyt5CI4yPJnyc6Fxvi4Sh R7995t09BCbOn/YOt0kRIDtyanUq5vCBKruYohebIPn7SUk= X-Google-Smtp-Source: ABdhPJzxlkvtVd5SEV4TBlh09um610raL+Il6t+su5yqXt/ZF8/YGZm4gJnkle6hkVzz6m7WA6ZRbka1ReNpRLK4eHU= X-Received: by 2002:a65:60ca:: with SMTP id r10mr7943655pgv.185.1623985799788; Thu, 17 Jun 2021 20:09:59 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::533; envelope-from=jporterbugs@gmail.com; helo=mail-pg1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270898 Archived-At: --000000000000b7b28305c501a862 Content-Type: text/plain; charset="UTF-8" On Sat, May 8, 2021 at 11:57 AM Jim Porter wrote: > > On Fri, May 7, 2021 at 11:55 PM Andreas Schwab wrote: > > Please describe the effect of the prefix in the doc string. > > Good point. How does this look? > > I've also attached a tiny patch to improve the docstring for the next > function in the file, `delete-selection-repeat-replace-region'. It was > using a literal "C-u", so I modified it to use > "\\[universal-argument]". It looks like this got missed among all the messages of the thread. These are (very!) minor patches, so I won't feel too disappointed if they don't merge. I'm also happy to combine these into a single patch if that would be easier on the maintainers; I wasn't sure if keeping them separate would be better etiquette or not. - Jim --000000000000b7b28305c501a862 Content-Type: application/octet-stream; name="0002-Improve-docstring-for-delete-selection-repeat-replac.patch" Content-Disposition: attachment; filename="0002-Improve-docstring-for-delete-selection-repeat-replac.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kq1r1kkj1 RnJvbSAzNTkxNjZkNjMyYTExMzE0NWVlNzFjNGUxOGYwMzg5M2YxODFhYTc2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5jb20+CkRh dGU6IFNhdCwgOCBNYXkgMjAyMSAxMTo1MzoyNyAtMDcwMApTdWJqZWN0OiBbUEFUQ0ggMi8yXSBJ bXByb3ZlIGRvY3N0cmluZyBmb3IKIGRlbGV0ZS1zZWxlY3Rpb24tcmVwZWF0LXJlcGxhY2UtcmVn aW9uCgoqIGxpc3AvZGVsc2VsLmVsIChkZWxldGUtc2VsZWN0aW9uLXJlcGVhdC1yZXBsYWNlLXJl Z2lvbik6ClVzZSAiXFxbdW5pdmVyc2FsLWFyZ3VtZW50XSIgaW5zdGVhZCBvZiBsaXRlcmFsICJD LXUiIGluIGRvY3N0cmluZy4KLS0tCiBsaXNwL2RlbHNlbC5lbCB8IDIgKy0KIDEgZmlsZSBjaGFu Z2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZGVs c2VsLmVsIGIvbGlzcC9kZWxzZWwuZWwKaW5kZXggNzVjYzJiMWMyZS4uM2M5OWRkMjM0NCAxMDA2 NDQKLS0tIGEvbGlzcC9kZWxzZWwuZWwKKysrIGIvbGlzcC9kZWxzZWwuZWwKQEAgLTEwOCw3ICsx MDgsNyBAQCBkZWxldGUtc2VsZWN0aW9uLXJlcGVhdC1yZXBsYWNlLXJlZ2lvbgogICAiUmVwZWF0 IHJlcGxhY2luZyB0ZXh0IG9mIGhpZ2hsaWdodGVkIHJlZ2lvbiB3aXRoIHR5cGVkIHRleHQuCiBT ZWFyY2ggZm9yIHRoZSBuZXh0IHN0cmV0Y2ggb2YgdGV4dCBpZGVudGljYWwgdG8gdGhlIHJlZ2lv biBsYXN0IHJlcGxhY2VkCiBieSB0eXBpbmcgdGV4dCBvdmVyIGl0IGFuZCByZXBsYWNlcyBpdCB3 aXRoIHRoZSBzYW1lIHN0cmV0Y2ggb2YgdGV4dC4KLVdpdGggQVJHLCByZXBlYXQgdGhhdCBtYW55 IHRpbWVzLiAgYEMtdScgbWVhbnMgdW50aWwgZW5kIG9mIGJ1ZmZlci4iCitXaXRoIEFSRywgcmVw ZWF0IHRoYXQgbWFueSB0aW1lcy4gIGBcXFt1bml2ZXJzYWwtYXJndW1lbnRdJyBtZWFucyB1bnRp bCBlbmQgb2YgYnVmZmVyLiIKICAgKGludGVyYWN0aXZlICJQIikKICAgKGxldCAoKG9sZC10ZXh0 IChhbmQgZGVsZXRlLXNlbGVjdGlvbi1zYXZlLXRvLXJlZ2lzdGVyCiAgICAgICAgICAgICAgICAg ICAgICAgIChnZXQtcmVnaXN0ZXIgZGVsZXRlLXNlbGVjdGlvbi1zYXZlLXRvLXJlZ2lzdGVyKSkp Ci0tIAoyLjI1LjEKCg== --000000000000b7b28305c501a862 Content-Type: application/octet-stream; name="0001-Improve-docstring-for-delete-active-region.patch" Content-Disposition: attachment; filename="0001-Improve-docstring-for-delete-active-region.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kq1r1kkc0 RnJvbSBhYjFmYzdiM2U0NWEwNjQ1YjMxM2E3YWIyODViYjkyNmU3Mjc5MDEyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5jb20+CkRh dGU6IFNhdCwgOCBNYXkgMjAyMSAxMTo1MzoxNiAtMDcwMApTdWJqZWN0OiBbUEFUQ0ggMS8yXSBJ bXByb3ZlIGRvY3N0cmluZyBmb3IgZGVsZXRlLWFjdGl2ZS1yZWdpb24KCiogbGlzcC9kZWxzZWwu ZWwgKGRlbGV0ZS1hY3RpdmUtcmVnaW9uKTogRG9jdW1lbnQgaW50ZXJhY3RpdmUgYmVoYXZpb3Iu Ci0tLQogbGlzcC9kZWxzZWwuZWwgfCAzICsrLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9u cygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZGVsc2VsLmVsIGIvbGlzcC9k ZWxzZWwuZWwKaW5kZXggOTZhOWRjYzBjNy4uNzVjYzJiMWMyZSAxMDA2NDQKLS0tIGEvbGlzcC9k ZWxzZWwuZWwKKysrIGIvbGlzcC9kZWxzZWwuZWwKQEAgLTg3LDcgKzg3LDggQEAgZGVsc2VsLS1y ZXBsYWNlLXRleHQtb3ItcG9zaXRpb24KIDs7OyMjI2F1dG9sb2FkCiAoZGVmdW4gZGVsZXRlLWFj dGl2ZS1yZWdpb24gKCZvcHRpb25hbCBraWxscCkKICAgIkRlbGV0ZSB0aGUgYWN0aXZlIHJlZ2lv bi4KLUlmIEtJTExQIGluIG5vdC1uaWwsIHRoZSBhY3RpdmUgcmVnaW9uIGlzIGtpbGxlZCBpbnN0 ZWFkIG9mIGRlbGV0ZWQuIgorSWYgS0lMTFAgaXMgbm9uLW5pbCwgb3IgaWYgY2FsbGVkIGludGVy YWN0aXZlbHkgd2l0aCBhIHByZWZpeCBhcmd1bWVudCwKK3RoZSBhY3RpdmUgcmVnaW9uIGlzIGtp bGxlZCBpbnN0ZWFkIG9mIGRlbGV0ZWQuIgogICAoaW50ZXJhY3RpdmUgIlAiKQogICAoY29uZAog ICAgKGtpbGxwCi0tIAoyLjI1LjEKCg== --000000000000b7b28305c501a862--