From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#49104: [PATCH] 28.0.50; Handle remapped commands for M-TAB in `flyspell-prog-mode' Date: Fri, 18 Jun 2021 16:09:55 -0700 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000009edb0405c5126c31" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3414"; mail-complaints-to="usenet@ciao.gmane.io" To: 49104@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 19 01:49:39 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1luOF1-0000fz-4B for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Jun 2021 01:49:39 +0200 Original-Received: from localhost ([::1]:39652 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luOEz-0002wO-VS for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Jun 2021 19:49:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luNde-0003ui-Ss for bug-gnu-emacs@gnu.org; Fri, 18 Jun 2021 19:11:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46794) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1luNde-00013D-Iq for bug-gnu-emacs@gnu.org; Fri, 18 Jun 2021 19:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1luNde-0007sm-9v for bug-gnu-emacs@gnu.org; Fri, 18 Jun 2021 19:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Jun 2021 23:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49104 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.162405781130233 (code B ref -1); Fri, 18 Jun 2021 23:11:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Jun 2021 23:10:11 +0000 Original-Received: from localhost ([127.0.0.1]:58340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luNco-0007rZ-Uf for submit@debbugs.gnu.org; Fri, 18 Jun 2021 19:10:11 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:57136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luNcn-0007rP-M6 for submit@debbugs.gnu.org; Fri, 18 Jun 2021 19:10:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luNcn-00017k-CO for bug-gnu-emacs@gnu.org; Fri, 18 Jun 2021 19:10:09 -0400 Original-Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]:36783) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1luNcl-0000V8-LG for bug-gnu-emacs@gnu.org; Fri, 18 Jun 2021 19:10:09 -0400 Original-Received: by mail-pl1-x630.google.com with SMTP id x10so5479410plg.3 for ; Fri, 18 Jun 2021 16:10:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=Gq3+NThGUVMz0liIG4Q2qMdL3bjCi9wUZuNr6blefYc=; b=eQLVuO2qfgW9FVQGqivyH/URBgs9fjvMybcUOP8i75Vz1pdKYXJ83I6hxWn9hYGlAI smyC32U0iUYs3z1VHazd2aEV5pyRRhsjU0wcSOsVHuNbUSxmY49det6LzN5o8/KqT3la vH8v+FDw/5QvYkv8TtjeFBFUTZaV7Qs886dukFGnYVn/rs1Gbws1YIBUoFQso2iL/L/S v2843LacGaqxQV2ikZuB1AlSl8D3lwLqZ3zufSSMnVfS4dGzC9BpMG64ej/SreVnEXax 8G6gxh+5nLC6WUsONVrIUuseJz8H0pHr2FLZ+yz8IpaKM12wrVDOncaFuU3GfHtaqzWK xebA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Gq3+NThGUVMz0liIG4Q2qMdL3bjCi9wUZuNr6blefYc=; b=elDOuERr6LOH7/08ZLaw4jlyWMuBz+jIP/jRbUKXodVG0PkQSjFEYDbhpI+l5hHif2 FIBD6WWBwzig0Q/6+lyHELXnHyLwi947YbmRXy/bKO9WJOhBeSH16lNt2IEPr4c0fN2O L/DiPQOaoOqYatd7GEAyeBrIgrwnhJdXvwz8rSVLbTqu6DYTXxSFRAUVXn0Xo5TxE+jN J/Q3F80MW3bgUeTpHfGPbn9AGPOUVHdA0enO2fP1Hlq9z3XgAJe01U3RoghjLFPklZq2 wV/a5qyX2ogBO7bYLgRY0UlKiLeseQISYoih+RlY+huptlEanPiTT3zTtDhqmQULBmj9 SUXQ== X-Gm-Message-State: AOAM530reljHbov8sWbhis7BTSKpz2AwWmObtCyP23CxSRprzKTAiHZ3 Cv+9BbP1ug/mxfJLdM5q1dAUi8/3nPdA+aXE+ohH/Mrs6CM= X-Google-Smtp-Source: ABdhPJw+XihNQFvSdR6NABtFZLRP0Ee3dtS0p8bNQsRjoVzz7QhEke472JUSIaoLyKjE+clQMcxfuinPC0tp3l013O4= X-Received: by 2002:a17:90a:5998:: with SMTP id l24mr13164098pji.169.1624057805979; Fri, 18 Jun 2021 16:10:05 -0700 (PDT) Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x630.google.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) BAYES_20=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208707 Archived-At: --0000000000009edb0405c5126c31 Content-Type: text/plain; charset="UTF-8" `flyspell-prog-mode' uses the original M-TAB binding outside of comments, which is nice (see bug#18533). However, it doesn't account for remapped commands. For example, I remap `completion-at-point' to `company-complete' when `company-mode' is active. If I hit M-TAB while `company-mode' and `flyspell-prog-mode' are active, I get `completion-at-point', which isn't what I want. To reproduce this issue, you can do the following: emacs -Q (global-set-key [remap completion-at-point] (lambda () (interactive) (message "remapped"))) M-x flyspell-prog-mode M-TAB ;; Or C-M-i I've attached a patch that fixes the issue (hopefully it works in all cases; it works for me). --0000000000009edb0405c5126c31 Content-Type: application/octet-stream; name="0001-Handle-remapped-commands-for-original-M-TAB-binding-.patch" Content-Disposition: attachment; filename="0001-Handle-remapped-commands-for-original-M-TAB-binding-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kq2xx4da0 RnJvbSA3MzQ4OTBhZGZmODRjZjhmYmVjOWNmZjBhNWJiNmFkNjIwODc3MjE2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5jb20+CkRh dGU6IEZyaSwgMTggSnVuIDIwMjEgMTY6MDI6MDcgLTA3MDAKU3ViamVjdDogW1BBVENIXSBIYW5k bGUgcmVtYXBwZWQgY29tbWFuZHMgZm9yIG9yaWdpbmFsIE0tVEFCIGJpbmRpbmcgaW4KICdmbHlz cGVsbC1wcm9nLW1vZGUnCgoqIGxpc3AvdGV4dG1vZGVzL2ZseXNwZWxsLmVsIChmbHlzcGVsbC1w cm9nLW1vZGUpOiBHZXQgdGhlIHJlbWFwcGVkCmNvbW1hbmQgZm9yIHRoZSBvcmlnaW5hbCBNLVRB QiBiaW5kaW5nIGlmIG5lY2Vzc2FyeS4KLS0tCiBsaXNwL3RleHRtb2Rlcy9mbHlzcGVsbC5lbCB8 IDggKysrKystLS0KIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC90ZXh0bW9kZXMvZmx5c3BlbGwuZWwgYi9saXNwL3RleHRt b2Rlcy9mbHlzcGVsbC5lbAppbmRleCBiYTQ4ZTVkZTIxLi5lYjRjNWNkZTI4IDEwMDY0NAotLS0g YS9saXNwL3RleHRtb2Rlcy9mbHlzcGVsbC5lbAorKysgYi9saXNwL3RleHRtb2Rlcy9mbHlzcGVs bC5lbApAQCAtNDEwLDkgKzQxMCwxMSBAQCBmbHlzcGVsbC1wcm9nLW1vZGUKICAgKGludGVyYWN0 aXZlKQogICAoc2V0cSBmbHlzcGVsbC1nZW5lcmljLWNoZWNrLXdvcmQtcHJlZGljYXRlCiAgICAg ICAgICMnZmx5c3BlbGwtZ2VuZXJpYy1wcm9nbW9kZS12ZXJpZnkpCi0gIChzZXRxLWxvY2FsIGZs eXNwZWxsLS1wcmV2LW1ldGEtdGFiLWJpbmRpbmcKLSAgICAgICAgICAgICAgKG9yIChsb2NhbC1r ZXktYmluZGluZyAiXE0tXHQiIHQpCi0gICAgICAgICAgICAgICAgICAoZ2xvYmFsLWtleS1iaW5k aW5nICJcTS1cdCIgdCkpKQorICAobGV0ICgocHJldi1tZXRhLXRhYi1iaW5kaW5nIChvciAobG9j YWwta2V5LWJpbmRpbmcgIlxNLVx0IiB0KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAoZ2xvYmFsLWtleS1iaW5kaW5nICJcTS1cdCIgdCkpKSkKKyAgICAoc2V0cS1sb2NhbCBm bHlzcGVsbC0tcHJldi1tZXRhLXRhYi1iaW5kaW5nCisgICAgICAgICAgICAgICAgKG9yIChjb21t YW5kLXJlbWFwcGluZyBwcmV2LW1ldGEtdGFiLWJpbmRpbmcpCisgICAgICAgICAgICAgICAgICAg IHByZXYtbWV0YS10YWItYmluZGluZykpKQogICAoZmx5c3BlbGwtbW9kZSAxKQogICAocnVuLWhv b2tzICdmbHlzcGVsbC1wcm9nLW1vZGUtaG9vaykpCiAKLS0gCjIuMjUuMQoK --0000000000009edb0405c5126c31--