From: Jim Porter <jporterbugs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 50179@debbugs.gnu.org
Subject: bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode
Date: Tue, 24 Aug 2021 10:38:06 -0700 [thread overview]
Message-ID: <CANh=_JEJx-3S7S95OBKoeRff2kaaVJKBJNGy+vaBNcDb47Q0NA@mail.gmail.com> (raw)
In-Reply-To: <838s0rvyfu.fsf@gnu.org>
On Tue, Aug 24, 2021 at 5:07 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > +(defcustom ansi-bright-color-names-vector
> > + ["gray30" "red2" "green2" "yellow2" "blue1" "magenta2" "cyan2" "white"]
> > + "Colors used for SGR control sequences determining a \"bright\" color.
> > +This vector holds the colors used for SGR control sequences parameters
> > +90 to 97 (bright foreground colors) and 100 to 107 (brightbackground
> > +colors).
>
> I wouldn't offer a customizable list for this: users have no
> particular reason to redefine standard colors.
I made this a defcustom because `ansi-color-faces-vector' and
`ansi-color-names-vector' are defcustoms too. More practically
speaking, I'd want to customize this new variable to make these colors
match the Emacs theme I use. I chose colors in this patch to
complement `ansi-color-names-vector', but they'd clash with my theme.
> > +(defcustom term-color-bold-is-bright nil
> > + "If set to non-nil, combining ANSI bold and a color produces the bright
> > +version of that color."
> > + :group 'term
> > + :type 'boolean
> > + :version "28.1")
>
> Do we really need 2 separate knobs for these two features? How
> probable is it that the same user will want to have bright colors in
> one package, but not in the other?
I doubt anyone would want to control these independently. It'd be nice
to have a single defcustom for this, but I wasn't sure where it should
go in that case. Would it be ok to use `ansi-color-bold-is-bright'
(from patch 1 in `ansi-color.el') in `term.el'? I see that `term.el`
requires `comint.el', which requires `ansi-color.el', so `term.el'
should see it without changing what gets loaded.
(It might even be nice to use the same definitions for the colors in
both `ansi-color.el' and `term.el', but that would take a bit of work
to migrate users'/themes' customizations. Maybe that's something to do
for Emacs 29 so I have time to figure out a good migration path.)
next prev parent reply other threads:[~2021-08-24 17:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 4:02 bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode Jim Porter
2021-08-24 12:07 ` Eli Zaretskii
2021-08-24 17:38 ` Jim Porter [this message]
2021-08-24 17:59 ` Eli Zaretskii
2021-08-24 18:59 ` Jim Porter
2021-08-24 22:53 ` Jim Porter
2021-08-25 12:04 ` Lars Ingebrigtsen
2021-08-25 16:41 ` Jim Porter
2021-08-25 16:46 ` Lars Ingebrigtsen
2021-08-25 16:54 ` Eli Zaretskii
2021-08-26 13:23 ` Lars Ingebrigtsen
2021-09-18 18:58 ` bug#50179: [UPDATED PATCH] " Jim Porter
2021-09-19 14:45 ` Lars Ingebrigtsen
2021-09-22 19:39 ` bug#50179: [WIP PATCH v3] " Jim Porter
2021-09-22 19:49 ` Lars Ingebrigtsen
2021-09-23 1:47 ` bug#50179: [PATCH v4] " Jim Porter
2021-09-23 20:58 ` Lars Ingebrigtsen
2021-09-23 21:21 ` Jim Porter
2021-08-25 7:06 ` bug#50179: [PATCH] " Kévin Le Gouguec
2021-08-25 11:57 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANh=_JEJx-3S7S95OBKoeRff2kaaVJKBJNGy+vaBNcDb47Q0NA@mail.gmail.com' \
--to=jporterbugs@gmail.com \
--cc=50179@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.