From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Josh Newsgroups: gmane.emacs.bugs Subject: bug#13078: [PATCH] configure.ac: Cygwin build breaks when path to pkg-tool contains spaces Date: Mon, 3 Dec 2012 20:35:02 -0800 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: ger.gmane.org 1354595811 8148 80.91.229.3 (4 Dec 2012 04:36:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 4 Dec 2012 04:36:51 +0000 (UTC) To: 13078@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 04 05:37:03 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TfkFb-0006p0-7I for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Dec 2012 05:36:55 +0100 Original-Received: from localhost ([::1]:36111 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfkFP-0003nX-D7 for geb-bug-gnu-emacs@m.gmane.org; Mon, 03 Dec 2012 23:36:43 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfkFL-0003nP-3h for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2012 23:36:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TfkFI-0001LV-C3 for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2012 23:36:39 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42070) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfkFI-0001LR-8W for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2012 23:36:36 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TfkHd-0004rM-Op for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2012 23:39:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Josh Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Dec 2012 04:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13078 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.135459588118599 (code B ref -1); Tue, 04 Dec 2012 04:39:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Dec 2012 04:38:01 +0000 Original-Received: from localhost ([127.0.0.1]:52321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TfkGf-0004pp-9s for submit@debbugs.gnu.org; Mon, 03 Dec 2012 23:38:01 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:59530) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TfkGd-0004pi-Ad for submit@debbugs.gnu.org; Mon, 03 Dec 2012 23:38:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TfkEG-0001ET-7q for submit@debbugs.gnu.org; Mon, 03 Dec 2012 23:35:33 -0500 Original-Received: from lists.gnu.org ([208.118.235.17]:45672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfkEG-0001EP-4t for submit@debbugs.gnu.org; Mon, 03 Dec 2012 23:35:32 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfkEA-0003dE-9K for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2012 23:35:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TfkE8-0001Dk-7O for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2012 23:35:26 -0500 Original-Received: from mail-ob0-f169.google.com ([209.85.214.169]:54446) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfkE8-0001De-2Y for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2012 23:35:24 -0500 Original-Received: by mail-ob0-f169.google.com with SMTP id lz20so3831751obb.0 for ; Mon, 03 Dec 2012 20:35:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:from:date:x-google-sender-auth:message-id :subject:to:content-type:x-gm-message-state; bh=YOwnjksXwgKKU6qmXTWFQt226W4eowKrNSJAxu3P+tE=; b=gNxAj8Ug9RJHqq27s/HcV4KZ0MzzZcp/UU+06bo6xP+hbFw5E/P9++V2YIguXwKCfk wpSzRFF2b+VZSC1J9/IVVas8wvisT5jRW3mfV7g1/JWoj+3J8HbE56k+UHbBtbaC6A44 3sJFR63p+2rtRE9RXgOTzLmY5I96jvx/iJYWsbJ1aI0s2HXTGwbq0EckThQ1BJMQ3vZ4 K2azERkO13UE4IQ13u2vBPZWA413r23EO/xlRHTS8icKJ4dAJLalRi4pfwq86c0M5hv5 2bZbndz6hD7EGUfiKCLXCNjj8Wb3nidBIPPBahlTsAVQ4YhGNqUvUTVU3UqICrMOQG1m EIDA== Original-Received: by 10.60.31.49 with SMTP id x17mr10578012oeh.33.1354595722733; Mon, 03 Dec 2012 20:35:22 -0800 (PST) Original-Received: by 10.60.51.229 with HTTP; Mon, 3 Dec 2012 20:35:02 -0800 (PST) X-Google-Sender-Auth: b8O0Q2pgsNz0XpYZMDhtbMqFd18 X-Gm-Message-State: ALoCoQkpuE1fiDLKBv2nzwn+pKRwZ8UyfKhUivBboaTB9VpdXVOptv+8ny8Ow9BhsVa5hBwP2dL+ X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:67886 Archived-At: Hi, I tried building trunk under Cygwin for the first time a few days ago (with the `--with-w32' switch, though I don't think that's relevant) but the build failed because ./configure was finding a version of pkg-config whose path contained whitespace. This exposed some quoting problems in configure.ac, fixed in the patch below. Here's a snippet of the session with some representative errors: checking for cma_open in -lpthreads... no ./configure: line 10967: /cygdrive/c/Program: No such file or directory *** Your version of pkg-config is too old. You need version 0.9.0 or newer. *** See http://www.freedesktop.org/software/pkgconfig checking for lgetfilecon in -lselinux... no ./configure: line 11304: /cygdrive/c/Program: No such file or directory *** Your version of pkg-config is too old. You need version 0.9.0 or newer. *** See http://www.freedesktop.org/software/pkgconfig checking for gnutls_certificate_set_verify_function... no [...] checking for gpm.h... no ./configure: line 13122: /cygdrive/c/Program: No such file or directory *** Your version of pkg-config is too old. You need version 0.9.0 or newer. *** See http://www.freedesktop.org/software/pkgconfig checking whether netdb declares h_errno... yes In addition to the quoting problem, it appears that failure to open a file is interpreted as having a version which is too old, which is perhaps not ideal. Here's the patch I applied locally that allowed me to build successfully: diff --git a/configure.ac b/configure.ac index 085ca83..85c21e1 100644 --- a/configure.ac +++ b/configure.ac @@ -1189,10 +1189,10 @@ AC_DEFUN([PKG_CHECK_MODULES], [ *** The pkg-config script could not be found. Make sure it is in your path, or give the full path to pkg-config with the PKG_CONFIG environment variable or --with-pkg-config-prog. Or see http://www.freedesktop.org/software/pkgconfig to get pkg-config.])], [$4]) else PKG_CONFIG_MIN_VERSION=0.9.0 - if $PKG_CONFIG --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then + if "$PKG_CONFIG" --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then AC_MSG_CHECKING(for $2) - if $PKG_CONFIG --exists "$2" 2>&AS_MESSAGE_LOG_FD && + if "$PKG_CONFIG" --exists "$2" 2>&AS_MESSAGE_LOG_FD && $1_CFLAGS=`$PKG_CONFIG --cflags "$2" 2>&AS_MESSAGE_LOG_FD` && $1_LIBS=`$PKG_CONFIG --libs "$2" 2>&AS_MESSAGE_LOG_FD`; then edit_cflags=" @@ -2027,7 +2027,7 @@ if test x"$pkg_check_gtk" = xyes; then AC_DEFINE(USE_GTK, 1, [Define to 1 if using GTK.]) GTK_OBJ="gtkutil.o $GTK_OBJ" USE_X_TOOLKIT=none - if $PKG_CONFIG --atleast-version=2.10 gtk+-2.0; then + if "$PKG_CONFIG" --atleast-version=2.10 gtk+-2.0; then : else AC_MSG_WARN([[Your version of Gtk+ will have problems with