From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.bugs Subject: bug#6300: browse-url-encode need to encode more Date: Wed, 21 Sep 2011 22:42:15 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1316637779 20310 80.91.229.12 (21 Sep 2011 20:42:59 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 21 Sep 2011 20:42:59 +0000 (UTC) Cc: 6300@debbugs.gnu.org To: Lars Magne Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 21 22:42:55 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R6Td8-00017X-S6 for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Sep 2011 22:42:55 +0200 Original-Received: from localhost ([::1]:57680 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6Td8-0003JC-Cz for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Sep 2011 16:42:54 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:53332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6Td6-0003Ia-1J for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2011 16:42:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R6Td2-0004wa-PG for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2011 16:42:52 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55272) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6Td2-0004wW-Kf for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2011 16:42:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R6TdG-0006vb-Gz for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2011 16:43:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Sep 2011 20:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6300 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6300-submit@debbugs.gnu.org id=B6300.131663777726608 (code B ref 6300); Wed, 21 Sep 2011 20:43:02 +0000 Original-Received: (at 6300) by debbugs.gnu.org; 21 Sep 2011 20:42:57 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6TdA-0006v6-Fn for submit@debbugs.gnu.org; Wed, 21 Sep 2011 16:42:57 -0400 Original-Received: from mail-fx0-f44.google.com ([209.85.161.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6Td7-0006us-I3 for 6300@debbugs.gnu.org; Wed, 21 Sep 2011 16:42:54 -0400 Original-Received: by fxd18 with SMTP id 18so1917711fxd.3 for <6300@debbugs.gnu.org>; Wed, 21 Sep 2011 13:42:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=siYkapCwSTMu0TJ2fBrcvBGvqlB/FgPqHp7A1FOTSHk=; b=IKxyETyilDRleK+v5liYTEVGyV723HblWD+tzO8vuwCVs0ijeqLweRcnGvsHZJd7uc 4YK1Pbfxy9F0lKksjPsgPtwtSSISmmt2Q34T6VpfOMjwYu4XwY/HZAJhXSYU00pg4+53 /XU6VIFpKFIeeUmh6piE7/+04kOySHPql0idc= Original-Received: by 10.223.28.72 with SMTP id l8mr1613278fac.137.1316637756274; Wed, 21 Sep 2011 13:42:36 -0700 (PDT) Original-Received: by 10.152.20.229 with HTTP; Wed, 21 Sep 2011 13:42:15 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 21 Sep 2011 16:43:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:51602 Archived-At: On Wed, Sep 21, 2011 at 22:23, Lars Magne Ingebrigtsen wro= te: > Lennart Borgman writes: > >> The character ?" needs to be escaped at least on w32 because otherwise >> ShellExecute will not work. Maybe this part of the patch should be >> platform specific, I do not know. >> >> Both Google Chrome and Firefox still thinks that it is good manner to >> also escape blanks as ?+. >> >> I suggest the following patch (this is agains a checkout from 2010-05-22= ): >> >> =3D=3D=3D modified file 'lisp/net/browse-url.el' >> --- trunk/lisp/net/browse-url.el =C2=A0 =C2=A0 =C2=A02010-04-29 14:04:33= +0000 >> +++ patched/lisp/net/browse-url.el =C2=A0 =C2=A02010-05-29 10:52:33 +000= 0 >> @@ -634,7 +634,8 @@ >> =C2=A0 =C2=A0;; FIXME: Is there an actual example of a web browser getti= ng >> =C2=A0 =C2=A0;; confused? =C2=A0(This used to encode commas, but at leas= t Firefox >> =C2=A0 =C2=A0;; handles commas correctly and doesn't accept encoded comm= as.) >> - =C2=A0(browse-url-url-encode-chars url "[)$]")) >> + =C2=A0(replace-regexp-in-string " " "+" >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0(browse-url-url-encode-chars url "[\"()$]"))) > > Is there any reason space shouldn't be quoted as %20 instead? =C2=A0I.e., > just add it to the regexp there at the end? Yes. Readability.