From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.bugs Subject: bug#10633: Please mark invalid "; !important;" in CSS Date: Tue, 31 Jan 2012 03:36:11 +0100 Message-ID: References: <874nvf2lua.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=e0cb4efe34dcabbd4c04b7c9d465 X-Trace: dough.gmane.org 1327977420 30096 80.91.229.3 (31 Jan 2012 02:37:00 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 31 Jan 2012 02:37:00 +0000 (UTC) Cc: Chong Yidong , 10633@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 31 03:36:59 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Rs3aa-0002GZ-UL for geb-bug-gnu-emacs@m.gmane.org; Tue, 31 Jan 2012 03:36:57 +0100 Original-Received: from localhost ([::1]:58444 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rs3aZ-0003Ge-Ah for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Jan 2012 21:36:55 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:46698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rs3aU-00034j-D8 for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2012 21:36:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rs3aT-00078O-AM for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2012 21:36:50 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42365) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rs3aS-00078J-TY for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2012 21:36:49 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Rs3af-00060j-IX for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2012 21:37:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 31 Jan 2012 02:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix Original-Received: via spool by 10633-submit@debbugs.gnu.org id=B10633.132797741223089 (code B ref 10633); Tue, 31 Jan 2012 02:37:01 +0000 Original-Received: (at 10633) by debbugs.gnu.org; 31 Jan 2012 02:36:52 +0000 Original-Received: from localhost ([127.0.0.1]:45988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rs3aW-00060M-50 for submit@debbugs.gnu.org; Mon, 30 Jan 2012 21:36:52 -0500 Original-Received: from mail-lpp01m010-f44.google.com ([209.85.215.44]:35000) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rs3aU-000605-7Y for 10633@debbugs.gnu.org; Mon, 30 Jan 2012 21:36:51 -0500 Original-Received: by lahl5 with SMTP id l5so2489452lah.3 for <10633@debbugs.gnu.org>; Mon, 30 Jan 2012 18:36:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=UN1eyXZNlJQ+T1uhG5lXEem1lSLbfM7THS2rg7VfPZ8=; b=k/YRcOUfRbNpRL0Uz/KM8ME03v1+T1YmCeFdOfUAV12+f3wZrvBBn5frhloD7Mq8v3 79UBsH33rx4lqg4+jN1VPx9vd8AKIs8wzArKLQbUJNTjS+mIuwHmKx6RN9LN3boSYRhW MVUM+86RBbg7pP5ExP3JqlM10GkdEw5YILFFw= Original-Received: by 10.112.36.103 with SMTP id p7mr5128825lbj.91.1327977391176; Mon, 30 Jan 2012 18:36:31 -0800 (PST) Original-Received: by 10.112.97.11 with HTTP; Mon, 30 Jan 2012 18:36:11 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:56280 Archived-At: --e0cb4efe34dcabbd4c04b7c9d465 Content-Type: text/plain; charset=UTF-8 On Tue, Jan 31, 2012 at 02:48, Stefan Monnier wrote: > >> >> However there are a lot of things that can go wrong when you work > with > >> >> things like css. > >> > I don't think it should be the job of CSS mode to highlight ad-hoc > >> > mistake conditions like that. > >> There's cwarn-mode for something similar, so the question really is > >> whether this error is common or specific to a particular user. > >> I have no idea which it is. > > The "!important" is colored as it is now even when I happen to put it > > after the ";". Not syntax coloring that would be enough to easily > > detect the problem. > > That would be perfect, yes. Patch welcome, > > I think this is enough: ;;("!\\s-*important" . font-lock-builtin-face) ("[^; \t\n]\\s-*\\(!\\s-*important\\)" (1 'font-lock-builtin-face)) --e0cb4efe34dcabbd4c04b7c9d465 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, Jan 31, 2012 at 02:48, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> >> However there are a lot of things that = can go wrong when you work with
>> >> things like css.
>> > I don't think it should be the job of CSS mode to highlig= ht ad-hoc
>> > mistake conditions like that.
>> There's cwarn-mode for something similar, so the question real= ly is
>> whether this error is common or specific to a particular user.
>> I have no idea which it is.
> The "!important" is colored as it is now even when I happen = to put it
> after the ";". Not syntax coloring that would be enough to e= asily
> detect the problem.

That would be perfect, yes. =C2=A0Patch welcome,

=
I think this is enough:

=C2=A0 =C2=A0 ;;("!\\s-*impor= tant" . font-lock-builtin-face)
=C2=A0 =C2=A0 ("[^; \t\= n]\\s-*\\(!\\s-*important\\)"
=C2=A0 =C2=A0 =C2=A0(1 'font-lock-builtin-face))
=C2=A0
=

--e0cb4efe34dcabbd4c04b7c9d465--