From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.bugs Subject: bug#10633: Please mark invalid "; !important;" in CSS Date: Sun, 29 Jan 2012 01:10:57 +0100 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1327795929 8016 80.91.229.3 (29 Jan 2012 00:12:09 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 29 Jan 2012 00:12:09 +0000 (UTC) Cc: 10633@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 29 01:12:08 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RrINM-0007QG-C0 for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Jan 2012 01:12:08 +0100 Original-Received: from localhost ([::1]:52215 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RrINL-0001qr-OS for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Jan 2012 19:12:07 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:43856) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RrINI-0001qb-Te for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2012 19:12:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RrINH-0005vl-HT for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2012 19:12:04 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38977) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RrINH-0005vh-DK for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2012 19:12:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1RrING-00049p-1S for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2012 19:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2012 00:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10633-submit@debbugs.gnu.org id=B10633.132779588715937 (code B ref 10633); Sun, 29 Jan 2012 00:12:02 +0000 Original-Received: (at 10633) by debbugs.gnu.org; 29 Jan 2012 00:11:27 +0000 Original-Received: from localhost ([127.0.0.1]:42600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrIMg-000490-VY for submit@debbugs.gnu.org; Sat, 28 Jan 2012 19:11:27 -0500 Original-Received: from mail-lpp01m010-f44.google.com ([209.85.215.44]:62551) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrIMd-00048m-NE for 10633@debbugs.gnu.org; Sat, 28 Jan 2012 19:11:25 -0500 Original-Received: by lahl5 with SMTP id l5so1550691lah.3 for <10633@debbugs.gnu.org>; Sat, 28 Jan 2012 16:11:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=g1U0iNIwo2HZLTBDeTEYB9myxXy7DLOwUQGYo9ekmkA=; b=Wn4/LtRfNPRtluUiQhD4mKb5WEMKBq31qIFWSE4/v3Nq11JqnAB7mvq0CbhMVMdL6A kgAT1mSz+1R7017IfRkb8gr7esj7na2k5UTEIBm2kOFtzFDqoSSrTqdsSKaV4Sh4xrKr 4quBJRF32H8KZ49648KQQqeNK66J5sc8nq7UM= Original-Received: by 10.152.131.40 with SMTP id oj8mr6433034lab.24.1327795877148; Sat, 28 Jan 2012 16:11:17 -0800 (PST) Original-Received: by 10.112.97.11 with HTTP; Sat, 28 Jan 2012 16:10:57 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:56157 Archived-At: On Sun, Jan 29, 2012 at 00:52, Lennart Borgman wrote: > On Sun, Jan 29, 2012 at 00:26, Lennart Borgman > wrote: >> On Sun, Jan 29, 2012 at 00:18, Juanma Barranquero wro= te: >>> On Sat, Jan 28, 2012 at 23:01, Lennart Borgman >>> wrote: >>> >>>> One of my most common mistakes when editing CSS files is that I leave >>>> a ";" before "!important", like this: >>>> >>>> =C2=A0 width: 500px; !important; >>>> >>>> This should have been >>>> >>>> =C2=A0 width: 500px !important; >>>> >>>> Could Emacs please help me with this?;-) >>> >>> Sure. Use hi-lock-mode, add a "; +!important" regexp as a file >>> pattern, set the mode in the css-mode-hook, and for added simplicity >>> do also >>> >>> (setq hi-lock-file-patterns-policy (lambda (patterns) >>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0(if (eq major-mode 'css-mode) >>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0t >>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0(y-or-n-p "Add patterns >>> from this buffer to hi-lock? ")))) >>> >>> Look, ma, no hands. >> >> Thanks, it is a great tip until it is fixed! > > Though it was a bit unpractical. It would be easier to just add it to > css-mode-hook and forget hi-lock-mode. Since isearch does it without > hi-lock-mode that is doable. Anyone remember how to do it offhand? (Or > do I have to search the isearch code... ?;-) Here is a way to do it: - In isearch-forward-regexp do M-s-h-r to hilight the pattern. - Then use hi-lock-write-interactive-patterns to write it down in the buffer for the moment (so you do not have to think about it...;-) - Now to css-mode-hook add something like this (hi-lock-face-buffer "; +!important;" 'hi-my-face) In my .emacs I added: (add-hook 'css-mode-hook 'my-hilock-css-important-errors) (defun my-hilock-css-important-errors() (hi-lock-face-buffer "; +!important;" 'hi-my-magenta))