From: Lennart Borgman <lennart.borgman@gmail.com>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 6414@debbugs.gnu.org
Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized?
Date: Mon, 4 Jul 2011 00:37:04 +0200 [thread overview]
Message-ID: <CANbX364FasiKQH-eb+5ppyqeHxuRFTUDmWqeEURP++yBBTLi6A@mail.gmail.com> (raw)
In-Reply-To: <CAAeL0STP6422v0ZD=N7dADxN=qVT8MmqCFy8QJR6sCF0sKu4AQ@mail.gmail.com>
On Mon, Jul 4, 2011 at 00:30, Juanma Barranquero <lekktu@gmail.com> wrote:
> On Mon, Jul 4, 2011 at 00:19, Lennart Borgman <lennart.borgman@gmail.com> wrote:
>
>> However I think it is also very difficult to catch such errors. They
>> are likely to be race conditions (since w32 messages from different
>> sources are involved).
>
> But you're talking of presumed errors, i.e., you read the code, see
> some error messages from system calls, but there's no error, is there?
It has been some time since I suggested this, but as far as I remember
I looked into this because I had quite a few crashes. They seemed to
be related to menus.
>> So I think it is better to check the logic. (As I have tried to above.)
>
> Which is fine, but it is not IMO a bug report. In this specific case,
> the title refers to an uninitialized struct component, but you
> yourself say latter that it is initialized.
Yes, correct. And I pointed to another place where I thought the
problem was instead.
>> And I also still think it is a good idea to add check for error
>> conditions after all system calls. (For the same reason as above.)
>
> As you know, this has been discussed and there's some difference of
> opinion, but again, even if you're right, that's not a bug report,
> other than perhaps a wishlist, but frankly, this seems more like
> something to discuss (again) on emacs-devel than to file as a bug.
Since you asked for a recipe I thought I had to mention this again. It
looked to me that you overlooked this problem again.
> So, to summarize: is this bug report about a bug? Is there something
> to do about it? Or can we close it?
Did you look at the logic as I suggested? If you are sure my
suggestion is wrong then feel free to close the bug.
next prev parent reply other threads:[~2011-07-03 22:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-13 18:01 bug#6414: f->output_data.w32->menubar_widget uninitialized? Lennart Borgman
2010-06-13 18:32 ` Lennart Borgman
2010-06-13 18:47 ` Lennart Borgman
2011-07-03 18:54 ` Juanma Barranquero
2011-07-03 22:19 ` Lennart Borgman
2011-07-03 22:30 ` Juanma Barranquero
2011-07-03 22:37 ` Lennart Borgman [this message]
2011-07-03 22:48 ` Juanma Barranquero
2011-07-03 23:11 ` Lennart Borgman
2011-07-03 23:21 ` Juanma Barranquero
2011-07-03 23:42 ` Lennart Borgman
2011-07-04 0:34 ` Juanma Barranquero
2011-07-04 1:08 ` Lennart Borgman
2011-07-04 1:21 ` Juanma Barranquero
2011-07-04 1:44 ` Lennart Borgman
2011-07-04 2:13 ` Juanma Barranquero
2011-07-04 2:18 ` Lennart Borgman
2011-07-04 2:35 ` Juanma Barranquero
2011-09-21 20:32 ` Lars Magne Ingebrigtsen
2011-09-21 20:40 ` Lennart Borgman
2011-09-21 20:44 ` Juanma Barranquero
2011-09-21 20:46 ` Lennart Borgman
2011-09-21 20:59 ` Lars Magne Ingebrigtsen
2011-09-21 21:07 ` Lennart Borgman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANbX364FasiKQH-eb+5ppyqeHxuRFTUDmWqeEURP++yBBTLi6A@mail.gmail.com \
--to=lennart.borgman@gmail.com \
--cc=6414@debbugs.gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.