From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ackerley Tng Newsgroups: gmane.emacs.bugs Subject: bug#59381: Should xref--marker-ring be per-window? Date: Thu, 24 Nov 2022 16:28:11 -0800 Message-ID: References: <86leo6ai85.fsf@mail.linkov.net> <83leo67mbt.fsf@gnu.org> <83v8na5a5e.fsf@gnu.org> <838rk44fgg.fsf@gnu.org> <90fccc99-14e1-80f7-5179-62c44c1833b8@yandex.ru> <0bd4b2db-15cd-62e7-54f7-3eb26627e808@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25084"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 59381@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 25 01:29:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyMao-0006L3-Ra for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Nov 2022 01:29:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyMaW-0003Kb-SZ; Thu, 24 Nov 2022 19:29:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyMaV-0003K7-9D for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 19:29:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyMaU-0007fg-VQ for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 19:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyMaT-0000Sg-Ow for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 19:29:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ackerley Tng Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Nov 2022 00:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59381 X-GNU-PR-Package: emacs Original-Received: via spool by 59381-submit@debbugs.gnu.org id=B59381.16693361131738 (code B ref 59381); Fri, 25 Nov 2022 00:29:01 +0000 Original-Received: (at 59381) by debbugs.gnu.org; 25 Nov 2022 00:28:33 +0000 Original-Received: from localhost ([127.0.0.1]:60583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyMa0-0000Ry-O1 for submit@debbugs.gnu.org; Thu, 24 Nov 2022 19:28:32 -0500 Original-Received: from mail-vs1-f49.google.com ([209.85.217.49]:45931) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyMZy-0000Rg-1y for 59381@debbugs.gnu.org; Thu, 24 Nov 2022 19:28:30 -0500 Original-Received: by mail-vs1-f49.google.com with SMTP id 128so2797333vsz.12 for <59381@debbugs.gnu.org>; Thu, 24 Nov 2022 16:28:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7v93/ghV4WVnzAYYOsCX1Kw33dDbIUr4NDtKrgi7+HI=; b=qeheJl9i574Gfkpitip4JFSKvLmJCMm9NB6ZGefcl8Cz+6DV7qNMxpgZ0MRh7K67PG KaZCQveA8vsGGkPCEtxAOenK6Opf3GXYVX1BFZBlcb7XQsCuur+U7lWnGDmWgwSL40kr 1T7KsGhho0eB61FYqDYhI3IQQD28pzfp3PWue+iX+lQOOkybTTEmVlysZMul3ohrOc/x gAGp2lkoOlFg7DEGopnyGO1z3gnTVKaUp44tpe4V0CZmoXXXY7lnE15r3H20E6lBH8P0 764SqtreNWw7hgU1JoKb+YWBKaLOHCSSqc+KVUG+TkCSd5+eu2xs1Kgei7zLprIQhUzl HMPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7v93/ghV4WVnzAYYOsCX1Kw33dDbIUr4NDtKrgi7+HI=; b=ewuZm9lKUMh3TKZ6Rybv7RGKWzYYhGZKumBZIkWERE6kzS0h7gw0xh95GpHpv021qE h0nWOel1/yWo0Ld7fcCtzke3lWkcrjFRjXnyKFQ20RBzItmade0RB9QhTN9PflxP/J8T Y1DmW+MDPt94UdIti2Se0pYnbQIgk5MyVxZ5zJO2OFOB7xX6P2YDwfOy2qSiAq6WVYYh NJWZa9+hUoJNVA+Xo9LkmekQYaZtXhyDL+Uv6CTcG1xtRWQjAbKGw36GnyrFfokcM1uB NoUkxA9TFlPvwYlacjzfZM5BYyIzXriMv9rdUxRFJdAjGoEY0FNI7/FUeUkbI6GeN8IV uGVg== X-Gm-Message-State: ANoB5pkONEk0JkjCLrFtXTImlGxPzyesDDfsoHr8+h5x8pNqf0RpYWYQ E6qfY7LmZ1lvayfNjNxv3JDOsBRxhgfXGnw8Cbw= X-Google-Smtp-Source: AA0mqf7N1dPzUsUTLhO1G6cOxvPphTeQ6L1+hg/X+quDXShLGcSkvOC1faJpTdMmm557Fw4xkBhXudxvs/J4ivL8pho= X-Received: by 2002:a05:6102:914:b0:3ac:6376:1e41 with SMTP id x20-20020a056102091400b003ac63761e41mr10499594vsh.80.1669336103016; Thu, 24 Nov 2022 16:28:23 -0800 (PST) In-Reply-To: <0bd4b2db-15cd-62e7-54f7-3eb26627e808@yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248936 Archived-At: I think we should keep the setter option in the signature too! Perhaps someone would want to copy/transfer the history from storage to storage. I made the commit with my @google.com email, I believe Google has already signed an agreement with the FSF for all staff. Is that okay? On Thu, Nov 24, 2022 at 3:59 PM Dmitry Gutov wrote: > > On 25/11/22 01:42, Ackerley Tng wrote: > >> (defcustom xref-history-storage 'xref-window-local-history > > Here's an updated patch! > > Nice. :-) Seems good to go. > > How would you like to sign the copyright assignment papers for Emacs? > > Regarding the patch, I was a tad surprised that there is no use for the > "setter" function of xref-history-store, but it makes sense given that > the value cons serves as a pointer to the data structure which we modify > in-place. > > Perhaps we should keep the setter option in the signature anyway, for > someone to be able to reset the history. Or save and restore it. Hm.