From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pengji Zhang Newsgroups: gmane.emacs.bugs Subject: bug#68570: 29.1; recompile might not re-use project-compile's buffer Date: Fri, 19 Jan 2024 15:19:08 -0500 Message-ID: References: <920b0c20-c6ee-4b41-84ec-5adfa06c64a2@jbornemann.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2730"; mail-complaints-to="usenet@ciao.gmane.io" To: 68570@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 19 21:20:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rQvLl-0000ZW-Mi for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Jan 2024 21:20:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQvLO-0008DK-8x; Fri, 19 Jan 2024 15:20:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQvLL-0008Ci-VU for bug-gnu-emacs@gnu.org; Fri, 19 Jan 2024 15:20:00 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQvLL-0007fl-NF for bug-gnu-emacs@gnu.org; Fri, 19 Jan 2024 15:19:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rQvLN-0006Zl-Pd for bug-gnu-emacs@gnu.org; Fri, 19 Jan 2024 15:20:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <920b0c20-c6ee-4b41-84ec-5adfa06c64a2@jbornemann.de> Resent-From: Pengji Zhang Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Jan 2024 20:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68570 X-GNU-PR-Package: emacs Original-Received: via spool by 68570-submit@debbugs.gnu.org id=B68570.170569556925222 (code B ref 68570); Fri, 19 Jan 2024 20:20:01 +0000 Original-Received: (at 68570) by debbugs.gnu.org; 19 Jan 2024 20:19:29 +0000 Original-Received: from localhost ([127.0.0.1]:60157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rQvKr-0006Yk-7t for submit@debbugs.gnu.org; Fri, 19 Jan 2024 15:19:29 -0500 Original-Received: from mail-qv1-xf36.google.com ([2607:f8b0:4864:20::f36]:42097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rQvKp-0006YY-TD for 68570@debbugs.gnu.org; Fri, 19 Jan 2024 15:19:28 -0500 Original-Received: by mail-qv1-xf36.google.com with SMTP id 6a1803df08f44-6818aa08a33so8587696d6.0 for <68570@debbugs.gnu.org>; Fri, 19 Jan 2024 12:19:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705695559; x=1706300359; darn=debbugs.gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=TokEejaVxrekNw0AI5xWaxCOqSxH3ITTufqdVuhc4fc=; b=cd1HaLsJbhgHPpqndfegiLOJ3no513ISh+F5y6utVhw+CPxJ7vh+WaPGy4F5F9mx+Y IJ9PMQeC+1+gkYZTN1foLJbyNaMwrSJck11WOoObnazkzKHEm6Sa7Qf3qSPsNyzEwLHl g7XnrKn4C46BoiTlz7WREALUbqF122mCsGCU1BNM6BsvoBtSf1IKEiLd382C3s84Ds+L IX5i2p2HnHrwnspF7OWyPbxyrS7XtqMhf9lBAmf0vBX3JduHDyn35YRrSxJq078uZapd vsRCPf23wEOlLfZj99Tc73L4HKWOKhWePCgtzNsM50Q2tlG5jlSD7RXbWZk2FAsCNA8q p4DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705695559; x=1706300359; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=TokEejaVxrekNw0AI5xWaxCOqSxH3ITTufqdVuhc4fc=; b=MBUrRPuje8mn3OX3iWigOc1MuSZ3a1coM97hVE9lr135shSQPWNPlsmBd256F6TETh tWEFHli3WvlaGz2clgxCA+BMnHNk0ZGVRMSP8BvyhNtMZowxcTgy/81z1KLk7kK97pXZ cRq8fBy57W9Eb0Rx+7wN2CRzhe86YFlQiXMz3w4/M1V39EpdW+06BjpsZ6fU5ttJ5pLT NFJqOqNlUacPF+9BRBJX1uMqyydppU0tOAJsoAitPqYm0kSaotEUy3Uj7wFs2wN2pmBe feRB2yIBALq3MndrjUUvnTl6Ilz77faZ+TXQ+Xp6jb66t4ZnSK1Vj1n9YT2Yg4+K6BiK XwMQ== X-Gm-Message-State: AOJu0YxpZGC//ILS7DLH7nXvPrYcQVPbGa7MvKKSZ5AVQCQeYzchCu36 udpjyKgQL1BL/Ne7UdYPl+IJaLOnesAL5nplwTMJsgHUVg7MdxeG6sp226yMXC59KYZnSgECOrq RsLg0/EEiEFN7HMAeB5Eh/PmbYgWglebq2ro= X-Google-Smtp-Source: AGHT+IHSWh15lRyuUmaziJoXuiLd0ze7rCyTnoG26FlWpWkouCnYSrw056VvY1BUuftzGbNkwf1jYyf0X8txtSf7qxk= X-Received: by 2002:a05:6214:f2e:b0:67f:8391:7d40 with SMTP id iw14-20020a0562140f2e00b0067f83917d40mr2755061qvb.51.1705695559396; Fri, 19 Jan 2024 12:19:19 -0800 (PST) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278544 Archived-At: Hi! I think you meant running `M-x recompile' not in a compilation buffer? While I agree that is convenient, I suppose it is better to only use `recompile' in a compilation buffer due to security reasons. `compile-command' is marked as a safe local variable assuming that the user would be prompted to check and confirm the command before running it. That is the behavior of `compile' but not `recompile'. For example, create a file '/tmp/test.c' with the following contents: /* Local Variables: */ /* compile-command: "echo 1" */ /* End: */ Then: - emacs -Q --eval "(require 'compile)" - C-x C-f /tmp/test.c - M-x recompile So we could run arbitrary commands without any warning or confirmation. Instead of a `project-recompile' command, it might be better to make `recompile' find the existing compilation buffer for the current buffer, and refuse to run the command (or ask for confirmation) if there is no such buffer.