From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yikai Zhao Newsgroups: gmane.emacs.bugs Subject: bug#71972: 31.0.50; Tramp does not parse ipv6 address with port correctly Date: Sun, 7 Jul 2024 23:56:56 +0800 Message-ID: References: <87bk3a1s3f.fsf@gmx.de> <871q461mm7.fsf@gmx.de> <87v81hzeaq.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31947"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71972@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 07 17:59:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sQUIE-00084k-Bs for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Jul 2024 17:59:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQUI0-0002GR-5Y; Sun, 07 Jul 2024 11:59:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQUHy-0002GA-NL for bug-gnu-emacs@gnu.org; Sun, 07 Jul 2024 11:58:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sQUHy-0002H1-Er for bug-gnu-emacs@gnu.org; Sun, 07 Jul 2024 11:58:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sQUI2-0003Jl-61 for bug-gnu-emacs@gnu.org; Sun, 07 Jul 2024 11:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yikai Zhao Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Jul 2024 15:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71972 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71972-submit@debbugs.gnu.org id=B71972.172036790012700 (code B ref 71972); Sun, 07 Jul 2024 15:59:02 +0000 Original-Received: (at 71972) by debbugs.gnu.org; 7 Jul 2024 15:58:20 +0000 Original-Received: from localhost ([127.0.0.1]:49013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQUHM-0003Im-3v for submit@debbugs.gnu.org; Sun, 07 Jul 2024 11:58:20 -0400 Original-Received: from mail-wr1-f49.google.com ([209.85.221.49]:61826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQUHK-0003IZ-8h for 71972@debbugs.gnu.org; Sun, 07 Jul 2024 11:58:19 -0400 Original-Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-367b0cc6c65so1109623f8f.3 for <71972@debbugs.gnu.org>; Sun, 07 Jul 2024 08:58:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=z1k.dev; s=google; t=1720367828; x=1720972628; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bPw+JJFrYOBDN6HpbWJQ8fKJXKkx2NOswVbsOWeFvck=; b=cFFhkEZdbYbUYwesbmV5yST4KY2h314OXGYkQ5Q7mHm6VbC/r7UjLI0QAfJfuNJfqF mFuZXbWY0wn9Wm6lNLgDqngHYA2xhBqlC7n8L+65+N9ulUQhMN7UnjvZzS/NJ2/vovnc H1nCmazi2CqE3WkwsE+5Dr/uy6z4BqxltPCCH8uS6p4PgfrdUniz9G58EpoSO7VTlL8l ndjU1HVEzeb9uLQkGj9iB+1Kmvhdu/0qgP7vzWrXKtxnuzocNjzLy4LuPlDUeg8sBp1J 6J0HC/ipdGa5b8a3SD4h7sNpUpljFUdKtfzKGSbTNNc5TJa71F27HgYYJPUsjQm8NxI+ +M8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720367828; x=1720972628; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bPw+JJFrYOBDN6HpbWJQ8fKJXKkx2NOswVbsOWeFvck=; b=qozmE9AMnP/rO1IB7cqfrXbYpN1l51HUWCOMLk/igfCY30ZqcZYNO+7Hu3hQiecZPm Eu+hf/P52gjNSka3t4PCAksNF7MDevO2daLqdFHQv/PEsAZ3mtqIpkUqrPNvJmxXHkF5 RPBa2MFD3OFwf/9bFzfNatLhGwGN5mXjBUUMEP3mUoJlJ6OFPysHotoxKAfSaVyjey4e gICzne33Lyt//e/b/7brQ3/J062wE7VM/GpMWdXtkaAV0vhtUoXRkDWS7lZslfPEa8Jn M7x0msF1UlT5YjvyfaZIICVG1FcQR+fFYmlUhV7fGZaRYA8AUIlEmiyDtSVTVb0X+1LS iA0A== X-Gm-Message-State: AOJu0YwdyLvnYoFyZz94eZqENnhBwhnvnmrUOXbNnSJgfSBZbjHf3qvV Mc2k0dSSCI2eZR8DZcUjtIGkBPAROvBiLjaoKBmz/LB08nG+IvEz5ClfnJELd8u6QOea1or7uTh knHcdHoDWZ76Kj9V2MADrXz4qjVwR6UylxIq+njYyPJx07kePlhk= X-Google-Smtp-Source: AGHT+IH6sseO2/deCmIhX9Z8XUQDBksjbfrwLbI4jl0TpoVuMgokgKySv0VPBfyZQ7MJqIRFFUbO3zpDbDkavgqmI9Q= X-Received: by 2002:a05:6000:e90:b0:367:9224:9621 with SMTP id ffacd0b85a97d-3679dd3366bmr6567975f8f.31.1720367827922; Sun, 07 Jul 2024 08:57:07 -0700 (PDT) In-Reply-To: <87v81hzeaq.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288563 Archived-At: Thanks! I can confirm this patch fixes the issue for me. BTW, is there any chance that this patch would make it into emacs 30 releas= e? Regards, Yikai On Sun, Jul 7, 2024 at 6:28=E2=80=AFPM Michael Albinus wrote: > > Yikai Zhao writes: > > > Hi, > > Hi, > > > Thanks for the patch. However, with this patch applied to master, the r= esult is: > > > > (tramp-dissect-file-name "/ssh:[2001::abcd]#2202:/tmp/xxx") > > =3D> (tramp-file-name "ssh" nil nil #("Oldtown" 0 7 (tramp-default t)) > > "2202" "/tmp/xxx" nil) [2 times] > > > > ("oldtown" is my local hostname). Although the port is correctly > > parsed, the host is now incorrect. > > Indeed, we have a race condition. tramp-host-with-port-regexp is defined > before tramp-set-syntax has run. > > Could you, please, try the appended patch indeed? > > > Also note that in master, the correct file path for tramp.el is > > lisp/net/tramp.el, so I had to manually edit your patch before > > applying it. What version is your patch based on? Maybe the result is > > different in different versions? > > I develop in the Tramp git repo. The files are identical with the ones > in the Emacs git repo. However, there is a different directory structure. > > Best regards, Michael. >