all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alexander Kuleshov <kuleshovmail@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 27597-done@debbugs.gnu.org
Subject: bug#27597: [PATCH] fix warnings in src/xdisp.c
Date: Sat, 8 Jul 2017 16:28:48 +0600	[thread overview]
Message-ID: <CANCZXo42dH4bXpFDn4fP+v=Qv12MK9kw3+Hvpinj=yg3fEGs5g@mail.gmail.com> (raw)
In-Reply-To: <83h8ynl4rv.fsf@gnu.org>

On Sat, Jul 8, 2017 at 2:19 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Alexander Kuleshov <kuleshovmail@gmail.com>
>> Date: Thu, 6 Jul 2017 17:47:03 +0600
>>
>> here is simple fix for following warnings:
>>
>> xdisp.c: In function ‘Fdump_glyph_matrix’:
>> xdisp.c:19320:20: error: format ‘%lld’ expects argument of type ‘long
>> long int’, but argument 3 has type ‘ptrdiff_t {aka long int}’
>> [-Werror=format=]
>>    fprintf (stderr, "PT = %"pI"d, BEGV = %"pI"d. ZV = %"pI"d\n",
>>
>> from src/xdisp.c
>
> Thanks, pushed to master.
>
> In the future, please provide a commit log message that is according
> to our coding standards:
>
>  . mention the names of functions in which you make changes
>  . start sentences with a capital letter
>  . mention the bug number
>
> Here's the log message I used in this case:
>
>         * src/xdisp.c (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
>         Use pD directives for ptrdiff_t values instead of pI, to avoid
>         compilation warnings on 64-bit hosts.  (Bug#27597)
>

Hello Eli,

Yes, thanks, I'll take into account code style next time.





      reply	other threads:[~2017-07-08 10:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-06 11:47 bug#27597: [PATCH] fix warnings in src/xdisp.c Alexander Kuleshov
2017-07-08  8:19 ` Eli Zaretskii
2017-07-08 10:28   ` Alexander Kuleshov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANCZXo42dH4bXpFDn4fP+v=Qv12MK9kw3+Hvpinj=yg3fEGs5g@mail.gmail.com' \
    --to=kuleshovmail@gmail.com \
    --cc=27597-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.