From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Jacobowitz Newsgroups: gmane.emacs.bugs Subject: bug#66381: 29.1; Auto-revert not polling files when notifications are enabled Date: Sat, 7 Oct 2023 14:41:35 -0400 Message-ID: References: <83jzrz0xeq.fsf@gnu.org> <87bkdaihuo.fsf@gmx.de> <87il7igybs.fsf@gmx.de> <875y3igvp3.fsf@gmx.de> <83fs2mz3r6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20654"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66381@debbugs.gnu.org, michael.albinus@gmx.de To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 07 21:21:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qpCrc-000599-KM for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Oct 2023 21:21:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qpCrF-0003ZW-Pz; Sat, 07 Oct 2023 15:21:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpCqy-0003Yw-T4 for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 15:20:45 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qpCqx-0003cc-4Y for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 15:20:44 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qpCrG-0003a8-KV for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 15:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Jacobowitz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Oct 2023 19:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66381 X-GNU-PR-Package: emacs Original-Received: via spool by 66381-submit@debbugs.gnu.org id=B66381.169670641113419 (code B ref 66381); Sat, 07 Oct 2023 19:21:02 +0000 Original-Received: (at 66381) by debbugs.gnu.org; 7 Oct 2023 19:20:11 +0000 Original-Received: from localhost ([127.0.0.1]:55948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpCqR-0003UH-6g for submit@debbugs.gnu.org; Sat, 07 Oct 2023 15:20:11 -0400 Original-Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:55401) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpCFg-00029i-3H for 66381@debbugs.gnu.org; Sat, 07 Oct 2023 14:42:12 -0400 Original-Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-536b39daec1so5558634a12.2 for <66381@debbugs.gnu.org>; Sat, 07 Oct 2023 11:41:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696704106; x=1697308906; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qBXtsTU5HYG9JAGCiKHWIj7qkcRg6MnqJh+N0KKyW7I=; b=FSoDWmnzTH+T5OjW3LvzyJAXe0oduRSi991AXnnE0YhR0M/NvUmDA7tkgS8Kd8WpRE 7Yrc/tJ/0PegPAseqzE8fvFH6+5E2NVWzVgafDbEI0s6a2WuPVA+3asjRfWf25NW3eeC yP1laqySB6o1i80meaTTOMLPFJaS3brLfxoUOff7MOnzcb/ZsVJhGyRASkJq557fNTT/ /jXJUmDDdVpYFYcFiFhuJE8/fbzXcQHjjtc6P/qtC2u8dxrHslpkDHjbyEWheIXtuv14 +xlxspd0hiZqlIweelH3NjW8BmWTV+jr5WOoCLswts58aDidHXRB1nOewrce6cWo13yV NT4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696704106; x=1697308906; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qBXtsTU5HYG9JAGCiKHWIj7qkcRg6MnqJh+N0KKyW7I=; b=DtNJy3Ewc30oQx64YtiNwNrXXa988f5wISNqhFdX3pyr90glQZjnjb/3rhrxXu91q1 QhB0Qw4FL3uEwCM0h0OzkBnjEC6iuCGbbyIAfeqnUMDz1QnrTPHDSJy6nEVWQcGzx5by Vo4cA8xJpTLxFXnLZE4PmrYaGV+rffSnilRDctig65WhJ0J7bfyp5vJY1tKeagHOWrvI P7guU7jrOPusshJclzWUhbFG1gWx5vt9wHDG3sj4/EondtVPWXJhIV/kC3PRD98r0vNo AG5DnaGgtTPbquj513494XT+UL8/9G1ycwyn+Wu1eMcDIm42Brvs+7Abt0f4PPySritL FoaA== X-Gm-Message-State: AOJu0Yy9QvitGa9Y3J4CWJo2wv1CAnAKlU4hnih2Iksd8owNvEFQ2wMm vTkoKWTFADjeKgvLN+/G88FdBpSL6h0Bi+7khO0= X-Google-Smtp-Source: AGHT+IHie3BdB9GvHlHa/LPyj670mNAvaQZ+R12w2/9rgX0wxjPjjBkihte7wD4oQ3U61kwE3c4/pfmdlt0l7ra5A9o= X-Received: by 2002:aa7:c0d2:0:b0:530:e2e3:28af with SMTP id j18-20020aa7c0d2000000b00530e2e328afmr9607018edp.31.1696704106277; Sat, 07 Oct 2023 11:41:46 -0700 (PDT) In-Reply-To: <83fs2mz3r6.fsf@gnu.org> X-Mailman-Approved-At: Sat, 07 Oct 2023 15:20:09 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272043 Archived-At: Isn't it? In auto-revert-handler: https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/autorevert.el#n779 (if buffer-file-name (and (or auto-revert-remote-files (not (file-remote-p buffer-file-name))) (or (not auto-revert-notify-watch-descriptor) auto-revert-notify-modified-p) (if auto-revert-tail-mode (and (file-readable-p buffer-file-name) (/=3D auto-revert-tail-pos (setq size (file-attribute-size (file-attributes buffer-file-name)))= )) (funcall (or buffer-stale-function #'buffer-stale--default-function) t))) When buffer-file-name, revert is true iff: 1. auto-revert-remote-files or the file is not remote AND 2. there is no watch descriptor or a notification was received AND 3. some details about auto-revert-tail-mode OR t If auto-revert-notify-watch-descriptor and not auto-revert-notify-modified-p, then the file won't be reverted. auto-revert-handler does get called by the polling timer, but it doesn't revert. On Sat, Oct 7, 2023 at 2:28=E2=80=AFPM Eli Zaretskii wrote: > > > From: Daniel Jacobowitz > > Date: Sat, 7 Oct 2023 14:14:45 -0400 > > Cc: 66381@debbugs.gnu.org, Eli Zaretskii > > > > Coming back to my original suggestion: the documentation says that poll= ing is used even if > > notifications are enabled. The implementation does not poll if there's = a notification registered. > > That last sentence is not true. --=20 Thanks, Daniel