From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Jacobowitz Newsgroups: gmane.emacs.bugs Subject: bug#66381: 29.1; Auto-revert not polling files when notifications are enabled Date: Sat, 7 Oct 2023 14:14:45 -0400 Message-ID: References: <83jzrz0xeq.fsf@gnu.org> <87bkdaihuo.fsf@gmx.de> <87il7igybs.fsf@gmx.de> <875y3igvp3.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000009e75e00607245534" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21174"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66381@debbugs.gnu.org, Eli Zaretskii To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 07 21:21:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qpCrj-0005KA-HK for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Oct 2023 21:21:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qpCrI-0003aJ-FC; Sat, 07 Oct 2023 15:21:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpCqy-0003Yx-T5 for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 15:20:48 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qpCqw-0003cZ-Lf for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 15:20:44 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qpCrG-0003a0-6d for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 15:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Jacobowitz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Oct 2023 19:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66381 X-GNU-PR-Package: emacs Original-Received: via spool by 66381-submit@debbugs.gnu.org id=B66381.169670641113412 (code B ref 66381); Sat, 07 Oct 2023 19:21:02 +0000 Original-Received: (at 66381) by debbugs.gnu.org; 7 Oct 2023 19:20:11 +0000 Original-Received: from localhost ([127.0.0.1]:55946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpCqQ-0003UD-Es for submit@debbugs.gnu.org; Sat, 07 Oct 2023 15:20:11 -0400 Original-Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:59659) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpBpi-0001EY-EP for 66381@debbugs.gnu.org; Sat, 07 Oct 2023 14:15:26 -0400 Original-Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-53808d5b774so5819999a12.3 for <66381@debbugs.gnu.org>; Sat, 07 Oct 2023 11:15:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696702497; x=1697307297; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=SqLqNED2jwapSlb4h87qLoYAdumQmGWScoEgoLJY+6Q=; b=UpKzNOSkQSg2EQ94V+exzaXdhzXnyLn9JEItAHn09d1LSdpztABY3sjR9vMliRRmkq 2S310P8rwbCzVf2GabhFH97dD5ydCaJcV4vFFEuPs3WHmjNkp+S94Gjws9MaF+LuiNEh 1wTpZMp56OvZtuUtvyf0oxnBqslCpKHjg9pRkt6AEV02mRYH9tT9bsAMBgSUmaGjxCch +4tAbLZe17UTn7eC0JfujuGWQXcSN2NXOZxQm7Ywln91Uq0jOSpJOTlZTORxLLt+J4sh wQqIWGtgW3tdyZIpQqRaBNcVdb4Lsg9EZG+dZUrBp6ftxj1g3YN6k6nMVq/YDf3FATt+ dhKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696702497; x=1697307297; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SqLqNED2jwapSlb4h87qLoYAdumQmGWScoEgoLJY+6Q=; b=APaSmiGmpRridAu6mCMX4rd863M8fOA79DLNVqlAc935cpYn3+sm2bCNQAtBLoyGVk zRDBBj5e49pXIBNAZnttO+aCqxdjfmHxX8cHOGpXhUV7FD6SYvucjcneegZWtojnYTcv /u3fBlIXWU27Duw/sISG8OMXyFaKXWGpzqsH6TLMuxsELHNj90DNUqSAbdOtmKhO6d0a nvjZF0IUQCvJc9lvkogEpNh4saYTujKBlp1nvZz0Dv4kC0ULEJbF40UI++0MEz3fYf3O stksx0s+pUI27wSvIPQx8UWCnf1yiLDL14TG+CEQR78eP3mIDVh3V4zAIgiohkvTIfYq w5xA== X-Gm-Message-State: AOJu0YxXDd6d8KA8WP7FZn5AMOi62nduhUacGfaBRSVE1jWNB4/b6/CH U/z22TNbNzEw4jIZyIPIf+kPd2IeV5IKWrcwjXt1iMhs X-Google-Smtp-Source: AGHT+IG8cWQHkfBsBSsu2+3Gq5Y29OhEAhLD2RK8raB8X9DlpffXEtxduoOHSlhXDpEGSyWqgimxXohde6+9zn/cJKA= X-Received: by 2002:aa7:d151:0:b0:530:db58:61c8 with SMTP id r17-20020aa7d151000000b00530db5861c8mr10703192edo.23.1696702496927; Sat, 07 Oct 2023 11:14:56 -0700 (PDT) In-Reply-To: <875y3igvp3.fsf@gmx.de> X-Mailman-Approved-At: Sat, 07 Oct 2023 15:20:09 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272044 Archived-At: --0000000000009e75e00607245534 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Coming back to my original suggestion: the documentation says that polling is used even if notifications are enabled. The implementation does not poll if there's a notification registered. Which behavior is intended? On Sat, Oct 7, 2023 at 1:59=E2=80=AFPM Michael Albinus wrote: > Daniel Jacobowitz writes: > > Hi Daniel, > > > It's /google/src//file.txt, with the mount > > point on /google/src. Mount details: > > > > srcfsd /google/src fuse.srcfsd > > > rw,nosuid,nodev,relatime,user_id=3D125,group_id=3D0,default_permissions,a= llow_other > > 0 0 > > > > There's no stop notification generated, whether I restart or kill the > > daemon or just umount -l. inotifywait(1) agrees. I've got no idea what > > parts of this may be local kernel behavior versus FUSE in general, but > > I would guess that FUSE in general is more likely. > > Yes, likely this is due to the srcfsd FUSE type. I don't use it, so I > cannot test. > > Since inotify doesn't deliver IN_IGNORED (and the file-notify `stopped' > event doesn't appear therefore) we cannot do too much. We have no API > which sends heartbeat checks on watched file systems; such a check could > solve the problem. But there are no plans. Your workaround by restarting > global-auto-revert-mode every night might be the best you could use. > > Best regards, Michael. > --=20 Thanks, Daniel --0000000000009e75e00607245534 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Coming back to my original suggestion: the documentation s= ays that polling is used even if notifications are enabled. The implementat= ion does not poll if there's a notification registered. Which behavior = is intended?

On Sat, Oct 7, 2023 at 1:59=E2=80=AFPM Michael Albinus <michael.albinus@gmx.de> wrote:=
Daniel Jacobowi= tz <dan= iel.jacobowitz@gmail.com> writes:

Hi Daniel,

> It's /google/src/<censored>/file.txt, with the mount
> point on /google/src. Mount details:
>
> srcfsd /google/src fuse.srcfsd
> rw,nosuid,nodev,relatime,user_id=3D125,group_id=3D0,default_permission= s,allow_other
> 0 0
>
> There's no stop notification generated, whether I restart or kill = the
> daemon or just umount -l. inotifywait(1) agrees. I've got no idea = what
> parts of this may be local kernel behavior versus FUSE in general, but=
> I would guess that FUSE in general is more likely.

Yes, likely this is due to the srcfsd FUSE type. I don't use it, so I cannot test.

Since inotify doesn't deliver IN_IGNORED (and the file-notify `stopped&= #39;
event doesn't appear therefore) we cannot do too much. We have no API which sends heartbeat checks on watched file systems; such a check could solve the problem. But there are no plans. Your workaround by restarting global-auto-revert-mode every night might be the best you could use.

Best regards, Michael.


--
Th= anks,
Daniel
--0000000000009e75e00607245534--