From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Tadeus Prastowo Newsgroups: gmane.emacs.bugs Subject: bug#35056: 26.1; Tetris score is no longer updated due to commit 995be66f0f0d26d1a96cbb8dfb429c3941157771 Date: Sun, 31 Mar 2019 21:41:20 +0200 Message-ID: References: <78ea6992-85b1-e005-2c33-7b1df1c04031@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="245818"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35056@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 31 21:42:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hAgLL-0011qH-Pe for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 Mar 2019 21:42:11 +0200 Original-Received: from localhost ([127.0.0.1]:39269 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAgLK-0008Hm-N4 for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 Mar 2019 15:42:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAgLD-0008FY-Ks for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2019 15:42:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hAgLC-0005Mg-Ea for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2019 15:42:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53180) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hAgLC-0005MT-7L for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2019 15:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hAgLB-0002Yh-TL for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2019 15:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tadeus Prastowo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 Mar 2019 19:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35056 X-GNU-PR-Package: emacs Original-Received: via spool by 35056-submit@debbugs.gnu.org id=B35056.15540612999805 (code B ref 35056); Sun, 31 Mar 2019 19:42:01 +0000 Original-Received: (at 35056) by debbugs.gnu.org; 31 Mar 2019 19:41:39 +0000 Original-Received: from localhost ([127.0.0.1]:38491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAgKp-0002Y4-GC for submit@debbugs.gnu.org; Sun, 31 Mar 2019 15:41:39 -0400 Original-Received: from mail-it1-f177.google.com ([209.85.166.177]:52908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAgKm-0002Xq-RI for 35056@debbugs.gnu.org; Sun, 31 Mar 2019 15:41:38 -0400 Original-Received: by mail-it1-f177.google.com with SMTP id g17so11443389ita.2 for <35056@debbugs.gnu.org>; Sun, 31 Mar 2019 12:41:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unitn.it; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0HfvP46mgJL+KtHTEs/SABpRoOccN9aiRWNbFSUWlbU=; b=STplVCm57pxOMkakru5fM6RXUGfrjKKv21TOZ3QQU0HlqSZVmshFDxKgG4LTG/o5b4 eqZG0spFGPqMhrZVkTbLUOyqG93NcCQLlrrF1dr/IkRWvma1WAzUXl1wS4SR+ZehBURp rFS6ONt1DOfiTc4Ojpb5p0VJAoLb8RQN8FmqY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0HfvP46mgJL+KtHTEs/SABpRoOccN9aiRWNbFSUWlbU=; b=aH9/Vjk25Axlrx3nrP2B+jJRqdzmST72eNrGFCJSRMI/DKU0cRBkAh2aA88yglVYjb Zg3mNBycRq2dEMHMBicTknYO8rlwN7cCzTMHfcRrD1LY1VsGs80MzRlM9Ke0w+kEyLgY G7dt9q6ASd78yiwOAJKPkjW3rqJy08J6KlorazHjpis/noWA8hoZn8MMbE25D3Rm1kor c3MyVRK0aKmjccgEWAXmwyf65bg2b1jfGPMBpkhO1WEcMC/+gkyaYL8hC4exiQ2AHmz2 i/vmJ9CEZSp6eyDE4eMuH/K+4PTHHNKnwz8xkahwLDprq+4jRkfve9SgQPj3qbusrSMu vfGw== X-Gm-Message-State: APjAAAUofe4V/lNVpTUyNN4itL+XTCqrJgz4cK/PtQqCYZLCagCrqK9q ocIMoGK/9MZCpHFGzxjCNLPAI4+/q6i8ciCy1uR/ X-Google-Smtp-Source: APXvYqyD6elHUa66YqxwX2auSKkkPYZTDl0BogxZLrcXNm7Ler9YWoqb+jkZjtRxTS8J+3pzNepZqA10a4xdgO8SONQ= X-Received: by 2002:a24:3c4c:: with SMTP id m73mr13452987ita.23.1554061290951; Sun, 31 Mar 2019 12:41:30 -0700 (PDT) In-Reply-To: <78ea6992-85b1-e005-2c33-7b1df1c04031@cs.ucla.edu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156982 Archived-At: On Sun, Mar 31, 2019 at 5:32 AM Paul Eggert wrote: > > Apparently the problem is that there are two formats of Tetris game-score files. > One format is used by play/gamegrid.el itself, the other is used by the > update-game-score command. I didn't know that; I thought that the only reason to > use update-game-score was to get setuid/setgid permissions, and that the file > format didn't change. Perhaps you need to make a test unit to ensure there is no regression in the future. > To some extent the file-format problem is Just One Of Those Things: if up > upgrade Emacs and it changes the file format, Emacs is not smart enough to deal > with the format change and so it loses your old Tetris scores. > > That being said, Emacs could try harder to use the update-game-score program if > it's installed. Is it in your installation? If so, please try the attached > patch. If not, please try redoing 'configure' so that update-game-score is built > and installed, and then try the attached patch. I apply your patch to Emacs 26.1 source (http://ftp.gnu.org/gnu/emacs/emacs-26.1.tar.xz), and run the following configure command: configure --prefix=/mnt/core/Codebases/installzone/emacs --with-xwidgets --disable-silent-rules --with-gameuser=yes And, then the following make command: make make install I played Tetris, scoring higher than the lowest recorded in my high score file, and I confirm that your patch allows the score to be recorded after year 2018 went by without any new record due to the bug introduced by commit 995be66f0f0d26d1a96cbb8dfb429c3941157771. > I suppose it would be possible to do more-serious hacking in gamegrid.el to deal > with the incompatible file formats (convert formats back and forth, say), but > that would be beyond my call of duty. I like your patch: if it ain't broken, don't fix it, dude ;) -- Best regards, Tadeus