From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tadeus Prastowo Newsgroups: gmane.emacs.bugs Subject: bug#28623: 27.0.50; lisp/progmodes/cc-engine.el incorrect indentation of C++14 curly-brace initializer list Date: Fri, 10 Nov 2017 13:07:51 +0100 Message-ID: References: <20171004181552.GA15562@ACM> <20171011203221.GB7384@ACM> <20171104195639.GA5384@ACM> <20171108192358.GA4582@ACM> <20171109185354.GA15085@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1510315752 12840 195.159.176.226 (10 Nov 2017 12:09:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 10 Nov 2017 12:09:12 +0000 (UTC) Cc: John Wiegley , 28623-done@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 10 13:09:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eD87P-00036R-PS for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Nov 2017 13:09:08 +0100 Original-Received: from localhost ([::1]:41280 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eD87X-000755-6Z for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Nov 2017 07:09:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eD87P-00074l-ID for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2017 07:09:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eD87O-0007Bq-IL for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2017 07:09:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52807) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eD87K-0006uu-4l; Fri, 10 Nov 2017 07:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eD87J-00062n-W4; Fri, 10 Nov 2017 07:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tadeus Prastowo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Fri, 10 Nov 2017 12:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28623 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: Original-Received: via spool by 28623-done@debbugs.gnu.org id=D28623.151031571123190 (code D ref 28623); Fri, 10 Nov 2017 12:09:01 +0000 Original-Received: (at 28623-done) by debbugs.gnu.org; 10 Nov 2017 12:08:31 +0000 Original-Received: from localhost ([127.0.0.1]:33255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eD86n-00061x-KQ for submit@debbugs.gnu.org; Fri, 10 Nov 2017 07:08:31 -0500 Original-Received: from mail-io0-f175.google.com ([209.85.223.175]:51545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eD86m-00061i-7Z for 28623-done@debbugs.gnu.org; Fri, 10 Nov 2017 07:08:28 -0500 Original-Received: by mail-io0-f175.google.com with SMTP id b186so13348516iof.8 for <28623-done@debbugs.gnu.org>; Fri, 10 Nov 2017 04:08:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unitn-it.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=gxaDrOVVw0vS9NUxTqp2z3S/DuJqzQ1eZGLJSpTjhD8=; b=PjrZu43mByRODMNOlgroaeWyhgO2fNpaUDf0td681q2yYg1eJqA6L0stf+dva2rK0d OCAFW4oVNaQmjfZpGJtc1L0dHyHy/Olnrxa+u9YPlEv3X+yQyOA0M/79XGTEDexhNKrW 17al9niYrcVKW/0OLVIW6O0b6DWszLqRAdGj5x3dVPIVwiYsIta6zs5PrEKiguHfDhGa JwSOaIqFO5tOFRAnq/53a9q1UsqtVJTYLgkbxEJL6XYdbD3mPwtfgKFKpW8lroAKEYdj TIbB9+L4Z/1SdDKoS/eLbCDGHxWybgH0oFMCbpXXdF5b8i5MRiMORtRUHRh/TSmy3x5M E7TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=gxaDrOVVw0vS9NUxTqp2z3S/DuJqzQ1eZGLJSpTjhD8=; b=lbi9uCH6Jme8utRMlvkELrNzJSc1IrzJPh9N51uONVGlL4SMXUvxwfv39fVP4oKdj/ zEgYbO4ZK+zh0WhHcvnWNSwrfr16rDS0Y9Nks28sR8M8bQD7ln6/1T46EKmEYRuHFcrl iqu5i4zy7mmDusxa2U03Id7aanGmEruPhOWULG4k/FWMg47xzzuzEH28rngHVbo89e+L nWynxcLzGaotAEjgiZHbOUUZak0D7wqgH62Ua3PovMfSlwR+KnYxao3V9s3nPkqSFYHq /+xoJttEHfXNz8x4jHQ1WaBhO3G+vkDRBM7GnGJIfV7MZxnTYgZE67/NqGLPyr5WRV0X lM7Q== X-Gm-Message-State: AJaThX5hJIr3eERmEAeNJO0O+5BE8uD6jGj1UnXXwhkvNnJ+DnhgT8ga vjApvcPRQIf0uH8Z1V42JOHS39GSLVi2qy6r6IJ2 X-Google-Smtp-Source: AGs4zMbrOpkuV5laPpXPwQl127xvOY+VSul2mdnC4A6uOD5SfcJwN7OlU+mAleuo0rd5O4k9WOMQWLMs1RFMMqhqPXM= X-Received: by 10.107.129.149 with SMTP id l21mr123304ioi.193.1510315702377; Fri, 10 Nov 2017 04:08:22 -0800 (PST) Original-Received: by 10.2.6.2 with HTTP; Fri, 10 Nov 2017 04:07:51 -0800 (PST) In-Reply-To: <20171109185354.GA15085@ACM> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139728 Archived-At: Hi Alan! On Thu, Nov 9, 2017 at 7:53 PM, Alan Mackenzie wrote: > Hello, Tadeus. > > On Thu, Nov 09, 2017 at 10:27:55 +0100, Tadeus Prastowo wrote: [...] > I've committed the patch to the canonical places, including the emacs-26 > branch at savannah (whence it will find it's way into master), and I'm > closing the bug. Thank you very much. >> And, just out of curiosity, in cc-engine, there is a long function >> with many inline comments in the form of CASE xxx. Why aren't those >> refactored into individual functions? Performance issue? > > There are two such functions, c-forward-decl-or-cast-1 and > c-guess-basic-syntax. Both of them have LOTS of local variables which > would have to be passed into smaller individual functions, and sometimes > those functions would have to alter the "more global" version of the > variable. > > Doing this would indeed be slower, but probably not very much. I suspect > all the parameter passing would be awkward. But it's worth stating that > my predecessor, Martin Stjernholm, extracted c-guess-continued-construct > from c-guess-basic-syntax, which shows that it is possible. I see. Thank you very much for kindly explaining that to me. > -- > Alan Mackenzie (Nuremberg, Germany). -- Best regards, Tadeus