From: Tadeus Prastowo <tadeus.prastowo@unitn.it>
To: Alan Mackenzie <acm@muc.de>
Cc: John Wiegley <jwiegley@gmail.com>, 28623-done@debbugs.gnu.org
Subject: bug#28623: 27.0.50; lisp/progmodes/cc-engine.el incorrect indentation of C++14 curly-brace initializer list
Date: Fri, 10 Nov 2017 13:07:51 +0100 [thread overview]
Message-ID: <CAN-HRFZ1=4EYSJmGMNSosUzPm9Dg=m+zqWyTfYuDQ+Y-fP3M_Q@mail.gmail.com> (raw)
In-Reply-To: <20171109185354.GA15085@ACM>
Hi Alan!
On Thu, Nov 9, 2017 at 7:53 PM, Alan Mackenzie <acm@muc.de> wrote:
> Hello, Tadeus.
>
> On Thu, Nov 09, 2017 at 10:27:55 +0100, Tadeus Prastowo wrote:
[...]
> I've committed the patch to the canonical places, including the emacs-26
> branch at savannah (whence it will find it's way into master), and I'm
> closing the bug.
Thank you very much.
>> And, just out of curiosity, in cc-engine, there is a long function
>> with many inline comments in the form of CASE xxx. Why aren't those
>> refactored into individual functions? Performance issue?
>
> There are two such functions, c-forward-decl-or-cast-1 and
> c-guess-basic-syntax. Both of them have LOTS of local variables which
> would have to be passed into smaller individual functions, and sometimes
> those functions would have to alter the "more global" version of the
> variable.
>
> Doing this would indeed be slower, but probably not very much. I suspect
> all the parameter passing would be awkward. But it's worth stating that
> my predecessor, Martin Stjernholm, extracted c-guess-continued-construct
> from c-guess-basic-syntax, which shows that it is possible.
I see. Thank you very much for kindly explaining that to me.
> --
> Alan Mackenzie (Nuremberg, Germany).
--
Best regards,
Tadeus
prev parent reply other threads:[~2017-11-10 12:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 17:49 bug#28623: 27.0.50; lisp/progmodes/cc-engine.el incorrect indentation of C++14 curly-brace initializer list Tadeus Prastowo
2017-09-27 19:31 ` John Wiegley
2017-10-04 18:15 ` Alan Mackenzie
2017-10-06 2:59 ` Tadeus Prastowo
2017-10-11 20:32 ` Alan Mackenzie
2017-10-12 11:38 ` Tadeus Prastowo
2017-11-04 19:56 ` Alan Mackenzie
2017-11-06 22:46 ` Tadeus Prastowo
2017-11-08 19:23 ` Alan Mackenzie
[not found] ` <20171108192358.GA4582@ACM>
2017-11-09 9:27 ` Tadeus Prastowo
2017-11-09 18:53 ` Alan Mackenzie
[not found] ` <20171109185354.GA15085@ACM>
2017-11-10 12:07 ` Tadeus Prastowo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN-HRFZ1=4EYSJmGMNSosUzPm9Dg=m+zqWyTfYuDQ+Y-fP3M_Q@mail.gmail.com' \
--to=tadeus.prastowo@unitn.it \
--cc=28623-done@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=jwiegley@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.