From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ship Mints Newsgroups: gmane.emacs.bugs Subject: bug#72701: eglot crash when project-files-relative-names t Date: Fri, 23 Aug 2024 11:10:02 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000000a512506205b2cf5" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3556"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , 72701@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 23 17:12:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1shVxd-0000kb-CQ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Aug 2024 17:12:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1shVxZ-00066a-1c; Fri, 23 Aug 2024 11:12:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1shVxX-00066N-Eb for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2024 11:12:15 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1shVxX-00085i-5o for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2024 11:12:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=Ll5yvz3I3RGKMtVEmya4RMdXYPG004nIYNwn/V6f0EI=; b=pI+Rll9nAaT8cSmWvP7MegWW7WUHQMFNjt6E6I3/2MIUNz/CTyAUa64m8ozOXBxLg+n4hOrh2+unMjNfvZePh2+bNxaLfJB8ic+XtfjbeQ39elobja3ROm2T7IdTj/diV4KcVoChjxCuW7WK7DVPSYnImIbr/GAiCyn654FSWiKwXKHnfEJdV2x4+tSRUFF0DsFmOv//gdKz+UoqxXPXltRNDP5OwsOXRYu5KGOmdUhPSqjYDJN8kGJj/uKmACCZi2Ae+XCGhNaI4gV3l7xqx+xyue37rB7cJgOTJfcGJoGlGGRx6a1eSeAQE+TKBLAo4HE9bt1dGwRspkeEcE5lrQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1shVyI-0003HG-Dj for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2024 11:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ship Mints Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Aug 2024 15:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72701 X-GNU-PR-Package: emacs Original-Received: via spool by 72701-submit@debbugs.gnu.org id=B72701.172442592812507 (code B ref 72701); Fri, 23 Aug 2024 15:13:02 +0000 Original-Received: (at 72701) by debbugs.gnu.org; 23 Aug 2024 15:12:08 +0000 Original-Received: from localhost ([127.0.0.1]:39995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shVxP-0003Ff-Hn for submit@debbugs.gnu.org; Fri, 23 Aug 2024 11:12:07 -0400 Original-Received: from mail-oo1-f50.google.com ([209.85.161.50]:58747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shVxO-0003F6-7W for 72701@debbugs.gnu.org; Fri, 23 Aug 2024 11:12:06 -0400 Original-Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-5dca990cf58so1630963eaf.1 for <72701@debbugs.gnu.org>; Fri, 23 Aug 2024 08:11:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724425813; x=1725030613; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Ll5yvz3I3RGKMtVEmya4RMdXYPG004nIYNwn/V6f0EI=; b=B5f/FD3yexijtPL0Af5dYh47YdkJLjwyrLPrYkxd5uLRFpPKtDV5ukg1InCIdGdD32 NQx678ta5GFVVru+d1jbD9RlTF7zCNoucaMixvrVcyyJvWcrmRmHVz5n2NJAYQQjb4TA vB7yjs0o7olGWXzG4sBss44DyNX00S166/At0XJMzyi+xYDO2unPhiqvZ8HK1j24rs9C PJcdEXDEyBRnfr4mCDOO2ADtNPpY1829ksye0mQ8VJK1WzSGxGUwLEEhekOa+O/LYE4F xOPvQbA3st1MpGQzPpWh0jgL4piDMipeXwuEmcG0V+Qp6Mkq8pxQtpm+S1BhvAaz1R1B okwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724425813; x=1725030613; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ll5yvz3I3RGKMtVEmya4RMdXYPG004nIYNwn/V6f0EI=; b=dadAyP1cpg32oEEQ7+Ztq8calQyr7etTuwTTkTovDyKAI0wTBOTKxjiUQkIgThgqwA ze7NjYjgIvqM0kuOYprNhTVDgGvUYYVhfZTL7ohZnP3H2RibmTIlF+mcDp3uYrETKXa2 2DsrabguCpF0kT9UT3WzWFHRs2XKEloB9TVgufTJx4ic2h/XeEHeGGYrTqa89Mf5SdZ0 YvlJbsciZaVAMmqBt4pW+0IDBfSqu9vY9Zx7HZU/QJbRjAYHhL9p1iG+c0+Ts5RgzjTt YaoPscCOTTCFWwMxptDKidivmX23oxZoA4Kt7lkNiDUdWdinUcWjufkIwkFpgx28c7BL KfuA== X-Forwarded-Encrypted: i=1; AJvYcCW6//TVEBaaJ2/p6n+MOvK6xaBRN33sDFLoV2J7H181jlpXrX79+tjO6KtVA3HewIaUT/LjWw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy78VcqLEJttZbQa8L1tkeAo1dDsCwz51OY+rkw9Udi9/EBJQQg Yt8jD7xqrvD1KG+B1FvfHkmDBsv7fUfIdH3hU078k201mB2B7mVCEqgL1A7CT+ODZjKKQGTNSfr qhif1fJHCNH4ZG2MQzAKRSxaL+Yo= X-Google-Smtp-Source: AGHT+IFuLhJ52AkuNS2mbMI53z5mnYr1/+Z5JC/TO2vqTqXIVmVxtmwoetl2UejZxsLaZ2/vM6llxHaTL1ujqnQw/tY= X-Received: by 2002:a05:6358:4309:b0:1aa:bad6:2ba7 with SMTP id e5c5f4694b2df-1b5c22eaa75mr325703255d.25.1724425813247; Fri, 23 Aug 2024 08:10:13 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290600 Archived-At: --0000000000000a512506205b2cf5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Already disabled. But still glad I experimented. On Fri, Aug 23, 2024 at 11:06=E2=80=AFAM Jo=C3=A3o T=C3=A1vora wrote: > On Fri, Aug 23, 2024 at 3:56=E2=80=AFPM Ship Mints = wrote: > > > > Glad I set project-files-relative-names to t and have been testing. Thi= s > side-effect in Eglot is sure to bite other people who are teased by the > NEWS of this new option, despite not being a defcustom. > > If it's not a defcustom and, as Dmitry said, not meant to be set by the > user, > I suggest you _don't_ set it globally, but ask for it to be let-bound > in whatever > features you want to make use of it. > > Eglot could be one of those features if there's a performance advantage. > But I doubt it, because server-supplied glob expressions may target the > full file name (indeed likely the truename). Maybe it's worth it > nevertheless, > dunno. Anyway while let-binding p-f-r-names to nil in Eglot could work, = I > don't think it's the right solution, especially since it probably trigger= s > a > compilation warning in older Emacsen which don't have this. > > Unrelated, there are other enhancements to Eglot's file-watching > machinery. One of them is about excluding files from over-eager watching > by the server which could eventually bump into OS limits for these > OS objects. > > Jo=C3=A3o T=C3=A1vora > --0000000000000a512506205b2cf5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Already disabled. But still glad I experimented.

On Fri, Aug 23, 20= 24 at 11:06=E2=80=AFAM Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> wrote:
On Fri, Aug 23, 2024 at 3:56=E2=80=AFPM S= hip Mints <ship= mints@gmail.com> wrote:
>
> Glad I set project-files-relative-names to t and have been testing. Th= is side-effect in Eglot is sure to bite other people who are teased by the = NEWS of this new option, despite not being a defcustom.

If it's not a defcustom and, as Dmitry said, not meant to be set by the= user,
I suggest you _don't_ set it globally, but ask for it to be let-bound in whatever
features you want to make use of it.

Eglot could be one of those features if there's a performance advantage= .
But I doubt it, because server-supplied glob expressions may target the
full file name (indeed likely the truename).=C2=A0 Maybe it's worth it = nevertheless,
dunno.=C2=A0 Anyway while let-binding p-f-r-names to nil in Eglot could wor= k, I
don't think it's the right solution, especially since it probably t= riggers a
compilation warning in older Emacsen which don't have this.

Unrelated, there are other enhancements to Eglot's file-watching
machinery.=C2=A0 One of them is about excluding files from over-eager watch= ing
by the server which could eventually bump into OS limits for these
OS objects.

Jo=C3=A3o T=C3=A1vora
--0000000000000a512506205b2cf5--