From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ship Mints Newsgroups: gmane.emacs.bugs Subject: bug#71939: tab-bar `tab-bar-show-inactive-group-tabs' feature request Date: Mon, 29 Jul 2024 15:05:52 -0400 Message-ID: References: <864j95qh7q.fsf@mail.linkov.net> <86wml4rr2y.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000006f1a75061e678dae" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16258"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71939@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 29 21:08:06 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sYVj1-0003xB-Qp for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Jul 2024 21:08:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sYVip-00006g-OV; Mon, 29 Jul 2024 15:07:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sYVin-00006W-6w for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2024 15:07:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sYVim-00069l-Tw for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2024 15:07:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=HH7gGN5mBO+NoEGGNjMNTVAX1qHPLS/z9zzEsErF1vI=; b=Ld1rYX2m4h/ABryKO7FkbDLIArAEkpOSIIpSDGOpmQOyxjFbVmLMHBl6PaEMdtWBvy+pU/e+FdyRBHBMyy7zx6q2I/42u5076gGUC/5gqVMOTXRNvZV4VU1BPaYIT+0QLrtL4A/vbGCO00pFor0HUlKgG5KK1slGYN8e0ZZGp7k3gMqXCAwxJibSEHYfIt8ogaXqJUhnAoeWeO6G8jtP1S0p1MoQXAZ7cbqXDnqmP8sKTOG7q1NCyNCB9yTXBO81iqY24BHBANr0h4QiwMDCHIIu3YntsUESBu2GGhySjK/okeL8XqvZqZYPY7YqiGl7HiodlKjuCvnEYo1KJESxng==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sYViz-0004Dd-V9 for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2024 15:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ship Mints Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jul 2024 19:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71939 X-GNU-PR-Package: emacs Original-Received: via spool by 71939-submit@debbugs.gnu.org id=B71939.172228004616158 (code B ref 71939); Mon, 29 Jul 2024 19:08:01 +0000 Original-Received: (at 71939) by debbugs.gnu.org; 29 Jul 2024 19:07:26 +0000 Original-Received: from localhost ([127.0.0.1]:46355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sYViP-0004CX-TS for submit@debbugs.gnu.org; Mon, 29 Jul 2024 15:07:26 -0400 Original-Received: from mail-oo1-f42.google.com ([209.85.161.42]:56829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sYViM-0004CJ-KG for 71939@debbugs.gnu.org; Mon, 29 Jul 2024 15:07:24 -0400 Original-Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-5d5bb03ff1dso2238737eaf.1 for <71939@debbugs.gnu.org>; Mon, 29 Jul 2024 12:07:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722279964; x=1722884764; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HH7gGN5mBO+NoEGGNjMNTVAX1qHPLS/z9zzEsErF1vI=; b=lQ6acP85LFpzWOq8HXDwVO1l03vNJZxzHqI5y5zT0BBoyEsgSSkTXq7rlZDb0JqqFh a/guJ7YwO9XV+nzT2wy8+xmhCNF5Ikps38A0A8nmIh90n7NEK+THUdkhbBNbV+0nuqnT c5BdfNdo6KKm/W50MhF2r5DOCZ7VyUivNlplWbkUklMv3PuUS706FZWXoXmuFlnsNDFB auhNP2M/DJHhvf0zLkaJ1mck/kuDfj3PU5FrXHXE/lOGwT7ZhUvdWXEGJQEJvyy4gbki QZulb4PgbgIW9ETgAVw1gJ/OOU5d+1XfakIVNeQyEhwC0lbsQjhJnEqxTXscH5B4IHRZ Cs6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722279964; x=1722884764; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HH7gGN5mBO+NoEGGNjMNTVAX1qHPLS/z9zzEsErF1vI=; b=NaDBl1jO3shvWXJx64EnGirjsTl5n4YYgAUypW6HX5h9sqZcxNKNZPb97inlalmN8T ypHy4UkGtjG3Ib+y1zk/yYG1zhZcWCTAEAd1zj4FQ/2Y6QoDHo0V2UDAqCRVIVl1GR1G 5yIhs6gavFBJbz1WHSyUWgafpeOMtev4+Lo4YC3insexS0YAp7WGkPUqbm3VNMwUDvGZ ZRml/lEVM9vcTAMnLOseCV68zr/pImU4Yxa7d5jD7tM+LutKjTXQYndGh8RN4shYiRvQ HahekqeUcCdDDC1MNhldTGCGtq8f0tYFTFupRI/EUMrsk8D9bVrZ/uTUi9l/LfcK364t w6xA== X-Gm-Message-State: AOJu0Yx2OFwfG8aC+m5Vt1Nv2AAcueNPbfZTdS4oQunoSnPkSKF4/UPq yC9uUuDlxEVo5jNBfLse1h88p5lPFZ22PSnsLKz1dm1czU+0f+C+bbcc4YSN/OkBl9/LOyMI2a5 NRX0Y+FmCuzCIn3YcH4eq4q+FJZYzSAMs X-Google-Smtp-Source: AGHT+IHsCVdEK2i6LbayWAn+kBsTFA2DEmV8AaHRhYT6hGJ0bIa9R3YdqAjsDVzxzeM7K544al9nkS5YD0Fq0wtgcwU= X-Received: by 2002:a05:6358:730c:b0:1ac:f323:ea18 with SMTP id e5c5f4694b2df-1adc06641c8mr968708355d.8.1722279963593; Mon, 29 Jul 2024 12:06:03 -0700 (PDT) In-Reply-To: <86wml4rr2y.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289531 Archived-At: --0000000000006f1a75061e678dae Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thank you. In my config, I've also implemented "(setq tab-bar-inhibit-inactive-group-tab-hints t)" which suppresses tab hints on group tabs when inactive groups are being displayed as they are generally superfluous in that case. We could make suppressing tab hints on group tabs when inactive groups are being displayed as the only behavior which is also fine by me. (defun my/tab-bar-tab-group-format-function (tab i &optional current-p) * (let ((tab-bar-tab-hints (if (and tab-bar-show-inactive-group-tabs tab-bar-inhibit-inactive-group-tab-hints) nil tab-bar-tab-hints)))* (concat (propertize my:tab-bar-tab-group-name-prefix 'face (if current-p 'tab-bar-tab-group-current 'tab-bar-tab-group-inactive)) (tab-bar-tab-group-format-default tab i current-p)))) On Mon, Jul 29, 2024 at 2:28=E2=80=AFPM Juri Linkov wrote= : > close 71939 31.0.50 > thanks > > >> I'd like to propose that `tab-bar' allow optionally showing tabs for > >> inactive groups when `tab-bar-format-tabs-groups' is in force rather > than > >> the always-on policy of collapsing inactive groups. > >> > >> The proposed custom variable `tab-bar-show-inactive-group-tabs' is > backward > >> compatible for existing users and has no visible changes for people wh= o > do > >> not set it to t. I will occasionally set the value locally to alter > frame > >> by frame behavior. I've also used a key binding to toggle the behavior > to > >> nice effect. > >> > >> I've been using these changes (via advice :override) under Emacs 29.3. > > > > Thanks for the suggestion. I'll try to adapt this for Emacs 31. > > I adapted this for Emacs 31 and pushed to master. > Thanks for this feature. > --0000000000006f1a75061e678dae Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
<= font face=3D"monospace">Thank you. In my config, I've also implemented = "(setq tab-bar-inhibit-inactive-group-tab-hints t)" which suppres= ses tab hints on group tabs when inactive groups are being displayed as the= y are generally superfluous in that case. We could make suppressing tab hin= ts on group tabs when inactive groups are being displayed as the only behav= ior which is also fine by me.

(defun my/tab-bar-tab-group-format-f= unction (tab i &optional current-p)
=C2=A0 (let ((tab-bar-tab-hin= ts
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(if (and tab-bar-show-inactive-grou= p-tabs
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ta= b-bar-inhibit-inactive-group-tab-hints)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0nil
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0tab-bar-ta= b-hints)))
=C2=A0 =C2=A0 (concat
=C2=A0 =C2=A0 =C2=A0(propertize<= br>=C2=A0 =C2=A0 =C2=A0 my:tab-bar-tab-group-name-prefix
=C2=A0 =C2=A0 = =C2=A0 'face (if current-p 'tab-bar-tab-group-current 'tab-bar-= tab-group-inactive))
=C2=A0 =C2=A0 =C2=A0(tab-bar-tab-group-format-defau= lt tab i current-p))))

<= /font>
On Mon, Jul 29, 2024 at 2:28=E2=80=AFPM Juri Linkov &l= t;juri@linkov.net> wrote:
close 71939 31.0.50
thanks

>> I'd like to propose that `tab-bar' allow optionally showin= g tabs for
>> inactive groups when `tab-bar-format-tabs-groups' is in force = rather than
>> the always-on policy of collapsing inactive groups.
>>
>> The proposed custom variable `tab-bar-show-inactive-group-tabs'= ; is backward
>> compatible for existing users and has no visible changes for peopl= e who do
>> not set it to t. I will occasionally set the value locally to alte= r frame
>> by frame behavior. I've also used a key binding to toggle the = behavior to
>> nice effect.
>>
>> I've been using these changes (via advice :override) under Ema= cs 29.3.
>
> Thanks for the suggestion.=C2=A0 I'll try to adapt this for Emacs = 31.

I adapted this for Emacs 31 and pushed to master.
Thanks for this feature.
--0000000000006f1a75061e678dae--