From: Ship Mints <shipmints@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: 74087@debbugs.gnu.org
Subject: bug#74087: Bug patch: invoke tab-bar-tab-post-open-functions during tabs initialization
Date: Wed, 30 Oct 2024 09:44:02 -0400 [thread overview]
Message-ID: <CAN+1Hbp7EP7uF3piV2EZ7S+U+s+jo3G0YWcgqepj0hsh0woW3A@mail.gmail.com> (raw)
In-Reply-To: <861pzy3fot.fsf@mail.linkov.net>
[-- Attachment #1: Type: text/plain, Size: 833 bytes --]
You're right about tab-bar-tab-pre-close-functions being called
prematurely. There seem to be almost no calls to it in the wild that I
could find. Now is a good time to correct this.
On Tue, Oct 29, 2024 at 2:54 PM Juri Linkov <juri@linkov.net> wrote:
>
> Calling the close hooks currently doesn't look correct:
>
> (run-hook-with-args 'tab-bar-tab-pre-close-functions
> (nth close-index tabs)
> last-tab-p)
> (if last-tab-p
> (pcase tab-bar-close-last-tab-choice
> ('nil
> (user-error "Attempt to delete the sole tab in a frame"))
>
> where first it makes an attempt to close the tab, calls the hook,
> then fails with the user-error. I think the hook should be called
> when the tab is really closed.
>
>
[-- Attachment #2: Type: text/html, Size: 1293 bytes --]
prev parent reply other threads:[~2024-10-30 13:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 14:12 bug#74087: Bug patch: invoke tab-bar-tab-post-open-functions during tabs initialization Ship Mints
2024-10-29 18:13 ` Juri Linkov
2024-10-29 18:19 ` Ship Mints
2024-10-29 18:29 ` Ship Mints
2024-10-29 18:43 ` Ship Mints
2024-10-29 18:52 ` Juri Linkov
2024-10-29 19:03 ` Ship Mints
2024-10-29 19:07 ` Juri Linkov
2024-10-29 19:18 ` Ship Mints
2024-10-29 19:23 ` Ship Mints
2024-10-29 19:32 ` Ship Mints
2024-10-29 19:46 ` Juri Linkov
2024-10-29 20:04 ` Ship Mints
2024-10-29 20:05 ` Ship Mints
2024-10-30 7:24 ` Juri Linkov
2024-10-30 12:41 ` Ship Mints
2024-10-30 13:44 ` Ship Mints [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN+1Hbp7EP7uF3piV2EZ7S+U+s+jo3G0YWcgqepj0hsh0woW3A@mail.gmail.com \
--to=shipmints@gmail.com \
--cc=74087@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.