all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ship Mints <shipmints@gmail.com>
To: 74087@debbugs.gnu.org, juri@linkov.net
Subject: bug#74087: Bug patch: invoke tab-bar-tab-post-open-functions during tabs initialization
Date: Tue, 29 Oct 2024 10:12:38 -0400	[thread overview]
Message-ID: <CAN+1HboJ79GJRj+W-QP1Z3yUgOUjD5r3cwgfm7Vy5wSgYptmBQ@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 415 bytes --]

Greetings,

tab-bar-tab-post-open-functions need to be called during tab-bar
initialization. Currently, a user's custom post-open functions are invoked
only for tabs created beyond the initial tab. This is a bug, in my view.

I've created the patch vs. this morning's master and should also benefit
Emacs 30. I've been running a patched copy against my daily-use 29.4 for a
bit and it works as expected.

-Stephane

[-- Attachment #1.2: Type: text/html, Size: 902 bytes --]

[-- Attachment #2: 0001-Call-tab-bar-tab-post-open-functions-during-tabs-ini.patch --]
[-- Type: application/octet-stream, Size: 892 bytes --]

From 61a801eedb10d3d0dac5cf8b57c6b3641a6d226d Mon Sep 17 00:00:00 2001
From: shipmints <shipmints@gmail.com>
Date: Tue, 29 Oct 2024 09:56:15 -0400
Subject: [PATCH] Call tab-bar-tab-post-open-functions during tabs
 initialization

---
 lisp/tab-bar.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el
index 2efc2b8f85b..7fc04ab3c32 100644
--- a/lisp/tab-bar.el
+++ b/lisp/tab-bar.el
@@ -803,7 +803,9 @@ Return its existing value or a new value."
                   (funcall tab-bar-tab-name-function))))
       ;; Create default tabs
       (setq tabs (list (tab-bar--current-tab-make)))
-      (tab-bar-tabs-set tabs frame))
+      (tab-bar-tabs-set tabs frame)
+      (run-hook-with-args 'tab-bar-tab-post-open-functions
+                          (car tabs)))
     tabs))
 
 (defun tab-bar-tabs-set (tabs &optional frame)
-- 
2.47.0


             reply	other threads:[~2024-10-29 14:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-29 14:12 Ship Mints [this message]
2024-10-29 18:13 ` bug#74087: Bug patch: invoke tab-bar-tab-post-open-functions during tabs initialization Juri Linkov
2024-10-29 18:19   ` Ship Mints
2024-10-29 18:29     ` Ship Mints
2024-10-29 18:43       ` Ship Mints
2024-10-29 18:52       ` Juri Linkov
2024-10-29 19:03         ` Ship Mints
2024-10-29 19:07           ` Juri Linkov
2024-10-29 19:18             ` Ship Mints
2024-10-29 19:23               ` Ship Mints
2024-10-29 19:32                 ` Ship Mints
2024-10-29 19:46                   ` Juri Linkov
2024-10-29 20:04                     ` Ship Mints
2024-10-29 20:05                       ` Ship Mints
2024-10-30  7:24                         ` Juri Linkov
2024-10-30 12:41                           ` Ship Mints
2024-10-30 13:44         ` Ship Mints

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAN+1HboJ79GJRj+W-QP1Z3yUgOUjD5r3cwgfm7Vy5wSgYptmBQ@mail.gmail.com \
    --to=shipmints@gmail.com \
    --cc=74087@debbugs.gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.