From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Hackney Newsgroups: gmane.emacs.devel Subject: Re: package.el changes before the feature freeze Date: Sun, 30 Sep 2012 19:50:16 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1349049046 20069 80.91.229.3 (30 Sep 2012 23:50:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 30 Sep 2012 23:50:46 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 01 01:50:52 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TITHb-0002XS-R7 for ged-emacs-devel@m.gmane.org; Mon, 01 Oct 2012 01:50:47 +0200 Original-Received: from localhost ([::1]:37328 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TITHW-00047a-Ct for ged-emacs-devel@m.gmane.org; Sun, 30 Sep 2012 19:50:42 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TITHT-00047S-U7 for emacs-devel@gnu.org; Sun, 30 Sep 2012 19:50:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TITHT-0003UA-0a for emacs-devel@gnu.org; Sun, 30 Sep 2012 19:50:39 -0400 Original-Received: from mail-qc0-f169.google.com ([209.85.216.169]:64508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TITHS-0003U3-PU for emacs-devel@gnu.org; Sun, 30 Sep 2012 19:50:38 -0400 Original-Received: by qcqt2 with SMTP id t2so5192894qcq.0 for ; Sun, 30 Sep 2012 16:50:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=haxney.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=ZcQy3eUj/SFY5EDGP9qq+rF+SpCYX97YtzbPvDMbwaE=; b=gIUwQLkCEF2Rjc1w8dDkK3YNh52SK3Iks+UPbqbE7j9JpUPJCdq++CsCxscf5ogAvF bVpZkki6i8fS2g0HRGJufITVhHOcV5FEG1iV+gg5kecySyAgyyhv+ZQxOsPHFbjmdIen R2Sq6RYV5duzV9yWxOT0fC0BWa2FJWtZAn0p4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-gm-message-state; bh=ZcQy3eUj/SFY5EDGP9qq+rF+SpCYX97YtzbPvDMbwaE=; b=kUV9M0QtTHA1B5rJ4uM1FvxnJFYDpaue3qw3JIwMBAm0CcI57LrjZUXqRMd+CyTuw7 JnA7n844NOn37pf8umAG+AvtbWoy4FMHNZxTaH5gg3Rbyl/l+nJMv2tjqsmfCUHth/hw zPx9cicpvJVNwVu0Etn/ilZMx3Q1nomwZH+rHqlh6pbiguMNZI3OQZkKpdtkk8r+yG5U csrG+FZeD266RcPVO3gmq4m/ySRhmkAMCLZZBcYU/dDsPvfqlMiDGJ7ODu4EFOnv48HW FFeBK0gr7JxIV+xm+ULYL5sxvC8t9s1/eqhugJjJVudMQKmvjjArppej0lcPKsw+dM1K uzsQ== Original-Received: by 10.224.193.72 with SMTP id dt8mr33209047qab.24.1349049036750; Sun, 30 Sep 2012 16:50:36 -0700 (PDT) Original-Received: by 10.229.63.229 with HTTP; Sun, 30 Sep 2012 16:50:16 -0700 (PDT) In-Reply-To: X-Gm-Message-State: ALoCoQn9kKBp+M7RasEuN5DtklKqCOzQCFonfBUiChc8PPnnYQz2fhaz0HTzMawP998fr4wz7mcR X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.216.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153786 Archived-At: Stefan Monnier wrote: >> base (using `defstruct' for package descriptors instead of the variety > > Before I look any closer, can you please change your code to use > `cl-lib' instead of `cl' (this mostly means you'll need to add a "cl-" > prefix to all the CL macros and functions you use). Sure thing. I've been developing this under 24.2 and so didn't have access to those libraries. > Also, please send your change as a patch so it's easier to see > what's changed. I can do that for the package.el code I have now. From my basic manual tests, things seem to work out alright and I have been careful to ensure that it can handle all of the existing formats without modification. It utilizes the same "archive-contents" and "foo-pkg.el" files as the current version. I can make the cl => cl-lib conversion and patchify the result. Is it okay to submit a patch whose stability I cannot guarantee? I'd hate to ruin someone's day if they are relying on the dev branch for day-to-day work. -- Daniel Hackney