From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Hackney Newsgroups: gmane.emacs.devel Subject: Re: package.el changes before the feature freeze Date: Tue, 2 Oct 2012 20:33:03 -0400 Message-ID: References: <87ipau51jh.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1349224451 29772 80.91.229.3 (3 Oct 2012 00:34:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Oct 2012 00:34:11 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 03 02:34:13 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TJCu9-0005as-Nu for ged-emacs-devel@m.gmane.org; Wed, 03 Oct 2012 02:33:37 +0200 Original-Received: from localhost ([::1]:44332 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJCu1-0002vJ-MR for ged-emacs-devel@m.gmane.org; Tue, 02 Oct 2012 20:33:29 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJCtz-0002v3-0t for emacs-devel@gnu.org; Tue, 02 Oct 2012 20:33:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJCtx-0001sQ-Pa for emacs-devel@gnu.org; Tue, 02 Oct 2012 20:33:26 -0400 Original-Received: from mail-ie0-f169.google.com ([209.85.223.169]:62675) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJCtx-0001s7-GG for emacs-devel@gnu.org; Tue, 02 Oct 2012 20:33:25 -0400 Original-Received: by ied10 with SMTP id 10so18272475ied.0 for ; Tue, 02 Oct 2012 17:33:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=haxney.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=/sdwSSZHLMMpWgTSE+gTPd+g9g0zneCd+bjban/rJaE=; b=VPuKLETNtToeHEjmSBD/JJuBM3vcXWui/iO5YPOetIJE6wmNm382DYpa8jZJ2kBasi MbSpBJ+DVblAN1BeoR75HYw6CFFINRHu0yhvpnUXDfvosl7rv5J3iIbXLFrjLpsVGPW7 GwCRKhdAqFPxPHgIA7kL61DUm/vM4a1G+tIyM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-gm-message-state; bh=/sdwSSZHLMMpWgTSE+gTPd+g9g0zneCd+bjban/rJaE=; b=MFrOAAm6yah2Su1azVdGVAhHqS7or+m2g93EcBERwtoQlFi48mWICpMoxv08dIyAQ+ 4GMQxrDTqzBTRAPtmn5Gb6GaufNuTU3d/6GEurHP6mKoCb4aoQrNQNPelS/h8zL3M1lh U1qHg2NuTv70FK5AEcLvl4+twEaS29KMMweYMdn5+MzmOe8r/DAL3tMTr97ur9wLqHHd h/1kuRrjwkoiu+ncrBUZWPl0H22PUra69PfhWC0VxlGHWCOWHGAlyfnfveEW5xZEYBeI VCE324LBM7sB6TbSydmeP0OAiM9bV98CJzgEHj/vBs6IZifqA+84AbgF29uMMVH4Z5O1 ZEZA== Original-Received: by 10.42.33.133 with SMTP id i5mr236936icd.55.1349224403627; Tue, 02 Oct 2012 17:33:23 -0700 (PDT) Original-Received: by 10.64.101.197 with HTTP; Tue, 2 Oct 2012 17:33:03 -0700 (PDT) In-Reply-To: <87ipau51jh.fsf@gnu.org> X-Gm-Message-State: ALoCoQlIRYUgNWxBMvGkxw+x3z8QINuzwlt+icKOmi0spHXTESjyA3w0yFXf92Lgd5oYSpuh9yMd X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.223.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153967 Archived-At: Chong Yidong wrote: > Daniel Hackney writes: > >> Not all of those features will be done soon, but much of the >> refactored base (using `defstruct' for package descriptors instead of >> the variety of `cons'ed vectors) is in place. Could I get a few extra >> days to get this tested? > > How much time are you asking for? I'm wary of big changes to package.el > (where backward incompatibilities can cause huge headaches) coming out > of the blue right before a feature freeze. I'll try to have it done by the end of the week. If I don't have something stable enough to pull by Sunday (at the latest), go on ahead without me. I hadn't been following the mailing list closely, so I didn't find out about the feature freeze until just before I sent the email. > I took a look at your code, but the changes are too pervasive to easily > review, and trying to load the code caused M-x list-packages to spin for > a long time followed by > > Debugger entered--Lisp error: (void-function cl-adjoin) > cl-adjoin(((debbugs 0 3) "installed" "SOAP library to access debbugs servers") nil :key car) > package-menu--generate(nil t) > list-packages(nil) > call-interactively(list-packages record nil) Weird. I'll take a look at that now. > I have the debbugs library installed, so I'm guessing your changes screw > up existing package installations somehow. I tried to avoid having my change mess with that, but I'll check on the latest dev version. > Have you altered the on-disk > format of installed packages (such as directory layout, the contents of > archive-contents, etc.)? If so, I don't think it's suitable for 24.3. Nope. All of the on-disk stuff is the same. I knew that on-disk changes would be too invasive and so left the externally-facing stuff untouched. Apparently I didn't do so well enough. > Maybe you should split off some of the smaller parts of your altered > package.el and commit those separately, saving the rest for post-24.3. The essence of the change was unifying the types used. Right now, the package description floats through the program in a couple different formats which I thought could be combined into one. -- Daniel Hackney