From: Daniel Hackney <dan@haxney.org>
To: Chong Yidong <cyd@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: package.el changes before the feature freeze
Date: Tue, 2 Oct 2012 20:33:03 -0400 [thread overview]
Message-ID: <CAMqXDZuX8f0kXGEL42EsHNbsqGsp90Hb1Miq0PMrgUNXYkEooQ@mail.gmail.com> (raw)
In-Reply-To: <87ipau51jh.fsf@gnu.org>
Chong Yidong <cyd@gnu.org> wrote:
> Daniel Hackney <dan@haxney.org> writes:
>
>> Not all of those features will be done soon, but much of the
>> refactored base (using `defstruct' for package descriptors instead of
>> the variety of `cons'ed vectors) is in place. Could I get a few extra
>> days to get this tested?
>
> How much time are you asking for? I'm wary of big changes to package.el
> (where backward incompatibilities can cause huge headaches) coming out
> of the blue right before a feature freeze.
I'll try to have it done by the end of the week. If I don't have
something stable enough to pull by Sunday (at the latest), go on ahead
without me. I hadn't been following the mailing list closely, so I
didn't find out about the feature freeze until just before I sent the
email.
> I took a look at your code, but the changes are too pervasive to easily
> review, and trying to load the code caused M-x list-packages to spin for
> a long time followed by
>
> Debugger entered--Lisp error: (void-function cl-adjoin)
> cl-adjoin(((debbugs 0 3) "installed" "SOAP library to access debbugs servers") nil :key car)
> package-menu--generate(nil t)
> list-packages(nil)
> call-interactively(list-packages record nil)
Weird. I'll take a look at that now.
> I have the debbugs library installed, so I'm guessing your changes screw
> up existing package installations somehow.
I tried to avoid having my change mess with that, but I'll check on the
latest dev version.
> Have you altered the on-disk
> format of installed packages (such as directory layout, the contents of
> archive-contents, etc.)? If so, I don't think it's suitable for 24.3.
Nope. All of the on-disk stuff is the same. I knew that on-disk changes
would be too invasive and so left the externally-facing stuff untouched.
Apparently I didn't do so well enough.
> Maybe you should split off some of the smaller parts of your altered
> package.el and commit those separately, saving the rest for post-24.3.
The essence of the change was unifying the types used. Right now, the
package description floats through the program in a couple different
formats which I thought could be combined into one.
--
Daniel Hackney
next prev parent reply other threads:[~2012-10-03 0:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-30 16:58 package.el changes before the feature freeze Daniel Hackney
2012-09-30 20:21 ` Stefan Monnier
2012-09-30 23:50 ` Daniel Hackney
2012-10-01 1:21 ` Stefan Monnier
2012-10-01 3:11 ` Chong Yidong
2012-10-03 0:33 ` Daniel Hackney [this message]
2012-10-03 22:41 ` [PATCH] " Daniel Hackney
2012-10-04 8:16 ` Chong Yidong
2012-10-05 23:13 ` Daniel Hackney
2012-10-06 1:38 ` Stefan Monnier
2012-10-08 2:32 ` Chong Yidong
2012-10-08 19:16 ` Daniel Hackney
2012-10-08 19:50 ` Stefan Monnier
2012-10-09 1:11 ` Daniel Hackney
2012-10-09 6:48 ` Stefan Monnier
2012-10-09 17:07 ` Daniel Hackney
2012-10-09 17:39 ` Stefan Monnier
2012-10-09 21:39 ` Daniel Hackney
2012-10-09 22:25 ` Glenn Morris
2012-10-12 3:58 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMqXDZuX8f0kXGEL42EsHNbsqGsp90Hb1Miq0PMrgUNXYkEooQ@mail.gmail.com \
--to=dan@haxney.org \
--cc=cyd@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.