From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Hackney Newsgroups: gmane.emacs.devel Subject: Re: cl-defstruct-based package.el, now with ert tests! Date: Tue, 12 Mar 2013 12:25:20 -0400 Message-ID: References: <87mwu9l6ju.fsf@fleche.redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1363105559 32059 80.91.229.3 (12 Mar 2013 16:25:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Mar 2013 16:25:59 +0000 (UTC) Cc: Emacs development discussions To: Tom Tromey Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 12 17:26:24 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UFS1u-00041D-2O for ged-emacs-devel@m.gmane.org; Tue, 12 Mar 2013 17:26:22 +0100 Original-Received: from localhost ([::1]:39084 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFS1X-0006su-Nq for ged-emacs-devel@m.gmane.org; Tue, 12 Mar 2013 12:25:59 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFS1M-0006aU-Uo for emacs-devel@gnu.org; Tue, 12 Mar 2013 12:25:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFS1G-0008BF-TI for emacs-devel@gnu.org; Tue, 12 Mar 2013 12:25:48 -0400 Original-Received: from mail-ia0-x22f.google.com ([2607:f8b0:4001:c02::22f]:48750) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFS1G-0008Af-By for emacs-devel@gnu.org; Tue, 12 Mar 2013 12:25:42 -0400 Original-Received: by mail-ia0-f175.google.com with SMTP id y26so16824iab.34 for ; Tue, 12 Mar 2013 09:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=haxney.org; s=google; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=JCiO19dpCnMpf3RaaoPgqgEpVzgQ3k/MMi5Zfi70goU=; b=dxFb59mv5Ons09rxc3WuCbE5mmb3egeN0f3YsPqRvhe2YppZQOh8/0uP9FDrmXJGxh br9OZ2cXsW+lACUf6hm9dY0Y70KBX2i3EsaU2UKm921OcQyKaaA7T683bqwheafnAz1W SCzf5ibzRkjRpJuCjmmtgs+9jDcNnNDV6UAeY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type:x-gm-message-state; bh=JCiO19dpCnMpf3RaaoPgqgEpVzgQ3k/MMi5Zfi70goU=; b=LeCLkHRquUDcGr1RdZybwEwmRYG75Qr3sjEB2hkh5hn9ffWU056pBfRT7vUs0VTO1b N9anKfpUNbz2ImJhdMQ7roeFgGJX9h8CQ5/GV11aQUoQ4bfJyTTT8UJ0tCUzKU9LqEbz gM6+pK/wfhIBxnxGeyUfwC7B7ZZE2Kn6WdEo4+dstg7SBJ3AdNFFGi2FDfHybHFFYwMi jFyNoUI6lJMazbshIkSV5K+BC+tgze4hKAmyTKWep1dutmoi1wsW8wDd8RIiUUhOx7bE NvyvzClOfzbgahIW2bxo+6IxjwJFXtdyknGRiY0fYJKiZY8Pp7S1exE7msl8P0/gEa0j F3oQ== X-Received: by 10.50.119.67 with SMTP id ks3mr1586942igb.90.1363105540159; Tue, 12 Mar 2013 09:25:40 -0700 (PDT) Original-Received: by 10.64.54.39 with HTTP; Tue, 12 Mar 2013 09:25:20 -0700 (PDT) In-Reply-To: <87mwu9l6ju.fsf@fleche.redhat.com> X-Gm-Message-State: ALoCoQkdJPMIzTIHhISRE8WsvoF7cPgmkEd/dDa3ZL70BLZSwLMNNiYh453SCccrVauDxo+ySd9T X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4001:c02::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:157782 Archived-At: Tom Tromey wrote: > Daniel> The changes touch most of the code, but the overall structure of the > Daniel> code has not changed significantly. Some parts of the code which were > Daniel> questionable in the first place (such as using `tar-mode' to extract tar > Daniel> archives) have been replaced with simpler alternatives. In the case of > Daniel> tar, the file is simply downloaded to a temporary directory and > Daniel> extracted using "tar xaf foo-1.2.3.tar". > > This sounds worse to me, since it means that now package installation > has an external dependency. Previously this was not the case -- > intentionally. The current package.el does use tar, in `package-tar-file-info', which is called from `package-install-file'. It is used to extract the "foo-pkg.el" file from the archive. People may not have run into this if they didn't use `package-install-file'. I can revert this change and use Emacs's `tar-mode' if people like. On a related note, is there a way to un-gzip buffers without needing the external gzip program? I'd like to be able to use gzipped tarballs for package distribution; it seems strange to be sending around uncompressed tar files. Are there any other suggestions before it can be committed to the trunk? -- Daniel Hackney