From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Hackney Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: package.el changes before the feature freeze Date: Tue, 9 Oct 2012 13:07:08 -0400 Message-ID: References: <87ipau51jh.fsf@gnu.org> <87626qk5xo.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1349802468 23824 80.91.229.3 (9 Oct 2012 17:07:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 9 Oct 2012 17:07:48 +0000 (UTC) Cc: Chong Yidong , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 09 19:07:54 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TLdHd-0004LA-2s for ged-emacs-devel@m.gmane.org; Tue, 09 Oct 2012 19:07:53 +0200 Original-Received: from localhost ([::1]:57146 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLdHW-0006ol-Rk for ged-emacs-devel@m.gmane.org; Tue, 09 Oct 2012 13:07:46 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLdHQ-0006lG-Pi for emacs-devel@gnu.org; Tue, 09 Oct 2012 13:07:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLdHG-0005ha-38 for emacs-devel@gnu.org; Tue, 09 Oct 2012 13:07:40 -0400 Original-Received: from mail-ie0-f169.google.com ([209.85.223.169]:53016) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLdHF-0005hM-SB for emacs-devel@gnu.org; Tue, 09 Oct 2012 13:07:30 -0400 Original-Received: by mail-ie0-f169.google.com with SMTP id 10so14512747ied.0 for ; Tue, 09 Oct 2012 10:07:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=haxney.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=FKdbE/S9BelLRAFqi17LuiwSoTc04+nRDAMzrRCqlxA=; b=uhTiEjCpkGTMcPun3vej3XovBegTYckhWgyunLUNCujhp3sR1wj+hZGP5q+mGsez67 9FLXWyjD+pC63NjvG6FcuAx3qZwAuDAnpuV4BuB97qJS+qq5l9J3WDfUYLfbSAQ0Aec8 HkuM+ilXGouSJr2zV4kmH0BCeyJPqq7Krlo7I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-gm-message-state; bh=FKdbE/S9BelLRAFqi17LuiwSoTc04+nRDAMzrRCqlxA=; b=KVNzCwxVlSF+6G0GzuqjvXCtPXMcGBArWt37Ku+bkkgP6HibzHU1ozS9MP07rp/SFt fqWr4Uf2LNYOUvQlbwh24szK5kumxQqlQe0ESJrN4QAWwn7DuzJo27HN51ifvRjVc+xq zlPCyxVGMvbmszS8jAcqxQ/6DjwK7A8QX4gZw+/NIT/qiIkwEB5B4htAwhC5ICiwEa9F cWwxfMwmrCRnrS2Wj33/W9rIcolrlENRbsbkwBEZ4GwC38MNjARHHuvTQJvlTQUGe9/h hRxvP0MYrudPnBwYCSLECt3uUFrxV9qs71H2IvxPWYsOV7OWBXOYFbXyjizuCgRe4MHm vJyg== Original-Received: by 10.42.22.131 with SMTP id o3mr4168618icb.55.1349802448647; Tue, 09 Oct 2012 10:07:28 -0700 (PDT) Original-Received: by 10.64.101.197 with HTTP; Tue, 9 Oct 2012 10:07:08 -0700 (PDT) In-Reply-To: X-Gm-Message-State: ALoCoQk4k2Ql+E6WhBBqs3TsLYTyhTg34/F+bLMXQxoTQv6Hc5fChv4yNhsh/UbDluVjtIYm0ShL X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.223.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:154260 Archived-At: Stefan Monnier wrote: > Are there particular reasons why you think it would be important to > install your changes for 24.3? It certainly isn't pressing, but it would make future development (bugfixing, etc) easier. Pedantically speaking, however, my patch doesn't change any user-facing features. There are some potential bugs, such as deleting obsolete packages correctly, which I think could reasonably be considered "bug fixes" rather than "features" and correcting those would be much easier using my `defstruct'd code (and the associated test cases). Updating packages cleanly is currently bugged; Emacs still expects the docstrings to be at the old location, but if it is deleted (which is what `package-menu-mark-upgrades' offers to do), you will get "could not find docstring" errors which break certain commands. The fix is non-trivial (it involves messing with `load-history') and my changes will simplify that process. -- Daniel Hackney