From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Hackney Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: package.el changes before the feature freeze Date: Tue, 9 Oct 2012 17:39:00 -0400 Message-ID: References: <87ipau51jh.fsf@gnu.org> <87626qk5xo.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1349818767 14731 80.91.229.3 (9 Oct 2012 21:39:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 9 Oct 2012 21:39:27 +0000 (UTC) Cc: Chong Yidong , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 09 23:39:33 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TLhWW-0000gJ-MO for ged-emacs-devel@m.gmane.org; Tue, 09 Oct 2012 23:39:32 +0200 Original-Received: from localhost ([::1]:45046 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLhWQ-0000j7-Hj for ged-emacs-devel@m.gmane.org; Tue, 09 Oct 2012 17:39:26 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLhWN-0000hv-ED for emacs-devel@gnu.org; Tue, 09 Oct 2012 17:39:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLhWM-0000Y6-7u for emacs-devel@gnu.org; Tue, 09 Oct 2012 17:39:23 -0400 Original-Received: from mail-ie0-f169.google.com ([209.85.223.169]:47231) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLhWL-0000XU-Vi for emacs-devel@gnu.org; Tue, 09 Oct 2012 17:39:22 -0400 Original-Received: by mail-ie0-f169.google.com with SMTP id 10so15150317ied.0 for ; Tue, 09 Oct 2012 14:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=haxney.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=kVicpogdzWSIP5mNvRRFiOX0WduzYYbxKzSev7GQogM=; b=DTn+OdA3hmjgAHeEUAJYJexHpUQSGQsfI6vFmuAxO/Fw+9JBau+H/nsob3dtdOkSGY 9l9tbMVwlnRanwVYMmVAysQHjh93jn5R4ZxQJoAarEjkVZ6l1nv3z23XnLVKBAm0mSo0 8jUi22SuvAcVIu2vedHnBAO9/mBBXyo8WnlwY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-gm-message-state; bh=kVicpogdzWSIP5mNvRRFiOX0WduzYYbxKzSev7GQogM=; b=EzVcFwfdEUGuNblXDMdzk7YZlF6tW+9CEppYQnf74ReyKcNxPSngfJv6Sc+91Aa9aH KcKorO0luKxxkVqlT0IS2g3LcX/OZ2gN5cftBUK85NI7A/cSaY6824Vz1jRpo9G8WLEi U4vXmBYAxoJBlLHKIEzrS9UBy+Qm4j60KnGBEzgcGoTMxsHxS4cSJ3ERZ/GhYrqfb3ii L24AlBUwscZro2afi1o4VRNTytInR5DFRVBBEerT7H4vvHbkVJy2D6E9/YgE7FWcWrVd GFqJ+sa3Bipll3DMYO1GRGiO6QzAxrlx4LZcO6cOa8uGf1t9ZShhxTsgRle7CetbqTX4 ttbA== Original-Received: by 10.43.9.3 with SMTP id ou3mr16672094icb.14.1349818760966; Tue, 09 Oct 2012 14:39:20 -0700 (PDT) Original-Received: by 10.64.101.197 with HTTP; Tue, 9 Oct 2012 14:39:00 -0700 (PDT) In-Reply-To: X-Gm-Message-State: ALoCoQkLWMghvBXBDDDF+ODtCrJ/3RbM9npB+imIX55qTfsZHWf54wQZdJWLLBisPijFhE8sSFKE X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.223.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:154263 Archived-At: Stefan Monnier wrote: >> the associated test cases). Updating packages cleanly is currently >> bugged; Emacs still expects the docstrings to be at the old location, >> but if it is deleted (which is what `package-menu-mark-upgrades' offers >> to do), you will get "could not find docstring" errors which break >> certain commands. > > The general rule is that failure to find the docstring should not > break commands. I've fixed a few such cases recently, but if you find > more, please report them. Even without package.el the file might > disappear or be replaced and that's usually no justification to break the > whole command (e.g. describe-function/variable is still useful even if the > docstring is not found). The only case in which I have experienced problems from an updated package is with the package "helm" which is not in the Emacs core. I could try to track down the problem and solve it within the helm library. I'll report back here if I find anything which looks like a core Emacs bug. I also remember having some trouble with installing or resuming an aborted install and getting "file exists" errors. I'd have to dig a little to remember what exactly was happening; if I find anything I'll start a new thread about it. But the main point is: I think we would be well-served by pulling these changes into 24.3 because it does not affect the user interface at all and is therefore not going against the idea of a feature freeze, cleans up the namespace by removing `define-package', and will make debugging package.el for the release of 24.3 easier by using consistent variable names and types throughout the library. -- Daniel Hackney