bug#28889: 26.0.90; TRAMP and custom file location

bug#28889: 26.0.90; TRAMP and custom file location

[Davor Rotim]

[-- Attachment #1: Type: text/plain, Size: 5786 bytes --]

Consider the following init file:

;; Begin
(package-initialize)
(add-to-list 'package-archives
             '("melpa" . "https://melpa.org/packages/"))


(unless (package-installed-p 'use-package)
  (package-refresh-contents)
  (package-install 'use-package))


(eval-when-compile
  (require 'use-package))


(use-package slime
  :ensure t)

(setq custom-file "~/.emacs.d/custom.el")
(load custom-file 'noerror)
;; End

This will produce a following custom.el file:

(custom-set-variables
 ;; custom-set-variables was added by Custom.
 ;; If you edit it by hand, you could mess it up, so be careful.
 ;; Your init file should contain only one such instance.
 ;; If there is more than one, they won't work right.
 '(package-selected-packages (quote (slime use-package)))
 '(tramp-syntax (quote default) nil (tramp)))
(custom-set-faces
 ;; custom-set-faces was added by Custom.
 ;; If you edit it by hand, you could mess it up, so be careful.
 ;; Your init file should contain only one such instance.
 ;; If there is more than one, they won't work right.
 )

For some reason the tramp-syntax line gets added which causes TRAMP to load
at startup,
this didn't happen with GNU Emacs 25.3 and it slows down startup while it
gets loaded unnecessarily.
This only happens if I specify a custom-file location, if those two last
lines are deleted then
the TRAMP line doesn't get added to the init file:

;; Begin
 (package-initialize)
(add-to-list 'package-archives
             '("melpa" . "https://melpa.org/packages/"))


(unless (package-installed-p 'use-package)
  (package-refresh-contents)
  (package-install 'use-package))


(eval-when-compile
  (require 'use-package))


(use-package slime
  :ensure t)
(custom-set-variables
 ;; custom-set-variables was added by Custom.
 ;; If you edit it by hand, you could mess it up, so be careful.
 ;; Your init file should contain only one such instance.
 ;; If there is more than one, they won't work right.
 '(package-selected-packages (quote (slime use-package)))
 '(tramp-syntax (quote default) nil (tramp)))
(custom-set-faces
 ;; custom-set-faces was added by Custom.
 ;; If you edit it by hand, you could mess it up, so be careful.
 ;; Your init file should contain only one such instance.
 ;; If there is more than one, they won't work right.
 )
;; End

So far this happens only with SLIME and Cider packages.

In GNU Emacs 26.0.90 (build 1, i686-pc-linux-gnu, GTK+ Version 3.22.24)
 of 2017-10-13 built on lambda
Windowing system distributor 'The X.Org Foundation', version 11.0.11905000
System Description:    Debian GNU/Linux unstable (sid)

Recent messages:
Loading /home/drot/.emacs.d/custom.el (source)...
Loading tramp...done
Loading /home/drot/.emacs.d/custom.el (source)...done
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure 'CFLAGS=-march=native -O2 -pipe -fstack-protector-strong'
 --prefix=/home/drot/.local
 '--program-transform-name=s/^ctags$/ctags.emacs/''

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY
ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 LIBSYSTEMD LCMS2

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Fundamental

Minor modes in effect:
  shell-dirtrack-mode: t
  override-global-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg gnus-util rmail rmail-loaddefs
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils
mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr
mail-utils leuven-theme time-date elec-pair tramp tramp-compat
tramp-loaddefs trampver ucs-normalize shell pcomplete parse-time
format-spec advice cus-start cus-load slime compile etags xref project
arc-mode archive-mode noutline outline pp comint ansi-color ring
hyperspec thingatpt browse-url use-package diminish bind-key easy-mmode
finder-inf info slime-autoloads package easymenu epg-config url-handlers
url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache url-vars seq byte-opt gv bytecomp byte-compile cconv
cl-loaddefs cl-lib mule-util tooltip eldoc electric uniquify ediff-hook
vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core term/tty-colors frame cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting move-toolbar gtk
x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 8 266033 12419)
 (symbols 24 27060 1)
 (miscs 20 115 100)
 (strings 16 51982 2324)
 (string-bytes 1 1352983)
 (vectors 8 44214)
 (vector-slots 4 834834 14348)
 (floats 8 107 14)
 (intervals 28 261 0)
 (buffers 528 12))

[-- Attachment #2: Type: text/html, Size: 6845 bytes --]

bug#28889: 26.0.90; TRAMP and custom file location

[Davor Rotim]

[-- Attachment #1: Type: text/plain, Size: 656 bytes --]

Forgot to mention that this problem occurs even without use-package usage.
The problem still persists even with the following init file:

;; Begin
(package-initialize)
(add-to-list 'package-archives
             '("melpa" . "https://melpa.org/packages/"))

(defun require-package (package)
  "Ensures that PACKAGE is installed."
  (unless (or (package-installed-p package)
              (require package nil 'noerror))
    (unless (assoc package package-archive-contents)
      (package-refresh-contents))
    (package-install package)))

(require-package 'slime)

(setq custom-file (locate-user-emacs-file "custom.el"))
(load custom-file 'noerror)
;; End

[-- Attachment #2: Type: text/html, Size: 936 bytes --]

bug#28889: 26.0.90; TRAMP and custom file location

[Michael Albinus]

Davor Rotim <rotim.davor@gmail.com> writes:

Hi Davor,

> This will produce a following custom.el file:
>
> (custom-set-variables
>  ;; custom-set-variables was added by Custom.
>  ;; If you edit it by hand, you could mess it up, so be careful.
>  ;; Your init file should contain only one such instance.
>  ;; If there is more than one, they won't work right.
>  '(package-selected-packages (quote (slime use-package)))
>  '(tramp-syntax (quote default) nil (tramp)))
> (custom-set-faces
>  ;; custom-set-faces was added by Custom.
>  ;; If you edit it by hand, you could mess it up, so be careful.
>  ;; Your init file should contain only one such instance.
>  ;; If there is more than one, they won't work right.
>  )
>
> For some reason the tramp-syntax line gets added which causes TRAMP to
> load at startup,
> this didn't happen with GNU Emacs 25.3 and it slows down startup while
> it gets loaded unnecessarily.

I've committed a patch to the emacs-26 branch, which ought to fix
this. Could you pls check?

Since autoloads are changed, it might be necessary to call 'make -C lisp
autoloads' prior to the usual 'make' call.

It would also be helpful if somebody could test whether Tramp still
works proper for MS Windows; I have no chance to test this myself.

Best regards, Michael.

bug#28889: 26.0.90; TRAMP and custom file location

[Davor Rotim]

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

Hello,

I've committed a patch to the emacs-26 branch, which ought to fix
> this. Could you pls check?
>
> Since autoloads are changed, it might be necessary to call 'make -C lisp
> autoloads' prior to the usual 'make' call.
>

I've made a fresh clone of the emacs-26 branch today and built it.
Last commit on the branch was: "3aee7be Avoid unnecessary rounding errors
in timestamps"
The issue still seems to persist (with or without make autoloads before
running make).

Thank you for your efforts,

Davor Rotim

[-- Attachment #2: Type: text/html, Size: 826 bytes --]

bug#28889: 26.0.90; TRAMP and custom file location

[Michael Albinus]

Davor Rotim <rotim.davor@gmail.com> writes:

> Hello,

Hi Davor,

> I've made a fresh clone of the emacs-26 branch today and built it.
> Last commit on the branch was: "3aee7be Avoid unnecessary rounding
> errors in timestamps"
> The issue still seems to persist (with or without make autoloads
> before running make).

I cannot reproduce this. I have moved my .emacs file away, and I have
replaced it by what you have shown:

--8<---------------cut here---------------start------------->8---
~/> cat ~/.emacs
;; Begin
(package-initialize)
(add-to-list 'package-archives
             '("melpa" . "https://melpa.org/packages/"))

(unless (package-installed-p 'use-package)
  (package-refresh-contents)
  (package-install 'use-package))

(eval-when-compile
  (require 'use-package))

(use-package slime
  :ensure t)

(setq custom-file "~/.emacs.d/custom.el")
(load custom-file 'noerror)
;; End
--8<---------------cut here---------------end--------------->8---

There doesn't exist a custom.el file yet:

--8<---------------cut here---------------start------------->8---
~/> ls ~/.emacs.d/custom.el
ls: cannot access '/home/albinus/.emacs.d/custom.el': No such file or directory
--8<---------------cut here---------------end--------------->8---

Now I call emacs, change for test user option `ange-ftp-xfer-size-msgs',
and close it afterwards. The custom.el does not contain any Tramp object:

--8<---------------cut here---------------start------------->8---
~/> ~/src/emacs-26/src/emacs
~/> cat ~/.emacs.d/custom.el
(custom-set-variables
 ;; custom-set-variables was added by Custom.
 ;; If you edit it by hand, you could mess it up, so be careful.
 ;; Your init file should contain only one such instance.
 ;; If there is more than one, they won't work right.
 '(ange-ftp-xfer-size-msgs "^150 .* connection for .* (\\([0-9]+\\) bytes)"))
(custom-set-faces
 ;; custom-set-faces was added by Custom.
 ;; If you edit it by hand, you could mess it up, so be careful.
 ;; Your init file should contain only one such instance.
 ;; If there is more than one, they won't work right.
 )
--8<---------------cut here---------------end--------------->8---

> Thank you for your efforts,
>
> Davor Rotim

Best regards, Michael.

bug#28889: 26.0.90; TRAMP and custom file location

[Davor Rotim]

[-- Attachment #1: Type: text/plain, Size: 3460 bytes --]

Hi Michael,

the fact that you don't have a "custom.el" written by the end of that init
is a bit mysterious.
Starting Emacs with the init file I posted will install "use-package" which
in turn will install SLIME
and at the end "use-package" will write the "package-selected-packages"
variable into "custom.el".
This has been the default behavior since GNU Emacs 25.1.
Using the same init file this is how my ~/emacs.d/elpa directory looks like:

--8<---------------cut here---------------start------------->8---
~ $ ls -l .emacs.d/elpa/
total 28K
drwxr-xr-x 4 drot drot 4.0K Oct 23 14:46 archives
drwxr-xr-x 2 drot drot 4.0K Oct 23 14:46 bind-key-20161218.1520
drwxr-xr-x 2 drot drot 4.0K Oct 23 14:46 diminish-20170419.1036
drwx------ 3 drot drot 4.0K Oct 23 14:46 gnupg
drwxr-xr-x 2 drot drot 4.0K Oct 23 14:46 macrostep-20161120.1306
drwxr-xr-x 5 drot drot 4.0K Oct 23 14:46 slime-20170929.1441
drwxr-xr-x 2 drot drot 4.0K Oct 23 14:46 use-package-20171013.1548
--8<---------------cut here---------------end------------->8---

And these are the contents of the custom.el file:

--8<---------------cut here---------------start------------->8---
~ $ cat .emacs.d/custom.el
(custom-set-variables
 ;; custom-set-variables was added by Custom.
 ;; If you edit it by hand, you could mess it up, so be careful.
 ;; Your init file should contain only one such instance.
 ;; If there is more than one, they won't work right.
 '(package-selected-packages (quote (slime use-package)))
 '(tramp-syntax (quote default) nil (tramp)))
(custom-set-faces
 ;; custom-set-faces was added by Custom.
 ;; If you edit it by hand, you could mess it up, so be careful.
 ;; Your init file should contain only one such instance.
 ;; If there is more than one, they won't work right.
 )
--8<---------------cut here---------------end--------------->8---

The TRAMP line still gets added.
Even if I try without "use-package" the results are the same:

--8<---------------cut here---------------start------------->8---
(package-initialize)
(add-to-list 'package-archives
             '("melpa" . "https://melpa.org/packages/"))

(unless (package-installed-p 'slime)
  (package-refresh-contents)
  (package-install 'slime))

(setq custom-file (locate-user-emacs-file "custom.el"))
(load custom-file 'noerror)
--8<---------------cut here---------------end--------------->8---

The only "cure" for this is to use the new approach introduced with GNU
Emacs 25.1:

--8<---------------cut here---------------start------------->8---
(package-initialize)
(add-to-list 'package-archives
             '("melpa" . "https://melpa.org/packages/"))

(setq package-selected-packages '(slime))

(unless package-archive-contents
  (package-refresh-contents))
(package-install-selected-packages)

(setq custom-file (locate-user-emacs-file "custom.el"))
(load custom-file 'noerror)
--8<---------------cut here---------------end--------------->8---

This will avoid writing the custom.el file with the
"package-selected-packages" variable since it's already there
and no TRAMP variable will be added to the custom.el file.
So in short, it seems that the "tramp-syntax" variable gets caught along
with "package-selected-packages"
and it gets written to the custom file whenever we use "package-install" or
"use-package" (which also uses "package-install")
instead of "package-install-selected-packages".
This didn't happen wtih GNU Emacs 25.3, why it happens now I don't know.

Thank you again,

Davor Rotim

[-- Attachment #2: Type: text/html, Size: 4475 bytes --]

bug#28889: 26.0.90; TRAMP and custom file location

[Michael Albinus]

Davor Rotim <rotim.davor@gmail.com> writes:

> Hi Michael,

Hi Davor,

> the fact that you don't have a "custom.el" written by the end of that
> init is a bit mysterious.

Have you started with a non-existing custom.el, as I did? I believe,
Emacs remembers existing settings at startup.

> Thank you again,
>
> Davor Rotim

Best regards, Michael.

bug#28889: 26.0.90; TRAMP and custom file location

[Davor Rotim]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

Hi Michael,

Have you started with a non-existing custom.el, as I did? I believe,
> Emacs remembers existing settings at startup.


Yes that is correct, this was starting only with init.el present in the
~/emacs.d directory.
package.el will create custom.el after that to write the
"package-selected-packages" variable.

Kind regards,

Davor Rotim

[-- Attachment #2: Type: text/html, Size: 623 bytes --]

bug#28889: 26.0.90; TRAMP and custom file location

[Michael Albinus]

Davor Rotim <rotim.davor@gmail.com> writes:

> Hi Michael,

Hi Davor,

> Yes that is correct, this was starting only with init.el present in
> the ~/emacs.d directory.
> package.el will create custom.el after that to write the
> "package-selected-packages" variable.

But I still don't get why Tramp is added to `custom-set-variables' in
your case.

Maybe a side effect of a loaded package? Could you temporarily move away
~/.emacs.d/elpa, and remove ~/.emacs.d/custom.el prior starting Emacs?

And could we concentrate on testing just Emacs 26.0.90?

> Kind regards,
>
> Davor Rotim

Best regards, Michael.

bug#28889: 26.0.90; TRAMP and custom file location

[Davor Rotim]

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

Hi Michael,

First image displays what I have in the directory and version:
https://0x0.st/sr3V.png

Second image displays what I have in the init:
https://0x0.st/sr3W.png

I run emacs -nw and it installs SLIME:
https://0x0.st/sr3J.png

Final image is what I have when I quit Emacs:
https://0x0.st/sr3v.png

I have no previous versions of Emacs installed.

Kind regards,

Davor Rotim

[-- Attachment #2: Type: text/html, Size: 779 bytes --]

bug#28889: 26.0.90; TRAMP and custom file location

[Michael Albinus]

Davor Rotim <rotim.davor@gmail.com> writes:

> Hi Michael,

Hi Davor,

> First image displays what I have in the directory and version:
> https://0x0.st/sr3V.png
>
> Second image displays what I have in the init:
> https://0x0.st/sr3W.png
>
> I run emacs -nw and it installs SLIME:
> https://0x0.st/sr3J.png
>
> Final image is what I have when I quit Emacs:
> https://0x0.st/sr3v.png
>
> I have no previous versions of Emacs installed.

Everything looks good. But we see different results.

Let's play with "emacs -Q". I do the following:

--8<---------------cut here---------------start------------->8---
$ rm ~/.emacs.d/custom.el

$ ~/src/emacs-26/src/emacs -Q --eval '(setq custom-file "~/.emacs.d/custom.el" user-init-file "/dev/null")' --eval "(custom-set-variables '(smtpmail-smtp-service 25))" --eval "(require 'cus-edit)" --eval "(custom-save-all)"

$ cat ~/.emacs.d/custom.el                                    
--8<---------------cut here---------------end--------------->8---

You see, there is no custom Tramp setting, just `smtpmail-smtp-service'
which I have taken as example. Now, you must run the settings in your
init files line by line, and try to find out which form is adding the
Tramp user option.

I would claim that Tramp itself is innocent.

> Kind regards,
>
> Davor Rotim

Best regards, Michael.

bug#28889: 26.0.90; TRAMP and custom file location

[Michael Albinus]

Michael Albinus <michael.albinus@gmx.de> writes:

Hi Davor,

> I would claim that Tramp itself is innocent.

Wait, maybe I've found something which is related. I've committed a new
patch to the emacs-26 branch; could you pls check with this?

Best regards, Michael.

bug#28889: 26.0.90; TRAMP and custom file location

[Davor Rotim]

[-- Attachment #1: Type: text/plain, Size: 101 bytes --]

Hi Michael,

I can confirm that your latest commit fixed the issue.

Thanks once again,

Davor Rotim

[-- Attachment #2: Type: text/html, Size: 177 bytes --]

bug#28889: 26.0.90; TRAMP and custom file location

[Michael Albinus]

Version: 26.1

Davor Rotim <rotim.davor@gmail.com> writes:

> Hi Michael,

Hi Davor,

> I can confirm that your latest commit fixed the issue.

Thanks for the feedback, I'm closing the bug.

> Thanks once again,
>
> Davor Rotim

Best regards, Michael.