From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Gary Fredericks Newsgroups: gmane.emacs.bugs Subject: bug#32720: term-mode ignores certain window size changes Date: Fri, 16 Nov 2018 07:15:14 -0600 Message-ID: References: <5BDEC23D.4080707@gmx.at> <5BEEBECF.5060601@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000e33db6057ac7f56b" X-Trace: blaine.gmane.org 1542374048 24392 195.159.176.226 (16 Nov 2018 13:14:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 16 Nov 2018 13:14:08 +0000 (UTC) Cc: 32720@debbugs.gnu.org To: rudalics@gmx.at Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 16 14:14:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNdwh-0006Da-Gq for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Nov 2018 14:14:03 +0100 Original-Received: from localhost ([::1]:44806 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNdyo-0006iA-4L for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Nov 2018 08:16:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNdyg-0006i4-Vp for bug-gnu-emacs@gnu.org; Fri, 16 Nov 2018 08:16:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNdyc-0000Ek-M9 for bug-gnu-emacs@gnu.org; Fri, 16 Nov 2018 08:16:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50603) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gNdyc-0000Ea-JE for bug-gnu-emacs@gnu.org; Fri, 16 Nov 2018 08:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gNdyc-00005K-DP for bug-gnu-emacs@gnu.org; Fri, 16 Nov 2018 08:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gary Fredericks Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Nov 2018 13:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32720 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32720-submit@debbugs.gnu.org id=B32720.154237413332747 (code B ref 32720); Fri, 16 Nov 2018 13:16:02 +0000 Original-Received: (at 32720) by debbugs.gnu.org; 16 Nov 2018 13:15:33 +0000 Original-Received: from localhost ([127.0.0.1]:54861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNdy9-0008W6-38 for submit@debbugs.gnu.org; Fri, 16 Nov 2018 08:15:33 -0500 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:36854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNdy7-0008Vs-VK for 32720@debbugs.gnu.org; Fri, 16 Nov 2018 08:15:32 -0500 Original-Received: by mail-wm1-f54.google.com with SMTP id s11so11773782wmh.1 for <32720@debbugs.gnu.org>; Fri, 16 Nov 2018 05:15:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0rZjRQnLsl1Pk/y8MwBEOFZItucP6vapOrsKlUW1WFM=; b=l9ECX9xIZ+VZE7u8lXH+/EIRfynMUgbi+FBuGyU5a6BUcQDL8sEeUF/8lCYeVab+BY G9zcOCEBy0PTLxntWEtG7YJ42BFExsPqGerPoHYpaRDj6+D8CElFrtCB8Sybg0HxCSZe 9imvkAyx/rDrmCq24LWdGU3nP/aya1jT1E37CSgclG7JzOJKX0wxnaztOuG9i4m1zW8K n8Aa2rCHlgS8tW3QVDQN8FJaiWdO9KXG1Bzpk7HnLzwM7EbQt25mGCe1SJP2HL1B09bt huCtHm7jn9pN5DgGr1mr1Yti+aMVk+gDNhxBrQ4VjFUpsngmTitAOsGloQqB/bpu+qn1 UHEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0rZjRQnLsl1Pk/y8MwBEOFZItucP6vapOrsKlUW1WFM=; b=Ko/dIk9TMRKJVqgpcq19Qep60C/nAJ0NXUCJqPzcXHd9Jgga7DNniuuekBqSH3DghJ kwIZg0gHK07IgpOWOb7ox4/sgAJZ4Q5RFPmOWzpDlBU1YWdVLdDe6hq/ToZta7shv7G+ jY/DaV2BberqXZJhCEXSrNmlhUiK8wA0i1x3GufxrAhIlyC3TiWqySXnruUmOPHXOo4E dAs66N9IZicYrEabSCBzgMa0mJESmVhex8Ddvf8kfVHuTP5h1eO+cWiCqZgnTvsjAKjt Atj0pjkmGkH97IvdKMpV9+fVQEICFLJh0emMrFX5r8Skq0Orv5ru8JQMyS6WiI6J7Vlk Ij4Q== X-Gm-Message-State: AGRZ1gI4jDl/4lem/oqYYSJEeD+ioDOkUA7vFfzQtv2OOd6/jfKnfIm2 NAf4RQuDBvUidnffzlA/8jT8GKQlQyGyMW+d5h0= X-Google-Smtp-Source: AJdET5f2ZR1jn5P7fWa2siRrjg4nJXrc66iE3unO0D5xhL3SfvjvczINahZPsKcWVB7lRvzAifVQF6bP2KUo4khli7I= X-Received: by 2002:a1c:1d85:: with SMTP id d127mr8785236wmd.103.1542374125942; Fri, 16 Nov 2018 05:15:25 -0800 (PST) In-Reply-To: <5BEEBECF.5060601@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152456 Archived-At: --000000000000e33db6057ac7f56b Content-Type: text/plain; charset="UTF-8" Confirmed that I've been using that add-hook call for a while (ever since I originally reported this) and haven't noticed any adverse effects. Gary Fredericks (803)-295-0195 fredericksgary@gmail.com gfredericks.com On Fri, Nov 16, 2018 at 6:58 AM martin rudalics wrote: > > Yep, it seems to work with the patch applied. > > Thanks for the feedback. But after more carefully looking into the > 'window-adjust-process-windows' code I am now almost convinced that > your original proposal is the way to go. That is, I nowhere found in > that code anything that depends on the change of the window > configuration. The only thing that code is interested in is tracing > window size changes which 'window-configuration-change-hook' does not > handle particularly well. > > So if you already have run Emacs for some time with your > > (add-hook > 'window-size-change-functions > (lambda (_frame) (window--adjust-process-windows))) > > and did not see any adversary effects I am inclined to install that > for Emacs 26.2. For Emacs 27 I would then (after the release of Emacs > 26.2) remove the > > (add-hook 'window-configuration-change-hook > 'window--adjust-process-windows) > > call. > > Eli would that be OK with you as well? I'd still have to amend the > doc of 'window-configuration-change-hook' but the net change would be > considerably smaller than the one I proposed in the other thread. > > martin > --000000000000e33db6057ac7f56b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Confirmed that I've been using that add-hook call= for a while (ever since I originally reported this) and haven't notice= d any adverse effects.

Ga= ry Fredericks
(803)-295-0195
fredericksgary@gmail.com
gfredericks.com


On Fri, Nov 16, 2= 018 at 6:58 AM martin rudalics <rudal= ics@gmx.at> wrote:
=C2=A0&g= t; Yep, it seems to work with the patch applied.

Thanks for the feedback.=C2=A0 But after more carefully looking into the 'window-adjust-process-windows' code I am now almost convinced that=
your original proposal is the way to go.=C2=A0 That is, I nowhere found in<= br> that code anything that depends on the change of the window
configuration.=C2=A0 The only thing that code is interested in is tracing window size changes which 'window-configuration-change-hook' does n= ot
handle particularly well.

So if you already have run Emacs for some time with your

(add-hook
=C2=A0 'window-size-change-functions
=C2=A0 (lambda (_frame) (window--adjust-process-windows)))

and did not see any adversary effects I am inclined to install that
for Emacs 26.2.=C2=A0 For Emacs 27 I would then (after the release of Emacs=
26.2) remove the

(add-hook 'window-configuration-change-hook 'window--adjust-process= -windows)

call.

Eli would that be OK with you as well?=C2=A0 I'd still have to amend th= e
doc of 'window-configuration-change-hook' but the net change would = be
considerably smaller than the one I proposed in the other thread.

martin
--000000000000e33db6057ac7f56b--