bug#49826: 26.1; Clicking on error in Inferior Python mode jumps to wrong line after source file edit

bug#49826: 26.1; Clicking on error in Inferior Python mode jumps to wrong line after source file edit

[Al Go]

[-- Attachment #1: Type: text/plain, Size: 5928 bytes --]

Description:

Editing the source file in Python mode before a line with an error results
in the incorrect jump when clicking on the error line in inferior Python
mode. Same when pressing RET on the error line. It seems that
python-mode.el compensates for that edit twice (adding lines before the
error sends me TOO FAR DOWN instead of up, by the amount of added lines).
Reproducing with minimal example works 90% of the time, but not 100%.
Tested with emacs -Q.

Steps to reproduce:

If I create a file t.py containing:

#1
assert False
#b
#c

Then visit it with emacs -Q (which starts Python mode) and start an
inferior Python mode with C-c C-p then run the file with C-c C-c, the
inferior mode buffer shows:

"File "[...]/t.py", line 2, in <module>

Which is correct, and clicking on that line takes me to the "assert False"
line in the Python mode buffer, which is correct.

BUT, if I then edit the source file by adding or removing lines before the
error, for example:

#1
#2
assert False
#b
#c

the inferior mode buffer now shows:

"File "[...]/t.py", line 3, in <module>

Which is still correct, but clicking on it now sends me to line 4 (#b)
instead of line 3. If I instead edit the file as such:

#1
#2
#3
assert False
#b
#c

the inferior mode buffer now shows:

"File "[...]/t.py", line 4, in <module>

But clicking on it now sends me to line 6 (#c), and so on.
(End description)


In GNU Emacs 26.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.5)
 of 2021-01-31, modified by Debian built on x86-csail-01
Windowing system distributor 'The X.Org Foundation', version 11.0.12004000
System Description: Debian GNU/Linux 10 (buster)

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Can’t guess python-indent-offset, using defaults: 4
Shell native completion is enabled.
Can’t guess python-indent-offset, using defaults: 4
Sent: #1...
Making completion list...

Configured using:
 'configure --build x86_64-linux-gnu --prefix=/usr
 --sharedstatedir=/var/lib --libexecdir=/usr/lib
 --localstatedir=/var/lib --infodir=/usr/share/info
 --mandir=/usr/share/man --enable-libsystemd --with-pop=yes
 --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/26.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/26.1/site-lisp:/usr/share/emacs/site-lisp
 --with-sound=alsa --without-gconf --with-mailutils --build
 x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib
 --libexecdir=/usr/lib --localstatedir=/var/lib
 --infodir=/usr/share/info --mandir=/usr/share/man --enable-libsystemd
 --with-pop=yes
 --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/26.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/26.1/site-lisp:/usr/share/emacs/site-lisp
 --with-sound=alsa --without-gconf --with-mailutils --with-x=yes
 --with-x-toolkit=gtk3 --with-toolkit-scroll-bars 'CFLAGS=-g -O2
 -fdebug-prefix-map=/build/emacs-9Yet8u/emacs-26.1+1=.
-fstack-protector-strong
 -Wformat -Werror=format-security -Wall' 'CPPFLAGS=-Wdate-time
 -D_FORTIFY_SOURCE=2' LDFLAGS=-Wl,-z,relro'

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY
ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 THREADS LIBSYSTEMD LCMS2

Important settings:
  value of $LANG: en_US.utf8
  locale-coding-system: utf-8-unix

Major mode: Python

Minor modes in effect:
  diff-auto-refine-mode: t
  shell-dirtrack-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail
rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils compile cl-extra help-mode vc-git
diff-mode easy-mmode python easymenu tramp-sh tramp tramp-compat
tramp-loaddefs trampver ucs-normalize shell pcomplete parse-time
format-spec advice auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map seq byte-opt gv bytecomp
byte-compile cconv comint ring cl-loaddefs cl-lib ansi-color elec-pair
time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page menu-bar
rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting move-toolbar gtk
x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 233945 10187)
 (symbols 48 23449 2)
 (miscs 40 67 162)
 (strings 32 39308 2263)
 (string-bytes 1 1169100)
 (vectors 16 40258)
 (vector-slots 8 779773 12526)
 (floats 8 76 189)
 (intervals 56 309 1)
 (buffers 992 16))

[-- Attachment #2: Type: text/html, Size: 6399 bytes --]

bug#49826: 26.1; Clicking on error in Inferior Python mode jumps to wrong line after source file edit

[Lars Ingebrigtsen]

Al Go <al.go.robot.42@gmail.com> writes:

> BUT, if I then edit the source file by adding or removing lines before the error,
> for example:
>
> #1
> #2
> assert False
> #b
> #c
>
> the inferior mode buffer now shows:
>
> "File "[...]/t.py", line 3, in <module>
>
> Which is still correct, but clicking on it now sends me to line 4 (#b) instead of
> line 3.

I'm not able to reproduce this in Emacs 28 -- I think it was fixed a few
months ago there.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no