[BUG] Search leaves draws open [9.7-pre (release_9.6.10-835-gf3de4c @ ~/.emacs.d/org-mode-git/lisp/)]

[BUG] Search leaves draws open [9.7-pre (release_9.6.10-835-gf3de4c @ ~/.emacs.d/org-mode-git/lisp/)]

[Paul Stansell]

[-- Attachment #1.1: Type: text/plain, Size: 4508 bytes --]

Hello,

Using Ctrl-S to search an org file leaves drawers open after the search.
For example, open the attached org file, search_bug.org, and, with the
cursor initially at the first line of the file, search for "text" with
- Ctrl-s text
This finds the first occurrence of "text" in "Subsection 1".  Then press
Ctrl-a to go to the beginning of the line.  At this point all the drawers
in "Subsection 1" are opened and left open.  They are not closed by
Shift-tab visibility cycling.

This doesn't happen with Org mode version 9.5.5 (release_9.5.5).

Thanks,

Paul


Emacs  : GNU Emacs 28.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.37, cairo version 1.16.0)
 of 2023-03-16, modified by Debian
Package: Org mode version 9.7-pre (release_9.6.10-835-gf3de4c @
~/.emacs.d/org-mode-git/lisp/)

current state:
==============
(setq
 org-link-elisp-confirm-function 'yes-or-no-p
 org-bibtex-headline-format-function 'org-bibtex-headline-format-default
 org-persist-after-read-hook '(org-element--cache-persist-after-read)
 org-export-before-parsing-hook '(org-attach-expand-links)
 org-cycle-tab-first-hook '(org-babel-hide-result-toggle-maybe
   org-babel-header-arg-expand)
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-cycle-hook '(org-cycle-hide-archived-subtrees
org-cycle-show-empty-lines
 org-cycle-optimize-window-after-visibility-change
 org-cycle-display-inline-images)
 org-persist-before-read-hook '(org-element--cache-persist-before-read)
 org-mode-hook '(#[0 "\300\301\302\303\304$\207"
  [add-hook change-major-mode-hook org-fold-show-all append
   local]
  5]
#[0 "\300\301\302\303\304$\207"
  [add-hook change-major-mode-hook org-babel-show-result-all
   append local]
  5]
org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-confirm-shell-link-function 'yes-or-no-p
 outline-isearch-open-invisible-function 'outline-isearch-open-invisible
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
    org-src-mode-configure-edit-buffer)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-speed-command-hook '(org-speed-command-activate
 org-babel-speed-command-activate)
 org-persist-directory "/tmp/org-persist-Fs6tWx"
 org-fold-core-isearch-open-function 'org-fold--isearch-reveal
 org-persist-before-write-hook '(org-element--cache-persist-before-write)
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe
     org-babel-header-arg-expand)
 org-link-shell-confirm-function 'yes-or-no-p
 org-babel-pre-tangle-hook '(save-buffer)
 org-agenda-loop-over-headlines-in-active-region nil
 org-occur-hook '(org-first-headline-recenter)
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-link-parameters '(("attachment" :follow org-attach-follow :complete
org-attach-complete-link)
      ("id" :follow org-id-open)
      ("eww" :follow org-eww-open :store org-eww-store-link)
      ("rmail" :follow org-rmail-open :store
org-rmail-store-link)
      ("mhe" :follow org-mhe-open :store org-mhe-store-link)
      ("irc" :follow org-irc-visit :store org-irc-store-link
:export org-irc-export)
      ("info" :follow org-info-open :export org-info-export
:store org-info-store-link :insert-description
org-info-description-as-command)
      ("gnus" :follow org-gnus-open :store
org-gnus-store-link)
      ("docview" :follow org-docview-open :export
org-docview-export :store org-docview-store-link)
      ("bibtex" :follow org-bibtex-open :store
org-bibtex-store-link)
      ("bbdb" :follow org-bbdb-open :export org-bbdb-export
:complete org-bbdb-complete-link :store
org-bbdb-store-link)
      ("w3m" :store org-w3m-store-link)
      ("doi" :follow org-link-doi-open :export
org-link-doi-export)
      ("file+sys") ("file+emacs")
      ("shell" :follow org-link--open-shell)
      ("news" :follow
#[514 "\301\300\302 Q \"\207"
 ["news" browse-url ":"] 6 "\n\n(fn URL ARG)"]
)
      ("mailto" :follow
#[514 "\301\300\302 Q \"\207"
 ["mailto" browse-url ":"] 6 "\n\n(fn URL ARG)"]
)
      ("https" :follow
#[514 "\301\300\302 Q \"\207"
 ["https" browse-url ":"] 6 "\n\n(fn URL ARG)"]
)
      ("http" :follow
#[514 "\301\300\302 Q \"\207"
 ["http" browse-url ":"] 6 "\n\n(fn URL ARG)"]
)
      ("ftp" :follow
#[514 "\301\300\302 Q \"\207" ["ftp" browse-url ":"]
 6 "\n\n(fn URL ARG)"]
)
      ("help" :follow org-link--open-help :store
org-link--store-help)
      ("file" :complete org-link-complete-file)
      ("elisp" :follow org-link--open-elisp))
 org-metaup-hook '(org-babel-load-in-session-maybe)
 )
-- 
Paul

[-- Attachment #1.2: Type: text/html, Size: 5972 bytes --]

[-- Attachment #2: search_bug.org --]
[-- Type: text/org, Size: 842 bytes --]

#+STARTUP: content
* Section

** STARTED Subsection 1
   :LOGBOOK:
   - State "STARTED"    from              [2022-04-25 Mon 10:56]
   :END:
   :CLOCK:
   CLOCK: [2023-01-29 Sun 19:10]--[2023-01-29 Sun 19:34] =>  0:24
   CLOCK: [2023-01-28 Sat 21:24]--[2023-01-28 Sat 21:53] =>  0:29
   CLOCK: [2022-04-26 Tue 15:48]--[2022-04-26 Tue 16:43] =>  0:55
   CLOCK: [2022-04-25 Mon 10:56]--[2022-04-25 Mon 11:36] =>  0:40
   :END:
 
   text

** STARTED Subsection 2
   :LOGBOOK:
   - State "STARTED"    from              [2022-04-25 Mon 10:56]
   :END:
   :CLOCK:
   CLOCK: [2023-01-29 Sun 19:10]--[2023-01-29 Sun 19:34] =>  0:24
   CLOCK: [2023-01-28 Sat 21:24]--[2023-01-28 Sat 21:53] =>  0:29
   CLOCK: [2022-04-26 Tue 15:48]--[2022-04-26 Tue 16:43] =>  0:55
   CLOCK: [2022-04-25 Mon 10:56]--[2022-04-25 Mon 11:36] =>  0:40
   :END:

   text

Re: [BUG] Search leaves draws open [9.7-pre (release_9.6.10-835-gf3de4c @ ~/.emacs.d/org-mode-git/lisp/)]

[Ihor Radchenko]

Paul Stansell <paulstansell@gmail.com> writes:

> Using Ctrl-S to search an org file leaves drawers open after the search.
> For example, open the attached org file, search_bug.org, and, with the
> cursor initially at the first line of the file, search for "text" with
> - Ctrl-s text
> This finds the first occurrence of "text" in "Subsection 1".  Then press
> Ctrl-a to go to the beginning of the line.  At this point all the drawers
> in "Subsection 1" are opened and left open.  They are not closed by
> Shift-tab visibility cycling.
>
> This doesn't happen with Org mode version 9.5.5 (release_9.5.5).

Confirmed.
This is a bit difficult to debug and may take some time.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] Search leaves draws open [9.7-pre (release_9.6.10-835-gf3de4c @ ~/.emacs.d/org-mode-git/lisp/)]

[Paul Stansell]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

Hello Ihor,

In the meantime, is there a command that will close all drawers, even those
that are open in sections (headings) that are closed?  I searched but
didn't find anything.

Thanks,

Paul

[-- Attachment #2: Type: text/html, Size: 317 bytes --]

Re: [BUG] Search leaves draws open [9.7-pre (release_9.6.10-835-gf3de4c @ ~/.emacs.d/org-mode-git/lisp/)]

[Ihor Radchenko]

Paul Stansell <paulstansell@gmail.com> writes:

> In the meantime, is there a command that will close all drawers, even those
> that are open in sections (headings) that are closed?  I searched but
> didn't find anything.

org-hide-drawer-all

Re: [BUG] Search leaves draws open [9.7-pre (release_9.6.10-835-gf3de4c @ ~/.emacs.d/org-mode-git/lisp/)]

[Paul Stansell]

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

>
> > In the meantime, is there a command that will close all drawers, even
> those
> > that are open in sections (headings) that are closed?  I searched but
> > didn't find anything.
>
> org-hide-drawer-all
>

I don't seem to have that command.  I'm using Org mode
release_9.6.10-835-gf3de4c.

I grep for org-hide-drawer-all there is the following entry that seems to
imply the command is obsolete:

(define-obsolete-function-alias 'org-hide-drawer-all
  'org-fold-hide-drawer-all "9.6")

If I try to run the command using

  M-x org-hide-drawer-all

I'm told "no match".

[-- Attachment #2: Type: text/html, Size: 997 bytes --]

Re: [BUG] Search leaves draws open [9.7-pre (release_9.6.10-835-gf3de4c @ ~/.emacs.d/org-mode-git/lisp/)]

[Ihor Radchenko]

Paul Stansell <paulstansell@gmail.com> writes:

>> org-hide-drawer-all
>>
>
> I don't seem to have that command.  I'm using Org mode
> release_9.6.10-835-gf3de4c.

It was made into a command in
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=13353f1fa34f6f085ffbf142b380af7308f02981

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] Search leaves draws open [9.7-pre (release_9.6.10-835-gf3de4c @ ~/.emacs.d/org-mode-git/lisp/)]

[Paul Stansell]

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

> >> org-hide-drawer-all
> >>
> >
> > I don't seem to have that command.  I'm using Org mode
> > release_9.6.10-835-gf3de4c.
>
> It was made into a command in
>
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=13353f1fa34f6f085ffbf142b380af7308f02981


I see, I found the command, it's called org-fold-hide-drawer-all
(not org-hide-drawer-all).

However, strangely, it doesn't close drawers that have been opened by the
bug that causes drawers to remain open after the searching (eg, those
opened by searching for "text" in the file I included in my bug report).

[-- Attachment #2: Type: text/html, Size: 1060 bytes --]

Re: [BUG] Search leaves draws open [9.7-pre (release_9.6.10-835-gf3de4c @ ~/.emacs.d/org-mode-git/lisp/)]

[Ihor Radchenko]

Paul Stansell <paulstansell@gmail.com> writes:

> However, strangely, it doesn't close drawers that have been opened by the
> bug that causes drawers to remain open after the searching (eg, those
> opened by searching for "text" in the file I included in my bug report).

It indeed does not. Because of a bug you reported. The buggy part is not
converting from the isearch overlays back to Org folds. isearch overlays
force the drawers to remain open.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] Search leaves draws open [9.7-pre (release_9.6.10-835-gf3de4c @ ~/.emacs.d/org-mode-git/lisp/)]

[Ihor Radchenko]

Paul Stansell <paulstansell@gmail.com> writes:

> Using Ctrl-S to search an org file leaves drawers open after the search.
> For example, open the attached org file, search_bug.org, and, with the
> cursor initially at the first line of the file, search for "text" with
> - Ctrl-s text
> This finds the first occurrence of "text" in "Subsection 1".  Then press
> Ctrl-a to go to the beginning of the line.  At this point all the drawers
> in "Subsection 1" are opened and left open.  They are not closed by
> Shift-tab visibility cycling.

Handled, on main.
On main, the default folding style is back to overlays, unless old Emacs
version is used. For overlays, the bug is fixed.
For, text properties, the whole implementation of isearch support is a
fragile hack. Wontfix.

https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=24c4a40f7

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>