From: Evgeni Kolev <evgeni.d.kolev@gmail.com>
To: "João Távora" <joaotavora@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 60557-done@debbugs.gnu.org
Subject: bug#60557: [PATCH] Fix eglot prompt when connection already exists
Date: Wed, 18 Jan 2023 07:58:26 +0200 [thread overview]
Message-ID: <CAMCrgaWazB+7T7aueLy3yyv=wSFzYBqtBi1WsV8PHaUo7dWLFw@mail.gmail.com> (raw)
In-Reply-To: <83h6wq4jjd.fsf@gnu.org>
Hi João, thank you for addressing this quickly!
Sorry for the delay on my side - I've been dealing with the flu the
last few days.
On Mon, Jan 16, 2023 at 4:54 PM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > From: João Távora <joaotavora@gmail.com>
> > Date: Mon, 16 Jan 2023 14:42:25 +0000
> > Cc: evgeni.d.kolev@gmail.com, 60557@debbugs.gnu.org
> >
> > > In eglot:
> > > progmodes/eglot.el:1078:44: Warning: Unused lexical argument `interactive'
> > >
> > > because the INTERACTIVE argument is now unused.
> >
> > You're right, I missed that. Sorry.
> >
> > > Should it be renamed to _interactive?
> >
> > Yes, that would be fine. As would removing the argument entirely.
> >
> > M-x eglot is _not_ meant to be called from Lisp at at all, but some time
> > ago I found at least one user on emacs-devel was doing so. So removing
> > it may break some code (that is probably already broken anyway, but still...).
>
> I renamed it and updated the doc string to that effect.
>
> Closing.
prev parent reply other threads:[~2023-01-18 5:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 15:44 bug#60557: [PATCH] Fix eglot prompt when connection already exists Evgeni Kolev
2023-01-12 9:35 ` Eli Zaretskii
2023-01-12 10:53 ` João Távora
2023-01-14 6:02 ` Evgeni Kolev
2023-01-14 17:22 ` João Távora
2023-01-16 11:53 ` João Távora
2023-01-16 14:08 ` Eli Zaretskii
2023-01-16 14:15 ` Eli Zaretskii
2023-01-16 14:42 ` João Távora
2023-01-16 14:54 ` Eli Zaretskii
2023-01-18 5:58 ` Evgeni Kolev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMCrgaWazB+7T7aueLy3yyv=wSFzYBqtBi1WsV8PHaUo7dWLFw@mail.gmail.com' \
--to=evgeni.d.kolev@gmail.com \
--cc=60557-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.