From: Evgeni Kolev <evgenysw@gmail.com>
To: 61617@debbugs.gnu.org
Subject: bug#61617: M-x mark-defun doesn't work correctly in tree-sitter modes when comments exist between functions
Date: Sun, 19 Feb 2023 10:39:07 +0200 [thread overview]
Message-ID: <CAMCrgaUgTdPvSuZ1T0WLgu2dj69C2FMaMq7GqU8Aq2DEyZ+kng@mail.gmail.com> (raw)
M-x mark-defun doesn't work correctly when the function at point is
preceded by a comment.
I've noticed this bug in go-ts-mode, and have also checked it's
reproduced in rust-ts-mode:
To reproduce:
1. with the following code in go-ts-mode, "|" is the point (in function sum2)
```
package main
func sum(a, b int) int {
return a + b
}
// comment
func sum2(a, b int) int {
Ireturn a + b
}
```
2. Execute M-x mark-defun
3. The region selected is wrong - the empty line between the two
functions is marked. I expect only function sum2 and the preceding
comment to be marked.
Observations:
- The issue is reproducible with a fresh build of master, and
reproducible with emacs -Q.
- The issue is also reproducible in rust-ts-mode which makes me think
the root cause is in treesit code (treesit.el maybe).
- From what I've checked, (beginning-of-defun-comments) works
correctly, but (end-of-defun) doesn't. These two (and other) functions
are used by mark-defun.
- The issue does not exist when the function is not preceded by a
comment. In other words - the issue is not reproduced when no comments
exist between the functions.
Below is a Rust example which reproduces the issue, again "|" is the
point (in function main2). Steps to reproduce are identical to the
steps for go-ts-mode:
```
fn main() {
println!("Hello World!");
}
// comment
fn main2() {
|println!("Hello World!");
}
```
next reply other threads:[~2023-02-19 8:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 8:39 Evgeni Kolev [this message]
2023-02-20 8:30 ` bug#61617: M-x mark-defun doesn't work correctly in tree-sitter modes when comments exist between functions Evgeni Kolev
2023-02-25 5:08 ` Yuan Fu
2023-02-25 7:27 ` Evgeni Kolev
2023-02-27 0:42 ` Yuan Fu
2023-02-27 9:24 ` Yuan Fu
2023-02-27 16:03 ` Evgeni Kolev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMCrgaUgTdPvSuZ1T0WLgu2dj69C2FMaMq7GqU8Aq2DEyZ+kng@mail.gmail.com \
--to=evgenysw@gmail.com \
--cc=61617@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.