From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Le Wang Newsgroups: gmane.emacs.devel Subject: Re: fix for bug 10994 breaks ido customizations in major way Date: Tue, 7 May 2013 17:35:23 +0800 Message-ID: References: <87txmfyb9n.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: ger.gmane.org 1367919333 3155 80.91.229.3 (7 May 2013 09:35:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 7 May 2013 09:35:33 +0000 (UTC) Cc: Leo Liu , emacs-devel@gnu.org To: Vitalie Spinu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 07 11:35:32 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UZeJ1-0001Y4-JD for ged-emacs-devel@m.gmane.org; Tue, 07 May 2013 11:35:31 +0200 Original-Received: from localhost ([::1]:37321 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZeJ0-0007th-U0 for ged-emacs-devel@m.gmane.org; Tue, 07 May 2013 05:35:30 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59292) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZeIx-0007tK-4w for emacs-devel@gnu.org; Tue, 07 May 2013 05:35:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZeIv-0001WA-RO for emacs-devel@gnu.org; Tue, 07 May 2013 05:35:27 -0400 Original-Received: from mail-we0-x232.google.com ([2a00:1450:400c:c03::232]:50686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZeIv-0001Vy-LG for emacs-devel@gnu.org; Tue, 07 May 2013 05:35:25 -0400 Original-Received: by mail-we0-f178.google.com with SMTP id q57so264282wes.9 for ; Tue, 07 May 2013 02:35:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=w4KcOw3RH+WnKer3fZm0X9XH1mDzZ/VuK6CTFfdOznw=; b=RnISUSs02Dj5dqCriftL+1uvFimXFMumGzbELVQMTg8HIjl/QX9DCLDIIY0Y3O7Hwh dht4UjoE7YZ7RlortCk9rFGV/9gN0VP2dxrGxb/x/7Azowb2q06EoZKaH42qiZ28oEpM 95l18bo2l8OVXbl9LIOkB1g2QH1N2qWaO0+5/EyrlR6ornR4eeTvYE0cyu7uVwGT2q9g KJ2jKo+53QodT57B+nbtKT1vOIzoA7huzm7GrqdcA7OV5fCDwgUnQkMMLm+IxYY8bf0e mvP4O5IiMW2Pbr2DsyuYhNc1kqcRMuY+FVbpGAiCDJHNZpolz1SOLoBvi2BUj351kpFa R1Kw== X-Received: by 10.194.93.68 with SMTP id cs4mr1959870wjb.17.1367919323268; Tue, 07 May 2013 02:35:23 -0700 (PDT) Original-Received: by 10.217.116.8 with HTTP; Tue, 7 May 2013 02:35:23 -0700 (PDT) In-Reply-To: <87txmfyb9n.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c03::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159387 Archived-At: On Tue, May 7, 2013 at 6:49 AM, Vitalie Spinu wrote: > >> Le Wang > >> on Sat, 4 May 2013 15:00:24 +0800 wrote: > > > On Sat, May 4, 2013 at 4:33 AM, Leo Liu wrote: > >> On 2013-05-03 20:49 +0800, Le Wang wrote: > >> > There are a few ido customizations floating around that propertizes text. > >> > This will break all of them. I don't think this fix is acceptable. > >> > > What do you mean by "break"? > > When propertied strings are used, they are used for a reason - to carry > additional information. > > There are plenty of applications that might need same strings but with > different meaning. No there aren't. Because this was completely broken in 24.3.1 until the fix was checked in for 10994. > For example ido for tag or imenu navigation, there > might be several locations where a symbol is used/defined. This is a good reason for including a line#, class, etc. Why only text-properties? Your examples are contrived and not in the wild at all. I say again, only HEAD has the ability to handle repeated runs of strings. BUT the cost of adding this functionality is breaking packages that add text properties ... Packages that actually __exist__. > Currently > > (let ((t1 (propertize "aaa" 'aaa 12)) > (t2 (propertize "aaa" 'aaa 11))) > (ido-completing-read "?: " (list t1 t2 "sfd"))) > > works as expected. And the above patch breaks that. That would be a horrible UI. Luckily AFAICT, it hasn't happened. That's why I say there is no actual valid use-case for repeating the same string in completions. -- Le