* lexical-binding causes a lot more GC, why?
@ 2015-10-28 15:12 Le Wang
2015-10-30 19:07 ` John Wiegley
2015-10-30 21:14 ` Paul Eggert
0 siblings, 2 replies; 4+ messages in thread
From: Le Wang @ 2015-10-28 15:12 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 288 bytes --]
Hi all,
We found, while doing optimizations in flx (
https://github.com/lewang/flx/pull/76#issuecomment-151689064) that enabling
lexical-binding caused a lot of GC runs.
I thought lexical-binding should always result in perf gains, does anyone
know why this could be happening?
--
Le
[-- Attachment #2: Type: text/html, Size: 496 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: lexical-binding causes a lot more GC, why?
2015-10-28 15:12 lexical-binding causes a lot more GC, why? Le Wang
@ 2015-10-30 19:07 ` John Wiegley
2015-10-30 21:14 ` Paul Eggert
1 sibling, 0 replies; 4+ messages in thread
From: John Wiegley @ 2015-10-30 19:07 UTC (permalink / raw)
To: Le Wang; +Cc: emacs-devel
>>>>> Le Wang <l26wang@gmail.com> writes:
> I thought lexical-binding should always result in perf gains, does anyone
> know why this could be happening?
Hi Le, would it be possible to create a test that takes the memory-use-counts
before some activity, then after, with and without lexical-binding enabled, so
that we could fail if lexical-binding has bad behavior? I think that should be
more efficient, so I'd love to pin this down in an isolated case.
John
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: lexical-binding causes a lot more GC, why?
2015-10-28 15:12 lexical-binding causes a lot more GC, why? Le Wang
2015-10-30 19:07 ` John Wiegley
@ 2015-10-30 21:14 ` Paul Eggert
2015-10-30 22:10 ` Artur Malabarba
1 sibling, 1 reply; 4+ messages in thread
From: Paul Eggert @ 2015-10-30 21:14 UTC (permalink / raw)
To: emacs-devel
On 10/28/2015 08:12 AM, Le Wang wrote:
>
> I thought lexical-binding should always result in perf gains
Isn't lexical binding implemented by passing around a list of bindings?
That might explain the performance problems you see. (Sorry, I haven't
looked at the actual code; this is just my vague recollection.)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-30 22:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-28 15:12 lexical-binding causes a lot more GC, why? Le Wang
2015-10-30 19:07 ` John Wiegley
2015-10-30 21:14 ` Paul Eggert
2015-10-30 22:10 ` Artur Malabarba
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.