From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Le Wang Newsgroups: gmane.emacs.devel Subject: Re: fix for bug 10994 breaks ido customizations in major way Date: Mon, 6 May 2013 23:11:35 +0800 Message-ID: References: <87ip2zm89w.fsf@wanadoo.es> <87vc6xsnhb.fsf@wanadoo.es> <87r4hlsjnj.fsf@wanadoo.es> <87mws9sg1a.fsf@wanadoo.es> <87y5btjy6v.fsf@uwakimon.sk.tsukuba.ac.jp> <87ip2xsb1r.fsf@wanadoo.es> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=f46d043c062edfa47204dc0e1d52 X-Trace: ger.gmane.org 1367853114 5980 80.91.229.3 (6 May 2013 15:11:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 6 May 2013 15:11:54 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?ISO-8859-1?Q?=D3scar_Fuentes?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 06 17:11:54 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UZN4y-00057N-94 for ged-emacs-devel@m.gmane.org; Mon, 06 May 2013 17:11:52 +0200 Original-Received: from localhost ([::1]:50293 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZN4x-0004TV-R8 for ged-emacs-devel@m.gmane.org; Mon, 06 May 2013 11:11:51 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZN4m-0004HT-3S for emacs-devel@gnu.org; Mon, 06 May 2013 11:11:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZN4k-0005JU-I3 for emacs-devel@gnu.org; Mon, 06 May 2013 11:11:39 -0400 Original-Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:38240) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZN4k-0005J9-B7 for emacs-devel@gnu.org; Mon, 06 May 2013 11:11:38 -0400 Original-Received: by mail-wi0-f175.google.com with SMTP id h11so2658612wiv.14 for ; Mon, 06 May 2013 08:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=ZlQC6AoCHrEfsG7VOI2Q/2k4T5vHIPt9aQ9WloL3YXU=; b=neA2lWlsnKykrGGBaaotqZjMynq+lz0iUWkTCifcFwmJi0Puga7CS0qhaCTvUAHqby xPlXLDfJdSM3bB8sWJW99X5HgRaoKmzj7XDkf04CG+03WTRTsyGrifNUaZ1B8Da4DL1A VgwABgnGknZtqdmhIk/PksYN17p8xTYUbC/twMCyxBGgurP1O1WHW8be1MGFh7CYNovE BXAB0mP3BidT4fNmpyJE0BkHCo5WETHZyHh82uKVaC4a6+2HfnPLz63fTzPMjPdG7kHR Z6NgvUmioC5LHzNZvW/T9V0tNEiiZRdj97731+0Dj9S15ob0aeXwGVjS3yMYOybfh7r5 +qxw== X-Received: by 10.180.79.69 with SMTP id h5mr9290878wix.14.1367853095688; Mon, 06 May 2013 08:11:35 -0700 (PDT) Original-Received: by 10.217.116.8 with HTTP; Mon, 6 May 2013 08:11:35 -0700 (PDT) In-Reply-To: <87ip2xsb1r.fsf@wanadoo.es> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159374 Archived-At: --f46d043c062edfa47204dc0e1d52 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Sun, May 5, 2013 at 11:26 PM, =D3scar Fuentes wrote: > > However, the real issue being discussed here is if avoiding the overhead > of delete-dups on ido-completing-read warrants breaking some extensions > on a catastrophic way. Upon further reflection, I realized that #10994 is only triggered by runs of the same string. I've attached a patch that removes runs without calling delete-dups. Rough testing indicates it's fast. :) -- Le --f46d043c062edfa47204dc0e1d52 Content-Type: application/octet-stream; name="ido-remove-dups3.diff" Content-Disposition: attachment; filename="ido-remove-dups3.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hgdsccpm0 ZGlmZiAtLWdpdCBhL2xpc3AvaWRvLmVsIGIvbGlzcC9pZG8uZWwKaW5kZXggYmVkZjAwZS4uNzNh YjM5ZSAxMDA2NDQKLS0tIGEvbGlzcC9pZG8uZWwKKysrIGIvbGlzcC9pZG8uZWwKQEAgLTMxNTks OCArMzE1OSw3IEBAIFVzZSBgZXEnIGZvciBjb21wYXJpc29uLiIKIAkoc29mYXIgbmlsKSkKICAg ICAod2hpbGUgKG5vdCByZXQpCiAgICAgICAoc2V0cSBuZXh0IChjYXIgaXRlbXMpKQotICAgICAg OzsgVXNlIGBlcScgdG8gYXZvaWQgYnVnIGh0dHA6Ly9kZWJidWdzLmdudS5vcmcvMTA5OTQKLSAg ICAgIChpZiAoZXEgbmV4dCBlbGVtKQorICAgICAgKGlmIChlcXVhbCBuZXh0IGVsZW0pCiAJICAo c2V0cSByZXQgKGFwcGVuZCBpdGVtcyAobnJldmVyc2Ugc29mYXIpKSkKIAk7OyBlbHNlCiAJKHBy b2duCkBAIC0zNzg3LDcgKzM3ODYsNyBAQCBUaGlzIGlzIHRvIG1ha2UgdGhlbSBhcHBlYXIgYXMg aWYgdGhleSB3ZXJlIFwidmlydHVhbCBidWZmZXJzXCIuIgogCSAgIChpZiAoc3RyaW5nLW1hdGNo IHJlIG5hbWUpCiAJICAgICAgIChzZXRxIG1hdGNoZXMgKGNvbnMgaXRlbSBtYXRjaGVzKSkpKSkK ICAgICAgICBpdGVtcykpCi0gICAgbWF0Y2hlcykpCisgICAgKGlkby1kZWxldGUtcnVucyBtYXRj aGVzKSkpCiAKIAogKGRlZnVuIGlkby1zZXQtbWF0Y2hlcyAoKQpAQCAtNDY3OCw2ICs0Njc3LDI1 IEBAIEZvciBkZXRhaWxzIG9mIGtleWJpbmRpbmdzLCBzZWUgYGlkby1maW5kLWZpbGUnLiIKIAkJ CSAgICAgIGlkby10ZW1wLWxpc3QpKSkpCiAgICAgKGlkby10by1lbmQgc3VtbWFyaWVzKSkpCiAK KworKGRlZnVuIGlkby1kZWxldGUtcnVucyAobGlzdCkKKyAgIkRlbGV0ZSBjb25zZWN1dGl2ZSBy dW5zIG9mIHNhbWUgaXRlbSBpbiBsaXN0LgorQ29tcGFyaXNvbiBkb25lIHdpdGggYGVxdWFsJy4g IFJ1bnMgbWF5IGxvb3AgYmFjayBvbiB0byB0aGUgZmlyc3QKK2l0ZW0sIGluIHdoaWNoIGNhc2Us IHRoZSBlbmRpbmcgaXRlbXMgYXJlIGRlbGV0ZWQuIgorICAobGV0ICgodGFpbCBsaXN0KQorICAg ICAgICBiZWZvcmUtbGFzdC1ydW4pCisgICAgKHdoaWxlIHRhaWwKKyAgICAgIChpZiAoY29uc3Ag KGNkciB0YWlsKSkKKyAgICAgICAgICAoaWYgKGVxdWFsIChjYXIgdGFpbCkgKGNhZHIgdGFpbCkp CisgICAgICAgICAgICAgIChzZXRjZHIgdGFpbCAoY2RkciB0YWlsKSkKKyAgICAgICAgICAgIChz ZXRxIGJlZm9yZS1sYXN0LXJ1biB0YWlsKQorICAgICAgICAgICAgKHNldHEgdGFpbCAoY2RyIHRh aWwpKSkKKyAgICAgICAgKHNldHEgdGFpbCAoY2RyIHRhaWwpKSkpCisgICAgKHdoZW4gKGFuZCBi ZWZvcmUtbGFzdC1ydW4KKyAgICAgICAgICAgICAgIChlcXVhbCAoY2FyIGxpc3QpIChjYWRyIGJl Zm9yZS1sYXN0LXJ1bikpKQorICAgICAgKHNldGNkciBiZWZvcmUtbGFzdC1ydW4gbmlsKSkpCisg IGxpc3QpCisKIDs7OyBIZWxwZXIgZnVuY3Rpb25zIGZvciBvdGhlciBwcm9ncmFtcwogCiAocHV0 ICdkaXJlZC1kby1yZW5hbWUgJ2lkbyAnaWdub3JlKQo= --f46d043c062edfa47204dc0e1d52--