From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Le Wang Newsgroups: gmane.emacs.devel Subject: Re: fix for bug 10994 breaks ido customizations in major way Date: Sat, 4 May 2013 15:00:24 +0800 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=047d7bd9202a94efe704dbdf057a X-Trace: ger.gmane.org 1367650835 14479 80.91.229.3 (4 May 2013 07:00:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 4 May 2013 07:00:35 +0000 (UTC) Cc: emacs-devel@gnu.org To: Leo Liu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 04 09:00:34 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UYWSM-0007RY-Fp for ged-emacs-devel@m.gmane.org; Sat, 04 May 2013 09:00:30 +0200 Original-Received: from localhost ([::1]:41927 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYWSM-0003FC-6F for ged-emacs-devel@m.gmane.org; Sat, 04 May 2013 03:00:30 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYWSI-0003F5-V8 for emacs-devel@gnu.org; Sat, 04 May 2013 03:00:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UYWSI-0007Q4-3J for emacs-devel@gnu.org; Sat, 04 May 2013 03:00:26 -0400 Original-Received: from mail-wg0-x22f.google.com ([2a00:1450:400c:c00::22f]:35926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYWSH-0007Pm-TD for emacs-devel@gnu.org; Sat, 04 May 2013 03:00:26 -0400 Original-Received: by mail-wg0-f47.google.com with SMTP id e11so2153028wgh.26 for ; Sat, 04 May 2013 00:00:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=G9tXWciFa4Sc7lHZyEuJaT/yo9SCADUMvbeWR/HEwt0=; b=XwivVOwRN/+pfC6HOyFn6QbYogyxnqs/mQX+R0FPqwYpd/D1yPVtuh3K0XEt2JzPIr JPYJIwMg3+jewHN/aEsiEk3jQpOuPo1EiE8fXWO7KMziaPf5waNWnTNAr33pdd9x7+ZN Lb9rRqZddiQnU9qltNxXHqoPVOGcUfhQCi6pN0OGUfNflkac0gfMmxPw65tf21TMms+y U+HzYF1o5vJUR8fWMcs/W2NQbspT17QcxgH/CVqzoKlDo+Y/zYYq4xgU3PV8s6fUV2fR g2nVdoQopC96tGKKtPtdSyj3bxIaFC6zeo/rVqCZOdqRaKgv2DgCQawYXLjGKJBut0or HSzg== X-Received: by 10.195.13.75 with SMTP id ew11mr4698245wjd.25.1367650824677; Sat, 04 May 2013 00:00:24 -0700 (PDT) Original-Received: by 10.217.116.8 with HTTP; Sat, 4 May 2013 00:00:24 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159284 Archived-At: --047d7bd9202a94efe704dbdf057a Content-Type: multipart/alternative; boundary=047d7bd9202a94efe404dbdf0578 --047d7bd9202a94efe404dbdf0578 Content-Type: text/plain; charset=ISO-8859-1 On Sat, May 4, 2013 at 4:33 AM, Leo Liu wrote: > On 2013-05-03 20:49 +0800, Le Wang wrote: > > There are a few ido customizations floating around that propertizes text. > > This will break all of them. I don't think this fix is acceptable. > > That I wouldn't know. I only know what is in emacs and that the fix has > been in use for a while. Feel free to propose a different fix > Sure, I've attached a patch that deletes duplicates. -- Le --047d7bd9202a94efe404dbdf0578 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Sat, May 4, 2013 at 4:33 AM, Leo Liu = <sdl.web@gmail.co= m> wrote:
On 2013-05-03 20:49 +0800, Le Wang wrote:
> There are a few ido customizations floating around that propertizes te= xt.
> =A0This will break all of them. =A0I don't think this fix is accep= table.

That I wouldn't know. I only know what is in emacs and that the f= ix has
been in use for a while. =A0Feel free to propose a different fix

Sure, I've attached a patch that = deletes duplicates.

--
Le
--047d7bd9202a94efe404dbdf0578-- --047d7bd9202a94efe704dbdf057a Content-Type: application/octet-stream; name="ido-remove-dups.diff" Content-Disposition: attachment; filename="ido-remove-dups.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hgafpjq60 ZGlmZiAtLWdpdCBhL2xpc3AvaWRvLmVsIGIvbGlzcC9pZG8uZWwKaW5kZXggYmVkZjAwZS4uZWI0 MmY0ZSAxMDA2NDQKLS0tIGEvbGlzcC9pZG8uZWwKKysrIGIvbGlzcC9pZG8uZWwKQEAgLTMxNTks OCArMzE1OSw3IEBAIFVzZSBgZXEnIGZvciBjb21wYXJpc29uLiIKIAkoc29mYXIgbmlsKSkKICAg ICAod2hpbGUgKG5vdCByZXQpCiAgICAgICAoc2V0cSBuZXh0IChjYXIgaXRlbXMpKQotICAgICAg OzsgVXNlIGBlcScgdG8gYXZvaWQgYnVnIGh0dHA6Ly9kZWJidWdzLmdudS5vcmcvMTA5OTQKLSAg ICAgIChpZiAoZXEgbmV4dCBlbGVtKQorICAgICAgKGlmIChlcXVhbCBuZXh0IGVsZW0pCiAJICAo c2V0cSByZXQgKGFwcGVuZCBpdGVtcyAobnJldmVyc2Ugc29mYXIpKSkKIAk7OyBlbHNlCiAJKHBy b2duCkBAIC0zNDYyLDcgKzM0NjEsNyBAQCBUaGlzIGlzIHRvIG1ha2UgdGhlbSBhcHBlYXIgYXMg aWYgdGhleSB3ZXJlIFwidmlydHVhbCBidWZmZXJzXCIuIgogICA7OyBSZXR1cm4gdGhlIGN1cnJl bnQgbGlzdCBvZiBjaG9pY2VzLgogICA7OyBJZiBERUZBVUxUIGlzIG5vbi1uaWwsIGFuZCBjb3Jy ZXNwb25kcyB0byBhbiBlbGVtZW50IG9mIGNob2ljZXMsCiAgIDs7IGl0IGlzIHB1dCB0byB0aGUg c3RhcnQgb2YgdGhlIGxpc3QuCi0gIChsZXQgKChpZG8tdGVtcC1saXN0IGlkby1jaG9pY2UtbGlz dCkpCisgIChsZXQgKChpZG8tdGVtcC1saXN0IChkZWxldGUtZHVwcyBpZG8tY2hvaWNlLWxpc3Qp KSkKICAgICAoaWYgZGVmYXVsdAogCShwcm9nbgogCSAgKHNldHEgaWRvLXRlbXAtbGlzdAo= --047d7bd9202a94efe704dbdf057a--