From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lynn Winebarger Newsgroups: gmane.emacs.devel Subject: Re: Adding with-editor to Emacs? Date: Sun, 3 Sep 2023 13:02:49 -0400 Message-ID: References: <85msy98sni.fsf@elpa.gnu.org> <87r0nidkmt.fsf@bernoul.li> <83bkelc1p1.fsf@gnu.org> <87fs3xwzxm.fsf@bernoul.li> <837cp9bur7.fsf@gnu.org> <87a5u5wskw.fsf@bernoul.li> <8334zxayhx.fsf@gnu.org> <871qfgbg13.fsf@bernoul.li> <83v8cs8kts.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33238"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jonas Bernoulli , stefankangas@gmail.com, emacs-devel@gnu.org, rms@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 03 19:03:47 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcqVm-0008OW-8v for ged-emacs-devel@m.gmane-mx.org; Sun, 03 Sep 2023 19:03:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcqV9-0001cM-By; Sun, 03 Sep 2023 13:03:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcqV8-0001cC-4u for emacs-devel@gnu.org; Sun, 03 Sep 2023 13:03:06 -0400 Original-Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcqV6-0006aH-0K; Sun, 03 Sep 2023 13:03:05 -0400 Original-Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-26f6b2c8e80so504025a91.1; Sun, 03 Sep 2023 10:03:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693760581; x=1694365381; darn=gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UniQIXI7MF1527QevJSvpjprtAwjatCYuIz0DHk0NTQ=; b=o+DNN8uy8/UQVZYbFoYt/7OXiJ/Eqo/wqC4H3vjaXFo5pmEw4SabgdUiAYaBHcN3x+ QBSUEIL9HKqVYkTxFl+kYSRNsPh62cppocuMALcdrThgzORBskutyXBpMyJ0N+gEF1r7 Db+Fm2Xh2p5nT4PYX3jkTNw0j0zhM3+A6PxDjsJ80eDwg9vAvddQW1WgiJgNTbwKyudD YghUrilcHUOwJLMjc4M6TMCOLAUW9Qctdcxwx3lTEoSVg0XIxG0TO1AYauVWeFdKkCEm Fi3HRY+m0tTtJH8bGwlTiU2WFAnh5brAeYZN+R1b5n+igLcq8TIx+o9hk4y10yvRx+AW ff5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693760581; x=1694365381; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UniQIXI7MF1527QevJSvpjprtAwjatCYuIz0DHk0NTQ=; b=J/kNk48iWCsoZkQcQOR7dk/V3QM175OyjmXh9Aky/JhvCGzlZ4HlFSeGZFS5dc8pEE fV0l6KrCnL4LzZbwpZoodtG36ngCaaaE/RJ/YB5PSezuRmcI89DCeVibKwkHO6MOe/2a gA4G70PiTFkOAEGzm95bAq+bxNEcBqXcgLmYMo3FSi611TOUMFB1EcsbUOoId1Eot2/Q qeI8j1S8UjTz+EHKPOdgWXY+lsKEzJsKjoyYuxkvGmYFmD1VYUN3qYZoNEc1QxFTv9Hr N11mbdNxoOw3DpGFAqbYghC/KrARUgx2t8aFv/1m2dCnzEmlGdN2KEetZUjmej8MwbHM u1lg== X-Gm-Message-State: AOJu0YyowW5t7r67gtY55OBukT/lAhKxNDjcyxDkoGbdar/ZU0Klan1y 9jluIhL2lV+IivAady1xgG0WNRuauQkbMy6iqpX3QOg3 X-Google-Smtp-Source: AGHT+IGzhDgp+muXoRlhXwWNQwqHg2bfgkHYQCnRsmVU8giWPI0X84bE6aUz/T0o2yw3wtVEBGlO/Q9WHBYiT9LJGoY= X-Received: by 2002:a17:90a:db4c:b0:268:5c3b:6f37 with SMTP id u12-20020a17090adb4c00b002685c3b6f37mr7453448pjx.0.1693760581507; Sun, 03 Sep 2023 10:03:01 -0700 (PDT) In-Reply-To: <83v8cs8kts.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::1029; envelope-from=owinebar@gmail.com; helo=mail-pj1-x1029.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310009 Archived-At: On Sat, Sep 2, 2023 at 2:58=E2=80=AFPM Eli Zaretskii wrote: > > From: Jonas Bernoulli > > Cc: stefankangas@gmail.com, emacs-devel@gnu.org, rms@gnu.org > > Date: Sat, 02 Sep 2023 20:12:40 +0200 > > > > > Then I guess you should describe all those atrocities in detail, so > > > that we could perhaps devise ways of handling it. > > > > I do not have a list of those atrocities and I do not have the bandwidt= h > > and motivation to compile that in the next few months. I have code tha= t > > deals with it though (with-editor-locate-emacsclient and the functions > > it uses). Using git to trace the history of that code, would give you > > commits with explanations and/or links to places were the issues that > > are being addressed were described. > > It's not that easy: AFAIU, with-editor was part of Magit, and was > separated into a repository of its own not very long ago. And the > answers to my questions seem to be before the split. > > I also looked at the present code and found it to have quite a few > non-trivial parts whose purpose I couldn't easily explain or guess, > and which are not explained in the comments, either. > > So, if you have no time or motivation to describe the problems you > tried to solve with that code, I guess someone else will need to find > out and describe the problems in a way that we could then consider for > inclusion. I cannot myself afford digging through the Magit's Git > repository to find the description of these problems, sorry. > > Or maybe Richard already knows the answers, since he thought this > should be added to Emacs. > Just to put it out there, wouldn't putting the basic function in core emacs, without all the workarounds for packaging fails, put the onus on the packager to either adhere to the standard layout or patch their distribution to make the function work accordingly? That seems like one of the benefits of a package being included in the core. Lynn