From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lynn Winebarger Newsgroups: gmane.emacs.devel Subject: Re: Adding with-editor to Emacs? Date: Sun, 3 Sep 2023 14:21:46 -0400 Message-ID: References: <85msy98sni.fsf@elpa.gnu.org> <87r0nidkmt.fsf@bernoul.li> <83bkelc1p1.fsf@gnu.org> <87fs3xwzxm.fsf@bernoul.li> <837cp9bur7.fsf@gnu.org> <87a5u5wskw.fsf@bernoul.li> <8334zxayhx.fsf@gnu.org> <871qfgbg13.fsf@bernoul.li> <83v8cs8kts.fsf@gnu.org> <835y4r6ulj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9253"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jonas@bernoul.li, stefankangas@gmail.com, emacs-devel@gnu.org, rms@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 03 20:22:25 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcrjt-0002AA-Dg for ged-emacs-devel@m.gmane-mx.org; Sun, 03 Sep 2023 20:22:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcrjY-0007sY-Mh; Sun, 03 Sep 2023 14:22:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcrjX-0007rt-0l for emacs-devel@gnu.org; Sun, 03 Sep 2023 14:22:03 -0400 Original-Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcrjU-0005pk-PY; Sun, 03 Sep 2023 14:22:02 -0400 Original-Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1bf078d5f33so6093035ad.3; Sun, 03 Sep 2023 11:21:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693765318; x=1694370118; darn=gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7bmcr6T8w21jVRZuDPKoos+MHKAl3pUAcKksqJHeChM=; b=QkfRTqIgIkhsH8zPxZGlImN5aQp4Ow+6X0yAc/XuDQHiWnG4M21rH0RKyAG5kK54EI eZTBwIEFC/2PbWt7dYD/if7yTUscrHVLWSJ1sZ7AwyqcqAuwr3GW+dOTjiNTHId23i5e lk0gzpvzBwTxGRsL8i/aZyrRvbHzU0F0C7eytNjW5stI6zi/0xHRuaXff/2x7cYVYqL7 hm6EYny3TuuttxTny94+mAT8rmnnX9VxqECL3Kt+00yHJEHo7j8it6E2uJwZIwFWNlgl uvEImruvN0u5aJ0IUaALaKqGrqy4Gs1OA6YuNHr/W/lYB0lVyWZ59MJoU9TcJvKqwwyv B8sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693765318; x=1694370118; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7bmcr6T8w21jVRZuDPKoos+MHKAl3pUAcKksqJHeChM=; b=gNInecqvNEG18xusoMcllOOH+wJALzFsrBzleqSGmZZaZzIoHF44bUV9f8YUxJXjRd lrSP9HChe32VHhX7NM/6llNltpNHpOpihZ+gAaZPk+lH4gsb99YxytYQN7v8XDknoLw+ JWRpXlJr8uoVHtqZsVu8dBYKpSC6H4Y2sVn3wXCKKix4JreqWHVYNDmS3qFYp87Z+lta da9m9ITqWdfLjV1VaM10rIAUg0NPXPpNu5+/UuOn1BGPxgInhR6YOUqzJbb4NWA0RTi6 cgWd1pkDTXaG3plNB4ssoZ4/0ApmG5GrnQmVHPuSHs6v1+77YctM4mgj4+2sOel+X9zf vMNA== X-Gm-Message-State: AOJu0Yy4BrpMMubccO6pEasU0upUjcO7siYE6o3vprHg+53ICn5HKvZz YYMX9y6bpklUcmzjFNy2BM4+2B4AdCrC4xaBytGtO8ondx4= X-Google-Smtp-Source: AGHT+IEIX/1N875MuxbeZCBKa4nsrisyN+7orQKXC6LYtBWO5VdPHMPHYFoQPKj+T6jSP57234gPql/CLaUe0W1kGHM= X-Received: by 2002:a17:902:8643:b0:1bb:ffcc:8eba with SMTP id y3-20020a170902864300b001bbffcc8ebamr8116403plt.58.1693765318197; Sun, 03 Sep 2023 11:21:58 -0700 (PDT) In-Reply-To: <835y4r6ulj.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::62f; envelope-from=owinebar@gmail.com; helo=mail-pl1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310017 Archived-At: On Sun, Sep 3, 2023 at 1:22=E2=80=AFPM Eli Zaretskii wrote: > > From: Lynn Winebarger > > > > Just to put it out there, wouldn't putting the basic function in core > > emacs, without all the workarounds for packaging fails, put the onus > > on the packager to either adhere to the standard layout or patch their > > distribution to make the function work accordingly? That seems like > > one of the benefits of a package being included in the core. > > I don't think I understand what you are saying here. At least one > sentence failed to parse. It seemed to me the problems Jonas described with finding the correct emacsclient binary resulted from the library being in an external package rather than part of the GNU Emacs distribution. That is, if the "with-editor" function were * implemented in a core emacs library following the simple approach you suggested, based on the built-in expected location of emacsclient * had a test to verify this function works when installed then failures due to odd packaging conventions or plain oversight would be the responsibility of the emacs packager/distribution. The failures could be fixed either by adopting the standard layout or by patching the emacs distribution. Either way, it would not be the concern of the core emacs maintainer of the library containing the with-editor function. That is one of the benefits of being upstream from emacs distributions (as a GNU emacs contributor) instead of "downstream" of the distribution as a package author. At least, it would seem that way. Lynn