From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bozhidar Batsov Newsgroups: gmane.emacs.devel Subject: Re: Upcoming seq.el version problem with the Emacs release Date: Sun, 20 Mar 2016 16:20:28 +0200 Message-ID: References: <87vb5osrv0.fsf@petton.fr> <877fhz8cb5.fsf@petton.fr> <87lh5jxvm0.fsf@petton.fr> <87vb4h316o.fsf@petton.fr> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1140b4729e15eb052e7bae99 X-Trace: ger.gmane.org 1458483661 3219 80.91.229.3 (20 Mar 2016 14:21:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 20 Mar 2016 14:21:01 +0000 (UTC) Cc: John Wiegley , Artur Malabarba , emacs-devel To: Nicolas Petton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 20 15:20:55 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aheDu-0005FI-2z for ged-emacs-devel@m.gmane.org; Sun, 20 Mar 2016 15:20:54 +0100 Original-Received: from localhost ([::1]:53125 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aheDt-0001bv-11 for ged-emacs-devel@m.gmane.org; Sun, 20 Mar 2016 10:20:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aheDX-0001bq-2X for emacs-devel@gnu.org; Sun, 20 Mar 2016 10:20:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aheDV-0006Hk-QH for emacs-devel@gnu.org; Sun, 20 Mar 2016 10:20:31 -0400 Original-Received: from mail-io0-x22e.google.com ([2607:f8b0:4001:c06::22e]:33894) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aheDV-0006Hg-IC; Sun, 20 Mar 2016 10:20:29 -0400 Original-Received: by mail-io0-x22e.google.com with SMTP id m184so185707549iof.1; Sun, 20 Mar 2016 07:20:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=Wizg6S6o348ud/1FZKOK1b2wFZBitE1N/Qt9dh85lIY=; b=VDxOyGA1osQgg1BLgApVSmOX2TNsaiUKLBs4RthqTRtBOCdnywv6KcGCeSfxXgRM6x vbKwBMsLPbCix08Me8bf8RwvVXyac4sM3449IzbONa5HqNmQRVdueRhw2W2axns0GiDs f6qQplUZMKc/it6IRAq2vzgE/p913k8lyRtw/gsEIdctN8eFcBU4t9ynIxflUtbb6MWY 6WCmgA0mWL3MAvcNrc3OpDcjiG5qImxW5cSp7NC/tJZ0oh8Eu3q2K/c3aM2jHWb3aFC+ EAVd5V4MsrLTX1+sFF5HG2y4xRRwLhyHOAmx11oFC8rFqfTEWT0Khuq9M6GuC6IMrq3C R34w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=batsov-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=Wizg6S6o348ud/1FZKOK1b2wFZBitE1N/Qt9dh85lIY=; b=PwQdFmxMv+kJyPbgczV/lfxI01F7+YLmfbME6XAJdCJXpPSm6TcAA8Wp5rD8pYpfxc neipDtM27tgb5g6/ADiV7v6jhdVtQoxqD9yJSE0WQfM45vgUrJSnQD4GdeQRB/EzXKMH KYbuW84ImrYLtZtDkNY4KTXJR365ENEggyolGG4o+fbxv47epHsGkM0GNwqmHaAsVTzs zTjqCeIvgS2JQl6iXah2+JJfg/Dzjazefmv1F6dcDRY0jCffApd+aWyqvO3pbmtwrrPS oLghobjlN5XkhJPETyN4l+6gJLSiKarSy9x8GNIXVDaFeZuEoKLpaEc0XyDy7xcP/3hx 2mww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=Wizg6S6o348ud/1FZKOK1b2wFZBitE1N/Qt9dh85lIY=; b=NvKRqQi09jYYHZ2Ayese+qHPHf6jEDCRw+L66uqF4nIxlJGfkcKsieZrvjyo6RYLgz eMlizvJlH9mEeHa5Q4c5PDWTOuWMsKrR4oQwUs556GaaJB8PqKY0GwcC+U0KUXYRxZ/r WbuBFTuawAdTYfwk9e7bEN4AcDYVyB+a1YT4+8UTO3FiFI54IuQoAPuB16RIupDfXxFf M4G4kbhzgyATFrgsWy4CpLw5dXUjpsVwZytf4lfAtk+NtWMKe6k4dpw4HPcp+rtzKb0O V4xgTSY6BTgUwQjooMSu1N9v7Jm7sYxrsb93kOlSb/SxfN4kZ+30sY39PvOFAbVS+peg TpoA== X-Gm-Message-State: AD7BkJL+3Lwm5WPoTME9etHocfY0qEc7Ylyukd/rGyFJRkOnjtDOFsh8MImtzDNCMwfNha6mOJS6Y5Oc90b+VQ== X-Received: by 10.107.157.70 with SMTP id g67mr22331518ioe.38.1458483629001; Sun, 20 Mar 2016 07:20:29 -0700 (PDT) Original-Received: by 10.107.154.85 with HTTP; Sun, 20 Mar 2016 07:20:28 -0700 (PDT) In-Reply-To: <87vb4h316o.fsf@petton.fr> X-Google-Sender-Auth: VqyrNmIJGK-NRhp39QFlR6OR0PQ X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4001:c06::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201934 Archived-At: --001a1140b4729e15eb052e7bae99 Content-Type: text/plain; charset=UTF-8 Ah, now I get it. Thanks for the info! On 20 March 2016 at 12:15, Nicolas Petton wrote: > Bozhidar Batsov writes: > > > I might be missing something here, but what exactly is so problematic - > > there are packages that are in Emacs and on ELPA (e.g. cl-lib) and I > don't > > think they are taking any special measures. > > The problem is that seq.el (in Emacs) uses `pcase-defmacro', which does > not exist in Emacs 24.5. When byte-compiling the file, we get warnings > as the byte compiler will think that `pcase-defmacro' is a function. > > The solution I'm going for is to define locally the macro (when > byte-compiling the file in Emacs < 25), using something like the > following: > > (push `(pcase-defmacro . ,(lambda (&rest _) nil)) > byte-compile-macro-environment) > > You can read more about the issue here: > https://github.com/NicolasPetton/seq.el/issues/7 > > Nico > -- > Nicolas Petton > http://nicolas-petton.fr > --001a1140b4729e15eb052e7bae99 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Ah, now I get it. Thanks for the info!

On 20 March 2016 at 12:15, Nico= las Petton <nicolas@petton.fr> wrote:
Bozhidar Batsov <<= a href=3D"mailto:bozhidar@batsov.com">bozhidar@batsov.com> writes:
> I might be missing something here, but what exactly is so problematic = -
> there are packages that are in Emacs and on ELPA (e.g. cl-lib) and I d= on't
> think they are taking any special measures.

The problem is that seq.el (in Emacs) uses `pcase-defmacro'= , which does
not exist in Emacs 24.5.=C2=A0 When byte-compiling the file, we get warning= s
as the byte compiler will think that `pcase-defmacro' is a function.
The solution I'm going for is to define locally the macro (when
byte-compiling the file in Emacs < 25), using something like the
following:

=C2=A0 =C2=A0 (push `(pcase-defmacro . ,(lambda (&rest _) nil))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 byte-compile-macro-environment)

You can read more about the issue here:
https://github.com/NicolasPetton/seq.el/issues/7=

Nico
--
Nicolas Petton
h= ttp://nicolas-petton.fr

--001a1140b4729e15eb052e7bae99--