Re: Small improvements to ruby-mode

[Bozhidar Batsov <bozhidar@batsov.com>]

[-- Attachment #1: Type: text/plain, Size: 1557 bytes --]

On 9 July 2013 17:36, Bozhidar Batsov <bozhidar@batsov.com> wrote:

> I've noticed two more font look issues (I guess I'm becoming annoying :-)
> ):
>
> - ?c, ?x, ?\n, ?\C-\M-d, etc should be font-locked as strings I guess,
> since from Ruby 1.9 the character literal syntax actually yields strings.
>
> - there should be support for the new %I/%i literals from Ruby 2.0 - I
> guess we should font-lock them as symbols
>

And one more:

Currently we use the same face (font-lock-type-face) for both
classes/modules and constants. Classes and Modules are mandatory
CamelCase(although Camel_Case is also valid, albeit it's considered
extremely poor style) and just about everyone uses SCREAMING_SNAKE_CASE for
constants so I'd suggest to use font-lock-constant-face for constants.


>
>
> On 9 July 2013 15:55, Bozhidar Batsov <bozhidar@batsov.com> wrote:
>
>> Great!
>>
>>
>> On 9 July 2013 04:19, Dmitry Gutov <dgutov@yandex.ru> wrote:
>>
>>> On 08.07.2013 13:37, Bozhidar Batsov wrote:
>>>
>>>> I noticed a couple of more font locking problems that we might want to
>>>> address. They are related to method names. Consider this code
>>>>
>>>>
>>>> def self.some_name ....
>>>>
>>>> def SomeClass.some_name ...
>>>>
>>>> self and SomeClass are currently highlighted with the same face as the
>>>> method name, although they are not actually part of the method name.
>>>> self should be highlighted with the variable face and class/modules with
>>>> the type face.
>>>>
>>>
>>> Should be fixed now. :) Along with the negation char fontification.
>>>
>>
>>
>

[-- Attachment #2: Type: text/html, Size: 2880 bytes --]