From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bozhidar Batsov Newsgroups: gmane.emacs.devel Subject: Re: trunk r115158: * lisp/progmodes/ruby-mode.el (ruby-custom-encoding-magic-comment-template): Date: Fri, 22 Nov 2013 00:51:22 +0200 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b472a409541c304ebb7bcae X-Trace: ger.gmane.org 1385074286 13940 80.91.229.3 (21 Nov 2013 22:51:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Nov 2013 22:51:26 +0000 (UTC) Cc: emacs-devel To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 21 23:51:32 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vjd5w-0005j7-8c for ged-emacs-devel@m.gmane.org; Thu, 21 Nov 2013 23:51:32 +0100 Original-Received: from localhost ([::1]:35654 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vjd5v-0007AE-9S for ged-emacs-devel@m.gmane.org; Thu, 21 Nov 2013 17:51:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vjd5r-00077T-4Z for emacs-devel@gnu.org; Thu, 21 Nov 2013 17:51:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vjd5p-000722-S6 for emacs-devel@gnu.org; Thu, 21 Nov 2013 17:51:27 -0500 Original-Received: from mail-ob0-x22a.google.com ([2607:f8b0:4003:c01::22a]:56528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vjd5o-00071N-8A; Thu, 21 Nov 2013 17:51:24 -0500 Original-Received: by mail-ob0-f170.google.com with SMTP id wp18so489168obc.15 for ; Thu, 21 Nov 2013 14:51:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=YK1fitvLk0fyFweZaTqSOCU2pOs33ZzAyP5cntXE3zI=; b=Ufr35j/nmi8qRuHXnndrsNN6Hk1KgAhaujjBao22D0nytEMEABAZvp1j9D5SZGsXVS HuBXBLT1SC520RbHvC02ZRT2NhSDqX9r+K3QEQmByjKAI0K8EUy9a+Hf1HCR6XM/jHxw I0e5A9so/EY826T4RLrD+auo32rUVTEictUlic13X1w4vbF/casqFtYTYb9hudDorDOb cK+NGsiAYlBqqpkbDGz/3+we3uVLadg8EYBiHTcLlgk0URBxUvDXY2/T2yXnpPTNKxOE 3jn6RTz2fi+YUCGm9kBQqS3FVqSfj10r3CFnabgaJ/QM3+bEK7srCszawf9nK4i1AB/w cWng== X-Received: by 10.60.141.225 with SMTP id rr1mr3868550oeb.55.1385074282281; Thu, 21 Nov 2013 14:51:22 -0800 (PST) Original-Received: by 10.76.21.207 with HTTP; Thu, 21 Nov 2013 14:51:22 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: rbudKq68OP-v_0Uggch_4XnxM6s X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c01::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165510 Archived-At: --047d7b472a409541c304ebb7bcae Content-Type: text/plain; charset=UTF-8 Seems odd to include such trivial changes in the changelog, as nobody is likely to be interested in reading about them. This particular defcustom was recently introduced, that's why I considered altering its default an extremely tiny change. As for the tests - I'll change the state of the problematic test to have expected-result :failed. Sorry about that. Btw, what's the value of listing test changes in the changelog? Seems to me that pretty few people would be interested in reading about such changes. On 21 November 2013 17:41, Glenn Morris wrote: > > Hi, > > Please add a ChangeLog entry at the appropriate date for this and other > recent changes (to test). Also, defcustom with non-trivial changes > should get :version bumps (don't know if this is non-trivial). > > Seems lke test ruby-exit!-font-lock should have expected-result :failed > for now, else it causes a coverage failure on hydra, which could mask > the introduction of real problems. > > See eg http://hydra.nixos.org/build/6852191 > --047d7b472a409541c304ebb7bcae Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Seems odd to include such trivial changes in the changelog= , as nobody is likely to be interested in reading about them. This particul= ar defcustom was recently introduced, that's why I considered altering = its default an extremely tiny change.=C2=A0

As for the tests - I'll change the state of the problema= tic test to have expected-result :failed. Sorry about that. Btw, what's= the value of listing test changes in the changelog? Seems to me that prett= y few people would be interested in reading about such changes.


On 21 N= ovember 2013 17:41, Glenn Morris <rgm@gnu.org> wrote:

Hi,

Please add a ChangeLog entry at the appropriate date for this and other
recent changes (to test). Also, defcustom with non-trivial changes
should get :version bumps (don't know if this is non-trivial).

Seems lke test ruby-exit!-font-lock should have expected-result :failed
for now, else it causes a coverage failure on hydra, which could mask
the introduction of real problems.

See eg h= ttp://hydra.nixos.org/build/6852191

--047d7b472a409541c304ebb7bcae--