all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Bozhidar Batsov <bozhidar@batsov.com>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: trunk r115158: * lisp/progmodes/ruby-mode.el (ruby-custom-encoding-magic-comment-template):
Date: Fri, 22 Nov 2013 00:51:22 +0200	[thread overview]
Message-ID: <CAM9Zgm3J7G5qqS9ZswXppsCid0qyXrWsUuFOhqTK4_32zx-nGA@mail.gmail.com> (raw)
In-Reply-To: <chwqk192zx.fsf@fencepost.gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

Seems odd to include such trivial changes in the changelog, as nobody is
likely to be interested in reading about them. This particular defcustom
was recently introduced, that's why I considered altering its default an
extremely tiny change.

As for the tests - I'll change the state of the problematic test to have
expected-result :failed. Sorry about that. Btw, what's the value of listing
test changes in the changelog? Seems to me that pretty few people would be
interested in reading about such changes.


On 21 November 2013 17:41, Glenn Morris <rgm@gnu.org> wrote:

>
> Hi,
>
> Please add a ChangeLog entry at the appropriate date for this and other
> recent changes (to test). Also, defcustom with non-trivial changes
> should get :version bumps (don't know if this is non-trivial).
>
> Seems lke test ruby-exit!-font-lock should have expected-result :failed
> for now, else it causes a coverage failure on hydra, which could mask
> the introduction of real problems.
>
> See eg http://hydra.nixos.org/build/6852191
>

[-- Attachment #2: Type: text/html, Size: 1468 bytes --]

  reply	other threads:[~2013-11-21 22:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1Vj5RK-0003OM-4J@vcs.savannah.gnu.org>
2013-11-21 15:41 ` trunk r115158: * lisp/progmodes/ruby-mode.el (ruby-custom-encoding-magic-comment-template): Glenn Morris
2013-11-21 22:51   ` Bozhidar Batsov [this message]
2013-11-21 23:07     ` Glenn Morris
2013-11-21 23:17       ` Glenn Morris
2013-11-22 12:38         ` Bozhidar Batsov
2013-11-23  2:37           ` Glenn Morris
2013-11-23 13:23             ` Bozhidar Batsov
2013-11-25 19:40               ` Glenn Morris
2013-11-26  6:47                 ` Bozhidar Batsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM9Zgm3J7G5qqS9ZswXppsCid0qyXrWsUuFOhqTK4_32zx-nGA@mail.gmail.com \
    --to=bozhidar@batsov.com \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.